jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
Use Python conditional expressions instead of boolean operators

Change-Id: I5fbf36d40dbe5bc77affd45fb29c3959995884fb
---
M pywikibot/site.py
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pywikibot/site.py b/pywikibot/site.py
index d9b3149..ff300fd 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -3622,8 +3622,8 @@
bltitle = page.title(withSection=False).encode(self.encoding())
blargs = {"gbltitle": bltitle}
if filterRedirects is not None:
- blargs["gblfilterredir"] = (filterRedirects and "redirects" or
- "nonredirects")
+ blargs['gblfilterredir'] = ('redirects' if filterRedirects
+ else 'nonredirects')
blgen = self._generator(api.PageGenerator, type_arg="backlinks",
namespaces=namespaces, total=total,
g_content=content, **blargs)
@@ -3679,8 +3679,8 @@
eiargs = {"geititle":
page.title(withSection=False).encode(self.encoding())}
if filterRedirects is not None:
- eiargs["geifilterredir"] = (filterRedirects and "redirects" or
- "nonredirects")
+ eiargs['geifilterredir'] = ('redirects' if filterRedirects
+ else 'nonredirects')
return self._generator(api.PageGenerator, type_arg='embeddedin',
namespaces=namespaces, total=total,
g_content=content, **eiargs)
@@ -7020,7 +7020,7 @@
"""
if offset:
offset = pywikibot.Timestamp.fromtimestampformat(offset)
- offset_dir = reverse and 'rev' or 'fwd'
+ offset_dir = 'rev' if reverse else 'fwd'

params = {'action': 'flow', 'submodule': 'view-topiclist',
'page': page,

To view, visit change 435688. To unsubscribe, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fbf36d40dbe5bc77affd45fb29c3959995884fb
Gerrit-Change-Number: 435688
Gerrit-PatchSet: 1
Gerrit-Owner: Matěj Suchánek <matejsuchanek97@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444@gmail.com>
Gerrit-Reviewer: jenkins-bot <>