jenkins-bot submitted this change.

View Change

[cleanup] Deprecate empty_iterator

If all we want is an empty iterator then "iter(())" works just as well.

Change-Id: I1d1e4fc12b0b831e34b762cab56cce3eafaab8eb
---
M pywikibot/tools/__init__.py
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py
index f68af5d..13b7bff 100644
--- a/pywikibot/tools/__init__.py
+++ b/pywikibot/tools/__init__.py
@@ -1014,7 +1014,7 @@
 
     def __iter__(self):
         """An iterator which does nothing and drops the argument."""
-        return empty_iterator()
+        return iter(())
 
     def __getitem__(self, key):
         """Raise always a L{CombinedError}."""
@@ -1928,6 +1928,8 @@
 
 
 wrapper = ModuleDeprecationWrapper(__name__)
+wrapper._add_deprecated_attr('empty_iterator', replacement_name='iter(())',
+                             since='20220422', future_warning=True)
 wrapper._add_deprecated_attr('DotReadableDict', replacement_name='',
                              since='20210416', future_warning=True)
 wrapper._add_deprecated_attr('frozenmap',

To view, visit change 682026. To unsubscribe, or for help writing mail filters, visit settings.