[tests] Skip test on proofwiki on github action

Access to proofwiki is forbidden (status 403) if called from
github action. Skip this test then instead of expect the failure.

Bug: T331223
Change-Id: Ice47cf3ae7883bfa4012e7b8fea4b7a2008d9dd7
---
M tests/site_detect_tests.py
1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/tests/site_detect_tests.py b/tests/site_detect_tests.py
index 918d76f..6173ff7 100755
--- a/tests/site_detect_tests.py
+++ b/tests/site_detect_tests.py
@@ -18,7 +18,7 @@
 from pywikibot.site_detect import MWSite
 
 from tests.aspects import PatchingTestCase, TestCase
-from tests.utils import DrySite, expected_failure_if, skipping
+from tests.utils import DrySite, skipping
 
 
 class SiteDetectionTestCase(TestCase):
@@ -58,7 +58,6 @@
     """Test detection of MediaWiki sites."""
 
     standard_version_sites = (
-        # 'http://www.proofwiki.org/wiki/$1',
         'http://www.ck-wissen.de/ckwiki/index.php?title=$1',
         'http://en.citizendium.org/wiki/$1',
         # Server that hosts www.wikichristian.org is unreliable - it
@@ -113,10 +112,10 @@
             with self.subTest(url=urlparse(url).netloc):
                 self.assertSite(url)
 
-    @expected_failure_if(os.getenv('GITHUB_ACTIONS'))  # T331223
     def test_proofreadwiki(self):
         """Test detection of proofwiki.org site."""
-        # test is failing on github, see T331223
+        if os.getenv('GITHUB_ACTIONS'):
+            self.skipTest('Skip test on github due to T331223')
         self.assertSite('http://www.proofwiki.org/wiki/$1')
 
     def test_non_standard_version_sites(self):

