jenkins-bot merged this change.

View Change

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
[cleanup] cleanup scripts/ndashredir.py

- use single quotes for string literals and double quotes
**only** if they consist of single quotes within them
- use str.format(...) instead of modulo for type specifier
arguments

Change-Id: I9f0d0409495b4c2e6280be886b1fabe94576e974
---
M scripts/ndashredir.py
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/scripts/ndashredir.py b/scripts/ndashredir.py
index 86dd098..7339090 100644
--- a/scripts/ndashredir.py
+++ b/scripts/ndashredir.py
@@ -91,8 +91,8 @@

# skip unchanged
if redir.title() == origin:
- pywikibot.output('No need to process %s, skipping…'
- % redir.title())
+ pywikibot.output('No need to process {0}, skipping...'
+ .format(redir.title()))
# suggest -reversed parameter
if '-' in origin and not self.getOption('reversed'):
pywikibot.output('Consider using -reversed parameter '
@@ -100,13 +100,13 @@
else:
# skip existing
if redir.exists():
- pywikibot.output('%s already exists, skipping…'
- % redir.title())
+ pywikibot.output('{0} already exists, skipping...'
+ .format(redir.title()))
else:
# confirm and save redirect
if self.user_confirm(
color_format(
- 'Redirect from {lightblue}{0}{default} doesn\'t exist '
+ "Redirect from {lightblue}{0}{default} doesn't exist "
'yet.\nDo you want to create it?',
redir.title())):
# If summary option is None, it takes the default

To view, visit change 462466. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f0d0409495b4c2e6280be886b1fabe94576e974
Gerrit-Change-Number: 462466
Gerrit-PatchSet: 1
Gerrit-Owner: D3r1ck01 <alangiderick@gmail.com>
Gerrit-Reviewer: D3r1ck01 <alangiderick@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: jenkins-bot (75)