jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1251548?usp=email )
Change subject: [bugfix] No longer try to follow interwiki redirects
......................................................................
[bugfix] No longer try to follow interwiki redirects
If a redirect target is an interwiki link, a InterwikiRedirectPageError
is raised. Catch this exception in site.pagebacklinks() and don't
try to catch any further backlinks.
Bug: T121833
Change-Id: I1a0e093024d6876e18a5033936507149911ccfa6
---
M pywikibot/site/_generators.py
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site/_generators.py b/pywikibot/site/_generators.py
index bc429cd..21978e9 100644
--- a/pywikibot/site/_generators.py
+++ b/pywikibot/site/_generators.py
@@ -21,6 +21,7 @@
APIError,
Error,
InconsistentTitleError,
+ InterwikiRedirectPageError,
InvalidTitleError,
NoPageError,
UserRightsError,
@@ -296,7 +297,12 @@
# was created) they can be returned as redirects to
# themselves; skip these
continue
- if redir.getRedirectTarget() == page:
+ try:
+ target = redir.getRedirectTarget()
+ except InterwikiRedirectPageError:
+ target = None
+
+ if target and target == page:
genlist[redir.title()] = self.pagebacklinks(
redir, follow_redirects=True,
filter_redirects=filter_redirects,
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1251548?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I1a0e093024d6876e18a5033936507149911ccfa6
Gerrit-Change-Number: 1251548
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Thibaut120094 <thibaut120094(a)outlook.fr>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1253411?usp=email )
Change subject: [bugfix] use generator.close() instead of stop() in speedy_delete.py
......................................................................
[bugfix] use generator.close() instead of stop() in speedy_delete.py
BaseBot.stop() was removed in Pywikibot 7.0.0 (2022) in favour of
BaseBot.generator.close(). The deprecation was made in
Pywikibot 4.1 (2020) already.
Bug: T420169
Change-Id: I3e2b7e0778bc8fe26857b9058efdbad9f6703953
---
M scripts/speedy_delete.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Xqt: Verified; Looks good to me, approved
diff --git a/scripts/speedy_delete.py b/scripts/speedy_delete.py
index 7c0d8ec..8af4de8 100755
--- a/scripts/speedy_delete.py
+++ b/scripts/speedy_delete.py
@@ -447,7 +447,7 @@
elif choice == 'u':
pywikibot.info('Updating from CSD category.')
self.saved_progress = page.title()
- self.stop()
+ self.generator.close()
# delete the current page
elif choice == 'd':
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1253411?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I3e2b7e0778bc8fe26857b9058efdbad9f6703953
Gerrit-Change-Number: 1253411
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1257188?usp=email )
Change subject: doc: Update generate_user_files documentation
......................................................................
doc: Update generate_user_files documentation
Bug: T420811
Change-Id: If5b6e426b156581fbeb5b5d2f3617d26c933ee0d
---
M pywikibot/scripts/generate_user_files.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/scripts/generate_user_files.py b/pywikibot/scripts/generate_user_files.py
index eaccaa0..678d7d7 100755
--- a/pywikibot/scripts/generate_user_files.py
+++ b/pywikibot/scripts/generate_user_files.py
@@ -4,8 +4,11 @@
#
# Distributed under the terms of the MIT license.
#
-"""Script to create user-config.py. Other file names are not supported.
+"""Script to create user-config.py and user-password.cfg if required.
+.. version-changed:: 3.0.20190722
+ ``user-fixes.py`` is no longer created. Use the
+ ``user-fixes.py.sample`` file instead.
.. version-changed:: 7.0
moved to pywikibot.scripts folder.
.. version-changed:: 8.0
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1257188?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: If5b6e426b156581fbeb5b5d2f3617d26c933ee0d
Gerrit-Change-Number: 1257188
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot