Pywikibot-commits June 2024

pywikibot-commits@lists.wikimedia.org

1 participants
109 discussions

[Gerrit] ...core[master]: [bugfix] Fix code within f-string
by jenkins-bot (Code Review) 29 Jun '24

29 Jun '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050741?usp=email ) Change subject: [bugfix] Fix code within f-string ...................................................................... [bugfix] Fix code within f-string Bug: T368837 Change-Id: Iec64a30651f119e582bcf041ab816ce286c9530e --- M pywikibot/backports.py M tests/tools_deprecate_tests.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/backports.py b/pywikibot/backports.py index 815f7d3..76f8162 100644 --- a/pywikibot/backports.py +++ b/pywikibot/backports.py @@ -185,7 +185,7 @@ msg = 'batched(): incomplete batch' if PYTHON_VERSION < (3, 12): if not isinstance(n, int): - raise TypeError(f'{type(n),__name__!r} object cannot be' + raise TypeError(f'{type(n).__name__!r} object cannot be' ' interpreted as an integer') group = [] for item in iterable: diff --git a/tests/tools_deprecate_tests.py b/tests/tools_deprecate_tests.py index 582a973..c54dc84 100755 --- a/tests/tools_deprecate_tests.py +++ b/tests/tools_deprecate_tests.py @@ -473,7 +473,7 @@ def test_deprecate_and_remove_function_args(self): """Test @deprecated and removed function argument.""" - deprecation_msg = f' argument of {__name__ }.deprecated_func_arg3' + deprecation_msg = f' argument of {__name__}.deprecated_func_arg3' rv = deprecated_func_arg3() self.assertIsNone(rv) self.assertNoDeprecation() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Iec64a30651f119e582bcf041ab816ce286c9530e Gerrit-Change-Number: 1050741 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [tests] Remove experimental flag in lint tests
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050722?usp=email ) Change subject: [tests] Remove experimental flag in lint tests ...................................................................... [tests] Remove experimental flag in lint tests Bug: T359513 Change-Id: Ib6f7d836a14b46a866b6ff19400147de70d4a524 --- M .github/workflows/lint_tests.yml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/lint_tests.yml b/.github/workflows/lint_tests.yml index cdf83e1..6f0749a 100644 --- a/.github/workflows/lint_tests.yml +++ b/.github/workflows/lint_tests.yml @@ -25,7 +25,6 @@ matrix: python-version: [ "pypy3.7", "pypy3.10", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0", "3.14-dev" ] deps: [ flake8, hacking ] - experimental: [ true ] steps: - name: Checkout Repository @@ -54,7 +53,6 @@ - name: Flake8 tests id: ci_test - continue-on-error: true timeout-minutes: 10 run: | python --version -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ib6f7d836a14b46a866b6ff19400147de70d4a524 Gerrit-Change-Number: 1050722 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] ...core[master]: [tests] Remove experimental flag in lint tests
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050720?usp=email ) Change subject: [tests] Remove experimental flag in lint tests ...................................................................... [tests] Remove experimental flag in lint tests Bug: T359513 Change-Id: I93481fac183cda90e46d4ebb6ebcf7ecbae83f5e --- M .github/workflows/lint_tests.yml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Xqt: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/.github/workflows/lint_tests.yml b/.github/workflows/lint_tests.yml index cdf83e1..141a30d 100644 --- a/.github/workflows/lint_tests.yml +++ b/.github/workflows/lint_tests.yml @@ -25,7 +25,6 @@ matrix: python-version: [ "pypy3.7", "pypy3.10", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0", "3.14-dev" ] deps: [ flake8, hacking ] - experimental: [ true ] steps: - name: Checkout Repository -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I93481fac183cda90e46d4ebb6ebcf7ecbae83f5e Gerrit-Change-Number: 1050720 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

[Gerrit] ...core[master]: [tests] Fix matrix.deps in lint tests
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050719?usp=email ) Change subject: [tests] Fix matrix.deps in lint tests ...................................................................... [tests] Fix matrix.deps in lint tests Change-Id: I25e7afe1e81a83881c137a5acc6bae99ca2c8bf1 --- M .github/workflows/lint_tests.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/lint_tests.yml b/.github/workflows/lint_tests.yml index 78e9bde..cdf83e1 100644 --- a/.github/workflows/lint_tests.yml +++ b/.github/workflows/lint_tests.yml @@ -50,7 +50,7 @@ run: | python -m pip install --upgrade pip pip --version - pip install .[${{deps}}] + pip install .[${{matrix.deps}}] - name: Flake8 tests id: ci_test -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I25e7afe1e81a83881c137a5acc6bae99ca2c8bf1 Gerrit-Change-Number: 1050719 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] ...core[master]: [tests] add hacking to lint tests
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050718?usp=email ) Change subject: [tests] add hacking to lint tests ...................................................................... [tests] add hacking to lint tests Change-Id: I9320c67c35681e4c2b3c74f85cad7ae8a3b8e2a0 --- M .github/workflows/lint_tests.yml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/lint_tests.yml b/.github/workflows/lint_tests.yml index 6f531d1..78e9bde 100644 --- a/.github/workflows/lint_tests.yml +++ b/.github/workflows/lint_tests.yml @@ -24,6 +24,7 @@ matrix: python-version: [ "pypy3.7", "pypy3.10", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0", "3.14-dev" ] + deps: [ flake8, hacking ] experimental: [ true ] steps: @@ -49,7 +50,7 @@ run: | python -m pip install --upgrade pip pip --version - pip install .[flake8] + pip install .[${{deps}}] - name: Flake8 tests id: ci_test -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I9320c67c35681e4c2b3c74f85cad7ae8a3b8e2a0 Gerrit-Change-Number: 1050718 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] ...core[master]: [tests] Fix lint_tests.yml
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050716?usp=email ) Change subject: [tests] Fix lint_tests.yml ...................................................................... [tests] Fix lint_tests.yml Change-Id: I3768c7be293153042bf5478a94201a83799875e0 --- M .github/workflows/lint_tests.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/lint_tests.yml b/.github/workflows/lint_tests.yml index d16646e..6f531d1 100644 --- a/.github/workflows/lint_tests.yml +++ b/.github/workflows/lint_tests.yml @@ -11,7 +11,7 @@ env: PYWIKIBOT_TEST_RUNNING: 1 - PYWIKIBOT_NO_USER_CONFIG=2 + PYWIKIBOT_NO_USER_CONFIG: 2 jobs: build: -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I3768c7be293153042bf5478a94201a83799875e0 Gerrit-Change-Number: 1050716 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-CC: jenkins-bot

1 0

[Gerrit] ...core[master]: [tests] Run lint tests on GitHub
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050712?usp=email ) Change subject: [tests] Run lint tests on GitHub ...................................................................... [tests] Run lint tests on GitHub Bug: T359513 Change-Id: I0c9027472a240f4cd5c2be54c9ef3fc112d9519f --- A .github/workflows/lint_tests.yml 1 file changed, 61 insertions(+), 0 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/lint_tests.yml b/.github/workflows/lint_tests.yml new file mode 100644 index 0000000..d16646e --- /dev/null +++ b/.github/workflows/lint_tests.yml @@ -0,0 +1,61 @@ +name: Lint test +# Run Pywikibot lint tests with a variety of Python versions + +on: + push: + branches: [ master, stable ] + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +env: + PYWIKIBOT_TEST_RUNNING: 1 + PYWIKIBOT_NO_USER_CONFIG=2 + +jobs: + build: + runs-on: "ubuntu-latest" + continue-on-error: ${{ matrix.experimental || false }} + timeout-minutes: 100 + + strategy: + fail-fast: false + + matrix: + python-version: [ "pypy3.7", "pypy3.10", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0", "3.14-dev" ] + experimental: [ true ] + + steps: + - name: Checkout Repository + uses: actions/checkout@v4 + with: + submodules: true + + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v5 + if: "!endsWith(matrix.python-version, '-dev')" + with: + python-version: ${{ matrix.python-version }} + + # use deadsnakes/action for development releases + - name: Set up development Python ${{ matrix.python-version }} + uses: deadsnakes/action(a)v3.1.0 + if: "endsWith(matrix.python-version, '-dev')" + with: + python-version: ${{ matrix.python-version }} + + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip --version + pip install .[flake8] + + - name: Flake8 tests + id: ci_test + continue-on-error: true + timeout-minutes: 10 + run: | + python --version + flake8 --version + flake8 --color always --doctests -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I0c9027472a240f4cd5c2be54c9ef3fc112d9519f Gerrit-Change-Number: 1050712 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] ...core[master]: [tests] Move Pywikibot tests from Appveyor to Github action
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050709?usp=email ) Change subject: [tests] Move Pywikibot tests from Appveyor to Github action ...................................................................... [tests] Move Pywikibot tests from Appveyor to Github action Solely Python 3.7.0 tests are tested on Appveyor because they aren't avaliable at GitHub Bug: T368192 Change-Id: If84db61a00aa2f57b0898b38d4afe69870206246 --- M .appveyor.yml M .github/workflows/windows_tests.yml 2 files changed, 12 insertions(+), 48 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.appveyor.yml b/.appveyor.yml index 32f9c65..8598385 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -22,32 +22,12 @@ PYTHON_VERSION: "3.7.0" PYTHON_ARCH: "32" - - # AppVeyor pre-installs these versions onto build machines - - - PYTHON: "C:\\Python37-x64" - PYTHON_VERSION: "3.7.x" + - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013 + PYTHON: "C:\\Python37" + PYTHON_VERSION: "3.7.0" PYTHON_ARCH: "64" - - PYTHON: "C:\\Python38" - PYTHON_VERSION: "3.8.x" - PYTHON_ARCH: "32" - - - PYTHON: "C:\\Python39-x64" - PYTHON_VERSION: "3.9.x" - PYTHON_ARCH: "64" - - - PYTHON: "C:\\Python310" - PYTHON_VERSION: "3.10.x" - PYTHON_ARCH: "32" - - - PYTHON: "C:\\Python311-x64" - PYTHON_VERSION: "3.11.x" - PYTHON_ARCH: "64" - - - PYTHON: "C:\\Python312" - PYTHON_VERSION: "3.12.x" - PYTHON_ARCH: "32" + # Other versions are tested with GutHub actions matrix: fast_finish: false @@ -66,9 +46,10 @@ - python -c "import struct; print('PYTHON_ARCH:', struct.calcsize('P') << 3)" - python -m pip install --upgrade pip - pip --version + # required for Python 3.7.0 - if [%PYTHON_VERSION%]==[3.7.0] pip install "urllib3<2.0" - if [%PYTHON_VERSION%]==[3.7.0] pip install -U setuptools - - if [%PYTHON_VERSION%]==[3.12.x] pip install -U setuptools + # other requirements - pip install -r requirements.txt - pip install -r dev-requirements.txt - pip install wikitextparser @@ -76,9 +57,6 @@ build: off test_script: - - chcp 65001 - - set PYTHONIOENCODING=utf8 - - "mkdir %PYWIKIBOT_DIR%" - "python -Werror::UserWarning -m pwb generate_user_files -dir:%PYWIKIBOT_DIR% -family:wikipedia -lang:en -v -debug -user:%PYWIKIBOT_USERNAME%" - ps: "[IO.File]::AppendAllText($env:PYWIKIBOT_USER_CONFIG, 'maximum_GET_length = 5000; transliteration_target = None;')" diff --git a/.github/workflows/windows_tests.yml b/.github/workflows/windows_tests.yml index 9c2fea2..12a560b 100644 --- a/.github/workflows/windows_tests.yml +++ b/.github/workflows/windows_tests.yml @@ -3,8 +3,6 @@ on: push: - branches: [ master, stable ] - pull_request: branches: [ master ] concurrency: @@ -17,7 +15,7 @@ jobs: build: - runs-on: ${{ matrix.os || 'windows-latest' }} + runs-on: "windows-latest" continue-on-error: ${{ matrix.experimental || false }} timeout-minutes: 100 @@ -26,7 +24,7 @@ max-parallel: 10 matrix: - python-version: [ "3.7.0", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0" ] + python-version: [ "3.7.1", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0" ] python-arch: [ x64, x86 ] site: [ "wikipedia:en" ] experimental: [ true ] @@ -39,15 +37,6 @@ - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v5 - if: "!endsWith(matrix.python-version, '-dev')" - with: - python-version: ${{ matrix.python-version }} - architecture: ${{ matrix.python-arch }} - - # use deadsnakes/action for development releases - - name: Set up development Python ${{ matrix.python-version }} - uses: deadsnakes/action(a)v3.1.0 - if: "endsWith(matrix.python-version, '-dev')" with: python-version: ${{ matrix.python-version }} architecture: ${{ matrix.python-arch }} @@ -59,17 +48,13 @@ python -c "import struct; print('PYTHON_ARCH:', struct.calcsize('P') << 3)" python -m pip install --upgrade pip pip --version - if [ ${{matrix.python-version}} == '3.7.0' ]; then pip install "urllib3<2.0"; fi - if [ ${{matrix.python-version}} == '3.7.0' ]; then pip install -U setuptools; fi - if [ ${{matrix.python-version}} >= '3.12' ]; then pip install -U setuptools; fi - if [ -f dev-requirements.txt ]; then pip install -r dev-requirements.txt; fi - if [ -f requirements.txt ]; then pip install -r requirements.txt; fi + pip install -r dev-requirements.txt + pip install -r requirements.txt pip install wikitextparser - name: Generate user files run: | python -Werror::UserWarning -m pwb generate_user_files -site:${{matrix.site}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; - echo "usernames['wikipedia']['en'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py echo "usernames['wikisource']['zh'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py echo "usernames['wikipedia']['test'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py echo "usernames['wikidata']['test'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py @@ -77,12 +62,13 @@ echo "usernames['meta']['meta'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py echo "noisysleep = float('inf')" >> user-config.py echo "maximum_GET_length = 5000" >> user-config.py + echo "transliteration_target = None" >> user-config.py echo "console_encoding = 'utf8'" >> user-config.py echo "import os" >> user-config.py echo "password_file = os.path.expanduser('passwordfile')" >> user-config.py echo "('${{ env.PYWIKIBOT_USERNAME }}', '${{ secrets.PYWIKIBOT_USERPWD }}')" > passwordfile - - name: Test with unittest or pytest + - name: Test with unittest id: ci_test continue-on-error: true timeout-minutes: 90 -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050709?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If84db61a00aa2f57b0898b38d4afe69870206246 Gerrit-Change-Number: 1050709 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] ...core[master]: [tests] fix windows_tests.yml
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050706?usp=email ) Change subject: [tests] fix windows_tests.yml ...................................................................... [tests] fix windows_tests.yml Change-Id: I0e4e33444b8730e97b004439d6fa3755fdeefeb4 --- M .github/workflows/windows_tests.yml 1 file changed, 2 insertions(+), 22 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/.github/workflows/windows_tests.yml b/.github/workflows/windows_tests.yml index f8a4da4..9c2fea2 100644 --- a/.github/workflows/windows_tests.yml +++ b/.github/workflows/windows_tests.yml @@ -66,22 +66,9 @@ if [ -f requirements.txt ]; then pip install -r requirements.txt; fi pip install wikitextparser - - name: Generate family files - run: | - if [ ${{matrix.family || 0}} == wpbeta ]; then - python pwb.py generate_family_file http://${{matrix.code}}.wikipedia.beta.wmflabs.org/ wpbeta y - fi - if [ ${{matrix.site || 0}} == 'wsbeta:en' ]; then - python pwb.py generate_family_file http://en.wikisource.beta.wmflabs.org/ wsbeta y - fi - - name: Generate user files run: | - if [ ${{matrix.site}} != false ]; then - python -Werror::UserWarning -m pwb generate_user_files -site:${{matrix.site}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; - else - python -Werror::UserWarning -m pwb generate_user_files -family:${{matrix.family}} -lang:${{matrix.code}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; - fi + python -Werror::UserWarning -m pwb generate_user_files -site:${{matrix.site}} -user:${{ env.PYWIKIBOT_USERNAME }} -v -debug; echo "usernames['wikipedia']['en'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py echo "usernames['wikisource']['zh'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py echo "usernames['wikipedia']['test'] = '${{ env.PYWIKIBOT_USERNAME }}'" >> user-config.py @@ -99,16 +86,9 @@ id: ci_test continue-on-error: true timeout-minutes: 90 - env: - PYWIKIBOT_TEST_NO_RC: - ${{ (matrix.site == 'wikisource:zh' || matrix.test_no_rc) && 1 || 0 }} run: | python pwb.py version - if [ ${{matrix.site || 0}} != 'wikipedia:test' ]; then - coverage run -m unittest discover -vv -p \"*_tests.py\"; - else - pytest --cov=.; - fi + coverage run -m unittest discover -vv -p \"*_tests.py\"; - name: Show coverage statistics run: | -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I0e4e33444b8730e97b004439d6fa3755fdeefeb4 Gerrit-Change-Number: 1050706 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de>

1 0

[Gerrit] ...core[master]: [tests] Remove PYWIKIBOT_TEST_PROD_ONLY test directive
by Xqt (Code Review) 29 Jun '24

29 Jun '24

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050704?usp=email ) Change subject: [tests] Remove PYWIKIBOT_TEST_PROD_ONLY test directive ...................................................................... [tests] Remove PYWIKIBOT_TEST_PROD_ONLY test directive Prod only tests were introduced as temporary workaround for a bug on Travis with test sites. Tests on Travis was dropped, therefor this teporary fix can be removed after 9 years. Bug: T96943 Change-Id: I25026b59b6bfc0049b16ea3ff8034189d3a00264 --- M .github/workflows/pywikibot-ci.yml M .github/workflows/windows_tests.yml M tests/aspects.py 3 files changed, 0 insertions(+), 10 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index 511f07b..c85c233 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -28,7 +28,6 @@ matrix: python-version: [ "pypy3.7", "pypy3.10", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0", "3.14-dev" ] site: [ "wikipedia:en", "wikisource:zh" ] - test_prod_only: [ true ] include: - python-version: "3.7" site: wikipedia:test @@ -122,7 +121,6 @@ env: PYWIKIBOT_TEST_NO_RC: ${{ (matrix.site == 'wikisource:zh' || matrix.test_no_rc) && 1 || 0 }} - PYWIKIBOT_TEST_PROD_ONLY: ${{ matrix.test_prod_only && 1 || 0 }} run: | python pwb.py version if [ ${{matrix.site || 0}} != 'wikipedia:test' ]; then diff --git a/.github/workflows/windows_tests.yml b/.github/workflows/windows_tests.yml index afa0b9a..f8a4da4 100644 --- a/.github/workflows/windows_tests.yml +++ b/.github/workflows/windows_tests.yml @@ -29,7 +29,6 @@ python-version: [ "3.7.0", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13.0-alpha - 3.13.0" ] python-arch: [ x64, x86 ] site: [ "wikipedia:en" ] - test_prod_only: [ false ] experimental: [ true ] steps: @@ -103,7 +102,6 @@ env: PYWIKIBOT_TEST_NO_RC: ${{ (matrix.site == 'wikisource:zh' || matrix.test_no_rc) && 1 || 0 }} - PYWIKIBOT_TEST_PROD_ONLY: ${{ matrix.test_prod_only && 1 || 0 }} run: | python pwb.py version if [ ${{matrix.site || 0}} != 'wikipedia:test' ]; then diff --git a/tests/aspects.py b/tests/aspects.py index 3b22a58..a64d9b9 100644 --- a/tests/aspects.py +++ b/tests/aspects.py @@ -893,13 +893,7 @@ if dry: interface = DrySite - prod_only = os.environ.get('PYWIKIBOT_TEST_PROD_ONLY', '0') == '1' for data in cls.sites.values(): - if (data.get('code') in ('test', 'mediawiki') - and prod_only and not dry): - raise unittest.SkipTest(f"Site code {data['code']!r} and" - ' PYWIKIBOT_TEST_PROD_ONLY is set.') - if 'site' not in data and 'code' in data and 'family' in data: with suppress_warnings(WARN_SITE_CODE, category=UserWarning): data['site'] = Site(data['code'], data['family'], -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1050704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I25026b59b6bfc0049b16ea3ff8034189d3a00264 Gerrit-Change-Number: 1050704 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits June 2024