Pywikibot-commits May 2024

pywikibot-commits@lists.wikimedia.org

1 participants
95 discussions

[Gerrit] ...core[master]: version.py: Remove line endings in getversion_nightly
by jenkins-bot (Code Review) 02 May '24

02 May '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1026185?usp=email ) Change subject: version.py: Remove line endings in getversion_nightly ...................................................................... version.py: Remove line endings in getversion_nightly The version strings are eventually passed into the user agent, and having a linebreak results in a user agent such as: script (wikipedia:test; User:Bot) Pywikibot/9.2.0.dev1 (1\n) requests/2.28.2 Python/3.9.2.final.0 This \n causes the result to fail with error: pywikibot.exceptions.FatalServerError: Invalid leading whitespace, reserved character(s), or returncharacter(s) in header value. Fix this by, instead of using readlines, which preserves the line endings, read the entire file and split by linebreak, which implicitly removes all the line endings. Bug: T363943 Change-Id: I38f9b27d3339916dc6b784ecda602055924aa6bc --- M pywikibot/version.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/version.py b/pywikibot/version.py index 542c480..40793a0 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -259,7 +259,7 @@ file = Path(path or _get_program_dir()) / 'pywikibot' / 'version' with file.open() as data: - (tag, rev, date, hsh) = data.readlines() + (tag, rev, date, hsh) = data.read().splitlines() date = time.strptime(date[:19], '%Y-%m-%dT%H:%M:%S') -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1026185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I38f9b27d3339916dc6b784ecda602055924aa6bc Gerrit-Change-Number: 1026185 Gerrit-PatchSet: 3 Gerrit-Owner: Zhuyifei1999 <zhuyifei1999(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] Add version_tests.py
by jenkins-bot (Code Review) 02 May '24

02 May '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1026462?usp=email ) Change subject: [tests] Add version_tests.py ...................................................................... [tests] Add version_tests.py Currently test_nightly_version method will fail until T363943 is solved. Bug: T363943 Change-Id: Ie3c26c84927d4561fadb2b23bcd94126f8216b6f --- M docs/tests_ref/index.rst A docs/tests_ref/version_tests.rst M pywikibot/version.py A tests/data/version A tests/version_tests.py 5 files changed, 88 insertions(+), 3 deletions(-) Approvals: Zhuyifei1999: Looks good to me, approved Framawiki: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/docs/tests_ref/index.rst b/docs/tests_ref/index.rst index 7340817..2072f0e 100644 --- a/docs/tests_ref/index.rst +++ b/docs/tests_ref/index.rst @@ -81,6 +81,7 @@ ui<./ui_tests> user<./user_tests> utils + version<./version_tests> wikibase_edit<./wikibase_edit_tests> wikibase<./wikibase_tests> wikistats<./wikistats_tests> diff --git a/docs/tests_ref/version_tests.rst b/docs/tests_ref/version_tests.rst new file mode 100644 index 0000000..d08e1be --- /dev/null +++ b/docs/tests_ref/version_tests.rst @@ -0,0 +1,8 @@ +*************************** +tests.version\_tests module +*************************** + +.. automodule:: tests.version_tests + :members: + :undoc-members: + :show-inheritance: diff --git a/pywikibot/version.py b/pywikibot/version.py index 542c480..db6a084 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -241,7 +241,7 @@ return (tag, rev, date, hsh) -def getversion_nightly(path: str | Path | None = None): # pragma: no cover +def getversion_nightly(path: str | Path | None = None): """Get version info for a nightly release. .. hint:: @@ -256,7 +256,10 @@ - hash (git hash for the current revision) :rtype: ``tuple`` of three ``str`` and a ``time.struct_time`` """ - file = Path(path or _get_program_dir()) / 'pywikibot' / 'version' + file = Path(path or _get_program_dir()) + if not path: + file /= 'pywikibot' + file /= 'version' with file.open() as data: (tag, rev, date, hsh) = data.readlines() @@ -287,7 +290,7 @@ return (tag, rev, date, hsh) -def getversion_onlinerepo(path: str = 'branches/master'): +def getversion_onlinerepo(path: str = 'branches/master') -> str: """Retrieve current framework git hash from Gerrit.""" # Gerrit API responses include )]}' at the beginning, # make sure to strip it out diff --git a/tests/data/version b/tests/data/version new file mode 100644 index 0000000..91f8372 --- /dev/null +++ b/tests/data/version @@ -0,0 +1,4 @@ +nightly/core_stable +1 +2024-05-02T01:04:51 +e8f64f2 diff --git a/tests/version_tests.py b/tests/version_tests.py new file mode 100644 index 0000000..c9364f5 --- /dev/null +++ b/tests/version_tests.py @@ -0,0 +1,69 @@ +#!/usr/bin/env python3 +"""Test cases for the :mod:`version` module. + +.. versionadded:: 9.2 +""" +# +# (C) Pywikibot team, 2024 +# +# Distributed under the terms of the MIT license. +# +from __future__ import annotations + +import time +import unittest +from contextlib import suppress +from pathlib import Path + +from pywikibot import version +from tests.aspects import TestCase + + +class LocalVersionTestCase(TestCase): + + """Test local version infomation.""" + + net = False + + @unittest.expectedFailure # T363943 + def test_nightly_version(self): + """Test version file of nightly dump.""" + path = Path(__file__).parent / 'data' + tag, rev, date, hsh, *dummy = version.getversion_nightly(path) + self.assertEqual(tag, 'nightly/core') + self.assertEqual(rev, '1') + self.assertIsInstance(date, time.struct_time) + self.assertEqual(hsh, '567a31d') + self.assertEqual(dummy, []) + + def test_package_version(self): + """Test package version.""" + tag, rev, date, hsh, *dummy = version.getversion_package() + self.assertEqual(tag, 'pywikibot/__init__.py') + self.assertEqual(rev, '-1 (unknown)') + self.assertIsInstance(date, time.struct_time) + self.assertEqual(hsh, '') + self.assertEqual(dummy, []) + + +class RemoteVersionTestCase(TestCase): + + """Test remote version infomation.""" + + net = True + + def test_onlinerepo_version(self): + """Test online repository hash.""" + for branch in ('master', 'stable'): + with self.subTest(branch=branch): + hsh = version.getversion_onlinerepo('branches/' + branch) + try: + int(hsh, 16) + except ValueError: + self.fail( + f'{hsh!r} is not a valid hash of {branch} branch') + + +if __name__ == '__main__': + with suppress(SystemExit): + unittest.main() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1026462?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ie3c26c84927d4561fadb2b23bcd94126f8216b6f Gerrit-Change-Number: 1026462 Gerrit-PatchSet: 6 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org> Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [cleanup] i18n.TranslationError was removed in Pywikibot 7
by jenkins-bot (Code Review) 02 May '24

02 May '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1026598?usp=email ) Change subject: [cleanup] i18n.TranslationError was removed in Pywikibot 7 ...................................................................... [cleanup] i18n.TranslationError was removed in Pywikibot 7 Change-Id: I37be3ce061631b9a77db4c27d30fd7767ff87eac --- M pywikibot/exceptions.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/exceptions.py b/pywikibot/exceptions.py index 998c2c8..9104e7b 100644 --- a/pywikibot/exceptions.py +++ b/pywikibot/exceptions.py @@ -77,11 +77,11 @@ - NoUsernameError: Username is not in user config file, or it is invalid. - PageInUseError: Page cannot be reserved due to a lock - SectionError: The section specified by # does not exist - - TranslationError: no language translation found + - TranslationError: no language translation found, i18n/l10n message + not available - UnknownExtensionError: Extension is not defined for this site - UserRightsError: insufficient rights for requested action - VersionParseError: failed to parse version information - - i18n.TranslationError: i18n/l10n message not available APIError: wiki API returned an error -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1026598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I37be3ce061631b9a77db4c27d30fd7767ff87eac Gerrit-Change-Number: 1026598 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...core[master]: [tests] upload_tests is a framework test rather than a script test
by jenkins-bot (Code Review) 02 May '24

02 May '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1026584?usp=email ) Change subject: [tests] upload_tests is a framework test rather than a script test ...................................................................... [tests] upload_tests is a framework test rather than a script test Change-Id: Ic1a734bbce7e7e7ed22cf7a4036f6da91b027a45 --- M docs/tests_ref/index.rst 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/docs/tests_ref/index.rst b/docs/tests_ref/index.rst index 7340817..22fed99 100644 --- a/docs/tests_ref/index.rst +++ b/docs/tests_ref/index.rst @@ -79,6 +79,7 @@ tools<./tools_tests> ui_options<./ui_options_tests> ui<./ui_tests> + upload<./upload_tests> user<./user_tests> utils wikibase_edit<./wikibase_edit_tests> @@ -117,5 +118,4 @@ reflinks<./reflinks_tests> replacebot<./replacebot_tests> template_bot<./template_bot_tests> - upload<./upload_tests> uploadbot<./uploadbot_tests> -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1026584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ic1a734bbce7e7e7ed22cf7a4036f6da91b027a45 Gerrit-Change-Number: 1026584 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

[Gerrit] ...i18n[master]: Localisation updates from https://translatewiki.net.
by jenkins-bot (Code Review) 02 May '24

02 May '24

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/1026541?usp=email ) Change subject: Localisation updates from https://translatewiki.net. ...................................................................... Localisation updates from https://translatewiki.net. Change-Id: I7d952612f210a6014f3db8327d5514d59c148036 --- M category/tly.json 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: L10n-bot: Looks good to me, approved jenkins-bot: Verified diff --git a/category/tly.json b/category/tly.json index a2a795b..4813561 100644 --- a/category/tly.json +++ b/category/tly.json @@ -16,5 +16,5 @@ "category-section-title": "Сәһифә тарихи че канәку %(oldcat)s", "category-version-history": "Робот: Тарихи чы kanə версијәку огәте %(oldcat)s", "category-was-disbanded": "Bot: Kateqoriya ләғв кардә быә", - "category-was-moved": "Bot: Kateqoriya тожәдан ном ноә быә [[:Category:%(newcat)s|%(title)s]]" + "category-was-moved": "Bot: Bə kategorijə tožə nom noə byə [[:Category:%(newcat)s|%(title)s]]" } -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/1026541?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/i18n Gerrit-Branch: master Gerrit-Change-Id: I7d952612f210a6014f3db8327d5514d59c148036 Gerrit-Change-Number: 1026541 Gerrit-PatchSet: 1 Gerrit-Owner: L10n-bot <l10n-bot(a)translatewiki.net> Gerrit-Reviewer: L10n-bot <l10n-bot(a)translatewiki.net> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits May 2024