Pywikibot-commits April 2023

pywikibot-commits@lists.wikimedia.org

1 participants
130 discussions

[Gerrit] ...core[master]: [cleanup] remove unused error parameter in utils.execute

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910860 ) Change subject: [cleanup] remove unused error parameter in utils.execute ...................................................................... [cleanup] remove unused error parameter in utils.execute - also remove error parameter in utils.execute_pwb and PwbTestCase._execute() which are no longer needed Bug: T335241 Change-Id: I4936c295e2ecc68c5c41958951daae8d2693e326 --- M tests/script_tests.py M tests/utils.py M tests/aspects.py 3 files changed, 34 insertions(+), 17 deletions(-) Approvals: Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/aspects.py b/tests/aspects.py index ba8cc36..d3ebde0 100644 --- a/tests/aspects.py +++ b/tests/aspects.py @@ -1331,12 +1331,12 @@ if self.orig_pywikibot_dir: os.environ['PYWIKIBOT_DIR'] = self.orig_pywikibot_dir - def _execute(self, args, data_in=None, timeout=None, error=None): + def _execute(self, args, data_in=None, timeout=None): site = self.get_site() args += ['-family:' + site.family.name, '-lang:' + site.code] - return execute_pwb(args, data_in, timeout, error) + return execute_pwb(args, data_in, timeout) class RecentChangesTestCase(WikimediaDefaultSiteTestCase): diff --git a/tests/script_tests.py b/tests/script_tests.py index d4e174d..0e9a8c8 100755 --- a/tests/script_tests.py +++ b/tests/script_tests.py @@ -223,7 +223,7 @@ # run the script result = execute_pwb(cmd, data_in, timeout=timeout, - error=error, overrides=test_overrides) + overrides=test_overrides) err_result = result['stderr'] out_result = result['stdout'] diff --git a/tests/utils.py b/tests/utils.py index 5a49e16..b7fc747 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -11,16 +11,17 @@ import warnings from contextlib import contextmanager from subprocess import PIPE, Popen, TimeoutExpired -from typing import Optional +from typing import Any, Optional, Union import pywikibot from pywikibot import config -from pywikibot.backports import List +from pywikibot.backports import Dict, List, Sequence from pywikibot.data.api import CachedRequest from pywikibot.data.api import Request as _original_Request from pywikibot.exceptions import APIError from pywikibot.login import LoginStatus from pywikibot.site import Namespace + from tests import _pwb_py @@ -451,9 +452,11 @@ """Ignore password changes.""" -def execute(command: List[str], data_in=None, timeout=None, error=None): - """ - Execute a command and capture outputs. +def execute(command: List[str], data_in=None, timeout=None): + """Execute a command and capture outputs. + + .. versionchanged:: 8.2.0 + *error* parameter was removed. :param command: executable to run and arguments to use """ @@ -495,14 +498,17 @@ 'stderr': stderr_data.decode(config.console_encoding)} -def execute_pwb(args, data_in=None, timeout=None, error=None, overrides=None): - """ - Execute the pwb.py script and capture outputs. +def execute_pwb(args: List[str], + data_in: Optional[Sequence[str]] = None, + timeout: Union[int, float, None] = None, + overrides: Optional[Dict[str, str]] = None) -> Dict[str, Any]: + """Execute the pwb.py script and capture outputs. + + .. versionchanged:: 8.2.0 + the *error* parameter was removed. :param args: list of arguments for pwb.py - :type args: typing.Sequence[str] :param overrides: mapping of pywikibot symbols to test replacements - :type overrides: dict """ command = [sys.executable] @@ -511,13 +517,11 @@ overrides = '; '.join( f'{key} = {value}' for key, value in overrides.items()) command.append( - 'import pwb; import pywikibot; {}; pwb.main()' - .format(overrides)) + f'import pwb; import pywikibot; {overrides}; pwb.main()') else: command.append(_pwb_py) - return execute(command=command + args, - data_in=data_in, timeout=timeout, error=error) + return execute(command=command + args, data_in=data_in, timeout=timeout) @contextmanager -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910860 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I4936c295e2ecc68c5c41958951daae8d2693e326 Gerrit-Change-Number: 910860 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year

[Gerrit] ...core[master]: [8.2.0d2] Update to r8.2.0d2

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910854 ) Change subject: [8.2.0d2] Update to r8.2.0d2 ...................................................................... [8.2.0d2] Update to r8.2.0d2 - Update ROADMAP.rst and HISTORY.rst - increase development level - fix docstring of ComparableMixin._cmpkey() Change-Id: I2a7e2e511d3fe6b8053db84f3b98da733f504aa4 --- M pywikibot/tools/__init__.py M ROADMAP.rst M pywikibot/__metadata__.py M HISTORY.rst 4 files changed, 25 insertions(+), 5 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/HISTORY.rst b/HISTORY.rst index b65bc8a..695fbdf 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -1,6 +1,15 @@ Release history =============== +8.1.2 +----- +*23 April 2023* + +* Add support for guwwikinews (:phab:`T334461`) +* Add support for kbdwiktionary (:phab:`T333271`) +* Fix :func:`tools.chars.url2string` parsing for multiple encodings (:phab:`T335224`) + + 8.1.1 ----- *21 April 2023* diff --git a/ROADMAP.rst b/ROADMAP.rst index 170c6d3..1adb1ab 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,9 +1,7 @@ Current release --------------- -* Add support for guwwikinews (:phab:`T334461`) -* Add support for kbdwiktionary (:phab:`T333271`) -* Fix :func:`tools.chars.url2string` parsing for multiple encodings (:phab:`T335224`) +* *(no changes yet)* Deprecations diff --git a/pywikibot/__metadata__.py b/pywikibot/__metadata__.py index 350ffc0..e186959 100644 --- a/pywikibot/__metadata__.py +++ b/pywikibot/__metadata__.py @@ -11,7 +11,7 @@ __name__ = 'pywikibot' -__version__ = '8.2.0.dev1' +__version__ = '8.2.0.dev2' __description__ = 'Python MediaWiki Bot Framework' __maintainer__ = 'The Pywikibot team' __maintainer_email__ = 'pywikibot(a)lists.wikimedia.org' diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py index 717a6bd..25f2395 100644 --- a/pywikibot/tools/__init__.py +++ b/pywikibot/tools/__init__.py @@ -240,7 +240,7 @@ This ensures that ``_cmpkey`` method is defined in subclass. - .. versionadded:: 8.2 + .. versionadded:: 8.1.2 """ def __lt__(self, other): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910854 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I2a7e2e511d3fe6b8053db84f3b98da733f504aa4 Gerrit-Change-Number: 910854 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year

[Gerrit] ...core[stable]: [8.1.2] Publish Pywikibot 8.1.2

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910852 ) Change subject: [8.1.2] Publish Pywikibot 8.1.2 ...................................................................... [8.1.2] Publish Pywikibot 8.1.2 Merge branch 'master' into stable Change-Id: I931acc9f4ee1e1c7f4467e4787a47ed036c84cd1 --- M pywikibot/tools/__init__.py M pywikibot/__metadata__.py M scripts/__init__.py 4 files changed, 31 insertions(+), 7 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/__metadata__.py b/pywikibot/__metadata__.py index 39e02b3..ec3c535 100644 --- a/pywikibot/__metadata__.py +++ b/pywikibot/__metadata__.py @@ -11,11 +11,7 @@ __name__ = 'pywikibot' -<<<<<<< HEAD (7da1f9 Merge branch 'master' into stable) -__version__ = '8.1.1' -======= -__version__ = '8.2.0.dev1' ->>>>>>> BRANCH (1bc8b5 [doc] update ROADMAP.rst) +__version__ = '8.1.2' __description__ = 'Python MediaWiki Bot Framework' __maintainer__ = 'The Pywikibot team' __maintainer_email__ = 'pywikibot(a)lists.wikimedia.org' diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py index 717a6bd..25f2395 100644 --- a/pywikibot/tools/__init__.py +++ b/pywikibot/tools/__init__.py @@ -240,7 +240,7 @@ This ensures that ``_cmpkey`` method is defined in subclass. - .. versionadded:: 8.2 + .. versionadded:: 8.1.2 """ def __lt__(self, other): diff --git a/scripts/__init__.py b/scripts/__init__.py index 643e159..4be7d80 100644 --- a/scripts/__init__.py +++ b/scripts/__init__.py @@ -29,4 +29,4 @@ # # Distributed under the terms of the MIT license. # -__version__ = '8.2.0' +__version__ = '8.1.0' -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910852 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: stable Gerrit-Change-Id: I931acc9f4ee1e1c7f4467e4787a47ed036c84cd1 Gerrit-Change-Number: 910852 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year

[Gerrit] ...core[master]: [doc] update ROADMAP.rst

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910851 ) Change subject: [doc] update ROADMAP.rst ...................................................................... [doc] update ROADMAP.rst Change-Id: Ic8e7d415249ca2b2e3bff1321223ed57ec1ccddd --- M ROADMAP.rst 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/ROADMAP.rst b/ROADMAP.rst index 6a9c831..170c6d3 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,8 +1,9 @@ Current release --------------- +* Add support for guwwikinews (:phab:`T334461`) * Add support for kbdwiktionary (:phab:`T333271`) -* Add support for guwwikinews (:phab:`T334459`) +* Fix :func:`tools.chars.url2string` parsing for multiple encodings (:phab:`T335224`) Deprecations -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910851 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ic8e7d415249ca2b2e3bff1321223ed57ec1ccddd Gerrit-Change-Number: 910851 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year

[Gerrit] ...core[master]: Update languages_by_site

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910850 ) Change subject: Update languages_by_site ...................................................................... Update languages_by_site Change-Id: I54dd4ed45bb431f60dd6d3fc2c1f306e74893600 --- M pywikibot/families/wikipedia_family.py 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/families/wikipedia_family.py b/pywikibot/families/wikipedia_family.py index baaab0b..cc89e60 100644 --- a/pywikibot/families/wikipedia_family.py +++ b/pywikibot/families/wikipedia_family.py @@ -39,16 +39,16 @@ 'vo', 'yo', 'ne', 'ia', 'gu', 'kn', 'als', 'avk', 'bar', 'scn', 'bpy', 'ha', 'crh', 'qu', 'nv', 'mn', 'xmf', 'si', 'ban', 'ps', 'frr', 'bat-smg', 'os', 'or', 'sah', 'cdo', 'gd', 'bug', 'yi', 'sd', 'ilo', - 'am', 'nap', 'mzn', 'li', 'ig', 'gor', 'fo', 'hsb', 'map-bms', 'mai', + 'am', 'nap', 'mzn', 'ig', 'li', 'gor', 'fo', 'hsb', 'map-bms', 'mai', 'bcl', 'eml', 'shn', 'ace', 'zh-classical', 'sa', 'wa', 'as', 'ie', 'lij', 'zu', 'mhr', 'hyw', 'hif', 'sn', 'mrj', 'tum', 'bjn', 'mni', 'km', 'hak', 'roa-tara', 'so', 'pam', 'rue', 'nso', 'bh', 'sat', 'se', 'myv', 'mi', 'vls', 'nds-nl', 'nah', 'sc', 'kw', 'glk', 'vep', 'kab', - 'tk', 'ary', 'gan', 'dag', 'co', 'fiu-vro', 'bo', 'ab', 'rw', 'gv', + 'tk', 'dag', 'ary', 'gan', 'co', 'fiu-vro', 'bo', 'ab', 'rw', 'gv', 'skr', 'ug', 'zea', 'frp', 'udm', 'pcd', 'kv', 'csb', 'mt', 'gn', 'smn', 'ay', 'nrm', 'lez', 'lfn', 'olo', 'stq', 'mwl', 'lo', 'ang', 'fur', 'rm', 'lad', 'gom', 'koi', 'ext', 'tyv', 'dsb', 'av', 'ln', - 'dty', 'kaa', 'pap', 'cbk-zam', 'dv', 'mdf', 'ksh', 'tw', 'ks', 'gag', + 'dty', 'kaa', 'pap', 'cbk-zam', 'mdf', 'dv', 'ksh', 'tw', 'ks', 'gag', 'bxr', 'pfl', 'lg', 'za', 'pi', 'pag', 'szy', 'haw', 'awa', 'tay', 'blk', 'inh', 'krc', 'xal', 'pdc', 'to', 'atj', 'arc', 'tcy', 'mnw', 'jam', 'kbp', 'na', 'wo', 'kbd', 'nia', 'nov', 'shi', 'anp', 'ki', @@ -56,7 +56,7 @@ 'lbe', 'ty', 'guw', 'cu', 'trv', 'srn', 'sm', 'alt', 'gcr', 'chr', 'ltg', 'tn', 'ny', 'mad', 'st', 'pih', 'got', 'ee', 'rmy', 'ami', 'bm', 'ff', 've', 'ts', 'chy', 'ss', 'kcg', 'rn', 'pcm', 'ch', 'ik', 'pnt', - 'ady', 'guc', 'iu', 'ak', 'pwn', 'sg', 'din', 'ti', 'kl', 'dz', 'gur', + 'guc', 'ady', 'iu', 'ak', 'pwn', 'sg', 'din', 'ti', 'kl', 'dz', 'gur', 'fat', 'cr', ] -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910850 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I54dd4ed45bb431f60dd6d3fc2c1f306e74893600 Gerrit-Change-Number: 910850 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year

[Gerrit] ...core[master]: Add support for guwwikinews

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910721 ) Change subject: Add support for guwwikinews ...................................................................... Add support for guwwikinews Bug: T334459 Change-Id: I2aa26a3aae28ed83fcc24e78373cea8e200f1b46 --- M ROADMAP.rst M pywikibot/families/wikinews_family.py 2 files changed, 13 insertions(+), 2 deletions(-) Approvals: Meno25: Looks good to me, approved jenkins-bot: Verified diff --git a/ROADMAP.rst b/ROADMAP.rst index 4ecf11b..6a9c831 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -2,6 +2,7 @@ --------------- * Add support for kbdwiktionary (:phab:`T333271`) +* Add support for guwwikinews (:phab:`T334459`) Deprecations diff --git a/pywikibot/families/wikinews_family.py b/pywikibot/families/wikinews_family.py index f3c807e..d696da2 100644 --- a/pywikibot/families/wikinews_family.py +++ b/pywikibot/families/wikinews_family.py @@ -1,6 +1,6 @@ """Family module for Wikinews.""" # -# (C) Pywikibot team, 2005-2022 +# (C) Pywikibot team, 2005-2023 # # Distributed under the terms of the MIT license. # @@ -22,7 +22,7 @@ languages_by_size = [ 'ru', 'sr', 'pt', 'fr', 'en', 'pl', 'zh', 'de', 'es', 'it', 'ar', 'cs', 'ca', 'nl', 'el', 'ta', 'li', 'sv', 'uk', 'fa', 'fi', 'ro', 'ja', 'eo', - 'sq', 'no', 'ko', 'bs', 'he', + 'sq', 'no', 'ko', 'bs', 'he', 'guw', ] category_redirect_templates = { -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910721 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I2aa26a3aae28ed83fcc24e78373cea8e200f1b46 Gerrit-Change-Number: 910721 Gerrit-PatchSet: 2 Gerrit-Owner: Meno25 <meno25mail(a)gmail.com> Gerrit-Reviewer: Meno25 <meno25mail(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-CC: Xqt <info(a)gno.de> Gerrit-CC: Zabe <zabe(a)avorwerk.net> Gerrit-MessageType: merged

1 year

[Gerrit] ...core[master]: fix example docstring of url2string

by Xqt (Code Review)

Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910722 ) Change subject: fix example docstring of url2string ...................................................................... fix example docstring of url2string Change-Id: I142968e987eb9e5706e2bfa00dedad63eb380eb0 Signed-off-by: Xqt <info(a)gno.de> --- M pywikibot/tools/chars.py 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/pywikibot/tools/chars.py b/pywikibot/tools/chars.py index f4d7a95..c086f4d 100644 --- a/pywikibot/tools/chars.py +++ b/pywikibot/tools/chars.py @@ -101,6 +101,7 @@ Uses the first encoding that doesn't cause an error. **Example:** + >>> url2string('/El%20Ni%C3%B1o/') '/El Niño/' >>> url2string('/El%20Ni%C3%B1o/', 'ascii') -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910722 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I142968e987eb9e5706e2bfa00dedad63eb380eb0 Gerrit-Change-Number: 910722 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-CC: jenkins-bot Gerrit-MessageType: merged

1 year

[Gerrit] ...core[master]: Add support for kbdwiktionary

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910720 ) Change subject: Add support for kbdwiktionary ...................................................................... Add support for kbdwiktionary Bug: T333271 Change-Id: Ic37583ccdfd5302c0ab7f82448cea2d757994661 --- M ROADMAP.rst M pywikibot/families/wiktionary_family.py M pywikibot/families/wikipedia_family.py 3 files changed, 14 insertions(+), 4 deletions(-) Approvals: Meno25: Looks good to me, approved jenkins-bot: Verified diff --git a/ROADMAP.rst b/ROADMAP.rst index 1adb1ab..4ecf11b 100644 --- a/ROADMAP.rst +++ b/ROADMAP.rst @@ -1,7 +1,7 @@ Current release --------------- -* *(no changes yet)* +* Add support for kbdwiktionary (:phab:`T333271`) Deprecations diff --git a/pywikibot/families/wikipedia_family.py b/pywikibot/families/wikipedia_family.py index 217ff21..baaab0b 100644 --- a/pywikibot/families/wikipedia_family.py +++ b/pywikibot/families/wikipedia_family.py @@ -51,8 +51,8 @@ 'dty', 'kaa', 'pap', 'cbk-zam', 'dv', 'mdf', 'ksh', 'tw', 'ks', 'gag', 'bxr', 'pfl', 'lg', 'za', 'pi', 'pag', 'szy', 'haw', 'awa', 'tay', 'blk', 'inh', 'krc', 'xal', 'pdc', 'to', 'atj', 'arc', 'tcy', 'mnw', - 'jam', 'kbp', 'na', 'wo', 'kbd', 'nia', 'nov', 'shi', 'ki', 'nqo', - 'anp', 'bi', 'tpi', 'tet', 'jbo', 'roa-rup', 'xh', 'fj', 'om', 'kg', + 'jam', 'kbp', 'na', 'wo', 'kbd', 'nia', 'nov', 'shi', 'anp', 'ki', + 'nqo', 'bi', 'tpi', 'tet', 'jbo', 'roa-rup', 'xh', 'fj', 'om', 'kg', 'lbe', 'ty', 'guw', 'cu', 'trv', 'srn', 'sm', 'alt', 'gcr', 'chr', 'ltg', 'tn', 'ny', 'mad', 'st', 'pih', 'got', 'ee', 'rmy', 'ami', 'bm', 'ff', 've', 'ts', 'chy', 'ss', 'kcg', 'rn', 'pcm', 'ch', 'ik', 'pnt', diff --git a/pywikibot/families/wiktionary_family.py b/pywikibot/families/wiktionary_family.py index bb41477..2d139d1 100644 --- a/pywikibot/families/wiktionary_family.py +++ b/pywikibot/families/wiktionary_family.py @@ -47,7 +47,7 @@ 'ha', 'mi', 'csb', 'ug', 'si', 'guw', 'st', 'hif', 'roa-rup', 'jbo', 'kl', 'zu', 'ay', 'yi', 'ln', 'gu', 'na', 'gv', 'kw', 'tpi', 'kcg', 'am', 'ne', 'rw', 'ts', 'ig', 'qu', 'ss', 'iu', 'chr', 'dv', 'ti', - 'tn', + 'tn', 'kbd', ] category_redirect_templates = { -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910720 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ic37583ccdfd5302c0ab7f82448cea2d757994661 Gerrit-Change-Number: 910720 Gerrit-PatchSet: 3 Gerrit-Owner: Meno25 <meno25mail(a)gmail.com> Gerrit-Reviewer: Meno25 <meno25mail(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-CC: Xqt <info(a)gno.de> Gerrit-CC: Zabe <zabe(a)avorwerk.net> Gerrit-MessageType: merged

1 year

[Gerrit] ...core[master]: [IMPR] No longer catch SyntaxError in wrapper.py script

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909805 ) Change subject: [IMPR] No longer catch SyntaxError in wrapper.py script ...................................................................... [IMPR] No longer catch SyntaxError in wrapper.py script The syntax check was introduced in release 7.7 after Python version check was dropped in setup.py. With release 8.0 the pwb.py caller script checks the Python version. Change-Id: I1f2f32aade3c79a1c018e4175c15ac909da9160c --- M pywikibot/scripts/wrapper.py 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/scripts/wrapper.py b/pywikibot/scripts/wrapper.py index abb5d5c..d253be4 100755 --- a/pywikibot/scripts/wrapper.py +++ b/pywikibot/scripts/wrapper.py @@ -316,8 +316,6 @@ sys.exit(1) except ImportError as e: # raised in textlib sys.exit(e) -except SyntaxError as e: # pragma: no cover - sys.exit(str(e) + '\nProbably outdated Python version') def find_alternates(filename, script_paths): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/909805 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I1f2f32aade3c79a1c018e4175c15ac909da9160c Gerrit-Change-Number: 909805 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year

[Gerrit] ...core[master]: [IMPR] Ensure that _cmpkey method is defined in subclasses of Compara...

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910813 ) Change subject: [IMPR] Ensure that _cmpkey method is defined in subclasses of ComparableMixin ...................................................................... [IMPR] Ensure that _cmpkey method is defined in subclasses of ComparableMixin Change-Id: I91921c8f4548de62b834e223865f23a05ce63117 --- M pywikibot/tools/__init__.py 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py index 1c06290..023b922 100644 --- a/pywikibot/tools/__init__.py +++ b/pywikibot/tools/__init__.py @@ -1,9 +1,10 @@ """Miscellaneous helper functions (not wiki-dependent).""" # -# (C) Pywikibot team, 2008-2022 +# (C) Pywikibot team, 2008-2023 # # Distributed under the terms of the MIT license. # +import abc import bz2 import gzip import hashlib @@ -226,13 +227,22 @@ # From http://python3porting.com/preparing.html -class ComparableMixin: +class ComparableMixin(abc.ABC): """Mixin class to allow comparing to other objects which are comparable. .. versionadded:: 3.0 """ + @abc.abstractmethod + def _cmpkey(self) -> Any: + """Abstract method to return key for comparison of objects. + + This ensures that ``_cmpkey`` method is defined in subclass. + + .. versionadded:: 8.2 + """ + def __lt__(self, other): """Compare if self is less than other.""" return other > self._cmpkey() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/910813 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I91921c8f4548de62b834e223865f23a05ce63117 Gerrit-Change-Number: 910813 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year

← Newer
1
2
3
4
5
6
7
...
13
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits April 2023