jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/560522 )
Change subject: [bugfix] fmt parameter of listpages.Formatter.output must be a string
......................................................................
[bugfix] fmt parameter of listpages.Formatter.output must be a string
The default fmt parameter of listpages.Formatter.output method
is a format string and must be a string type.
detached from Ie7dcdd45b
Change-Id: I15ec228d29d7bc264191ef78b58f692368d10d83
---
M scripts/listpages.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
D3r1ck01: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/listpages.py b/scripts/listpages.py
index f13a861..cf20cd6 100755
--- a/scripts/listpages.py
+++ b/scripts/listpages.py
@@ -153,7 +153,7 @@
except pywikibot.Error:
self.trs_title = '{0}:{1}'.format(default, page._link.title)
- def output(self, num=None, fmt=1):
+ def output(self, num=None, fmt='1'):
"""Output formatted string."""
fmt = self.fmt_options.get(fmt, fmt)
# If selected format requires trs_title, outputlang must be set.
--
To view, visit https://gerrit.wikimedia.org/r/560522
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15ec228d29d7bc264191ef78b58f692368d10d83
Gerrit-Change-Number: 560522
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/560368 )
Change subject: [IMPR] Add main function into generate_family_file.py
......................................................................
[IMPR] Add main function into generate_family_file.py
Add main function into generate_family_file.py which can be
imported later by a corresponding entrypoint script.
detached from I337beab3732d6a4e9567f56af885a27daa004a0d
Change-Id: I124c21490279f55f1ea700261ef2160cad7aa5f3
---
M generate_family_file.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/generate_family_file.py b/generate_family_file.py
index c529be6..5555ec8 100755
--- a/generate_family_file.py
+++ b/generate_family_file.py
@@ -215,7 +215,8 @@
return result
-if __name__ == '__main__':
+def main():
+ """Process command line arguments and generate a family file."""
if len(sys.argv) != 3:
print("""
Usage: {module} <url> <short name>
@@ -225,3 +226,7 @@
sep=os.sep))
FamilyFileGenerator(*sys.argv[1:]).run()
+
+
+if __name__ == '__main__':
+ main()
--
To view, visit https://gerrit.wikimedia.org/r/560368
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I124c21490279f55f1ea700261ef2160cad7aa5f3
Gerrit-Change-Number: 560368
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: jenkins-bot (75)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/560369 )
Change subject: [IMPR] add the since parameter for deprecated API.version()
......................................................................
[IMPR] add the since parameter for deprecated API.version()
add the since parameter for deprecated API.version()
for the auto-generated family file
detached from I1817868c952685949709f18ee845fc00727c0ca5
Change-Id: If5f4f25be0c80ef9408812a3513c39b8030ac9ef
---
M generate_family_file.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/generate_family_file.py b/generate_family_file.py
index 97eac88..4e2d3b0 100755
--- a/generate_family_file.py
+++ b/generate_family_file.py
@@ -190,7 +190,7 @@
%(code_path_pairs)s
}[code]
- @deprecated('APISite.version()')
+ @deprecated('APISite.version()', since='20141225')
def version(self, code):
return {
%(code_version_pairs)s
--
To view, visit https://gerrit.wikimedia.org/r/560369
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If5f4f25be0c80ef9408812a3513c39b8030ac9ef
Gerrit-Change-Number: 560369
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: jenkins-bot (75)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/559532 )
Change subject: Better error message handling, the error is not removed but kept
......................................................................
Better error message handling, the error is not removed but kept
In the old implementation the error object is modified,
and so the error message is lost afterwords.
In the new implementation the message is just read
and the error object is left unchanged.
Bug: T235500
Change-Id: I6aba2fc74894b170ca5375910c208b09c03087ba
---
M pywikibot/data/api.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py
index 4ae1892..5b0bb63 100644
--- a/pywikibot/data/api.py
+++ b/pywikibot/data/api.py
@@ -1612,7 +1612,7 @@
'edit-already-exists',
'actionthrottledtext', # T192912
)
- messages = error.pop('messages', None)
+ messages = error.get('messages')
message = None
# bug T68619; after Wikibase breaking change 1ca9cee change we have a
# list of messages
--
To view, visit https://gerrit.wikimedia.org/r/559532
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6aba2fc74894b170ca5375910c208b09c03087ba
Gerrit-Change-Number: 559532
Gerrit-PatchSet: 6
Gerrit-Owner: D063520 <dennis.diefenbach(a)googlemail.com>
Gerrit-Reviewer: D063520 <dennis.diefenbach(a)googlemail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot (75)
Gerrit-CC: Dvorapa <dvorapa(a)seznam.cz>
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/559435 )
Change subject: [bugfix, test] Comment not working AppVeyor test
......................................................................
[bugfix, test] Comment not working AppVeyor test
Bug: T241124
Change-Id: Icf223ae161210850f728cc0a65798be779447a51
---
M .appveyor.yml
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.appveyor.yml b/.appveyor.yml
index 063b69f..b6b7be1 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -15,15 +15,16 @@
matrix:
- # Test the lowest supported release of each major Python version.
+ # Test the lowest supported release of each major Python version
- PYTHON: "C:\\Python274-x64"
PYTHON_VERSION: "2.7.4"
PYTHON_ARCH: "64"
- - PYTHON: "C:\\Python351-x64"
- PYTHON_VERSION: "3.5.1"
- PYTHON_ARCH: "64"
+ # Python 3.5 is only available in its last release, not any earlier, see T241124
+ #- PYTHON: "C:\\Python350-x64"
+ # PYTHON_VERSION: "3.5.0"
+ # PYTHON_ARCH: "64"
# Appveyor pre-installs these versions onto build machines
--
To view, visit https://gerrit.wikimedia.org/r/559435
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf223ae161210850f728cc0a65798be779447a51
Gerrit-Change-Number: 559435
Gerrit-PatchSet: 4
Gerrit-Owner: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot (75)