Pywikibot-commits March 2017

pywikibot-commits@lists.wikimedia.org

2 participants
115 discussions

[Gerrit] pywikibot/core[master]: test_CategoryFilterPageGenerator: Increase the expected leng...

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/341187 ) Change subject: test_CategoryFilterPageGenerator: Increase the expected length by two ...................................................................... test_CategoryFilterPageGenerator: Increase the expected length by two Two new pages have recently been added to the category. Bug: T159628 Change-Id: I7c9f1f117aa8813e643f5af9c3847e9badb9d77b --- M tests/pagegenerators_tests.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index 133caf8..1c1aa63 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -241,7 +241,7 @@ site = self.site gen = pagegenerators.PagesFromTitlesGenerator(self.titles, site) gen = pagegenerators.CategoryFilterPageGenerator(gen, self.catfilter_list, site) - self.assertEqual(len(tuple(gen)), 7) + self.assertEqual(len(tuple(gen)), 9) class TestQualityFilterPageGenerator(TestCase): -- To view, visit https://gerrit.wikimedia.org/r/341187 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c9f1f117aa8813e643f5af9c3847e9badb9d77b Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

7 years, 1 month

Errored: wikimedia/pywikibot-core#3882 (master - 785fee8)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3882 Status: Errored Duration: 1 hour, 52 minutes, and 4 seconds Commit: 785fee8 (master) Author: jenkins-bot Message: Merge "file_tests.testLocalOnly: Use a different file for testing" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/501ca29b1d50...785fee8b… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/207761263 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 1 month

Errored: wikimedia/pywikibot-core#3881 (master - 501ca29)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3881 Status: Errored Duration: 1 hour, 57 minutes, and 48 seconds Commit: 501ca29 (master) Author: jenkins-bot Message: Merge "load_pages_from_pageids: do not fail on empty string" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/091332985ff6...501ca29b… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/207757508 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 1 month

Errored: wikimedia/pywikibot-core#3880 (master - 0913329)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3880 Status: Errored Duration: 2 hours, 0 minutes, and 15 seconds Commit: 0913329 (master) Author: jenkins-bot Message: Merge "Save pageid from wbgetentities" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/9b1ff427b288...09133298… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/207756665 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 1 month

[Gerrit] pywikibot/core[master]: file_tests.testLocalOnly: Use a different file for testing

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/340293 ) Change subject: file_tests.testLocalOnly: Use a different file for testing ...................................................................... file_tests.testLocalOnly: Use a different file for testing Bug: T159212 Change-Id: I175ddc21053189dc29a93fc665b72927c16f891f --- M tests/file_tests.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/file_tests.py b/tests/file_tests.py index 6ab6b59..9ee5a4b 100644 --- a/tests/file_tests.py +++ b/tests/file_tests.py @@ -69,7 +69,8 @@ def testLocalOnly(self): """Test fileIsShared() on file page with local file only.""" - title = 'File:April Fools Day Adminship discussion (2005).png' + title = 'File:Untitled (Three Forms), stainless steel sculpture by ' \ + '--James Rosati--, 1975-1976, --Honolulu Academy of Arts--.JPG' commons = self.get_site('commons') enwp = self.get_site('enwiki') -- To view, visit https://gerrit.wikimedia.org/r/340293 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I175ddc21053189dc29a93fc665b72927c16f891f Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Lokal Profil <lokal.profil(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

7 years, 1 month

[Gerrit] pywikibot/core[master]: load_pages_from_pageids: do not fail on empty string

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/337348 ) Change subject: load_pages_from_pageids: do not fail on empty string ...................................................................... load_pages_from_pageids: do not fail on empty string Treat empty string as a pipe-separated string of pageids of length zero. Assign 0 as the default value for the count variable in the related tests. Bug: T153592 Change-Id: Ic126c18ba7a3a42892f7fef91fbd6e19ad030f58 --- M pywikibot/site.py M tests/site_tests.py 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/site.py b/pywikibot/site.py index 2491a54..895c1c9 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -3132,6 +3132,8 @@ or a comma- or pipe-separated string of pageids (e.g. '945097,1483753, 956608' or '945097|483753|956608') """ + if not pageids: + return if isinstance(pageids, basestring): pageids = pageids.replace('|', ',') pageids = pageids.split(',') diff --git a/tests/site_tests.py b/tests/site_tests.py index 5b43ccf..b1c35d2 100644 --- a/tests/site_tests.py +++ b/tests/site_tests.py @@ -2499,6 +2499,7 @@ """Test basic loading with pageids.""" pageids = [str(page.pageid) for page in self.links] gen = self.site.load_pages_from_pageids(pageids) + count = 0 for count, page in enumerate(gen, start=1): self.assertIsInstance(page, pywikibot.Page) self.assertIsInstance(page.exists(), bool) @@ -2511,6 +2512,7 @@ """Test basic loading with pageids.""" pageids = [page.pageid for page in self.links] gen = self.site.load_pages_from_pageids(pageids) + count = 0 for count, page in enumerate(gen, start=1): self.assertIsInstance(page, pywikibot.Page) self.assertIsInstance(page.exists(), bool) @@ -2536,6 +2538,7 @@ pageids = [page.pageid for page in self.links] pageids = pageids + pageids gen = self.site.load_pages_from_pageids(pageids) + count = 0 for count, page in enumerate(gen, start=1): self.assertIsInstance(page, pywikibot.Page) self.assertIsInstance(page.exists(), bool) @@ -2548,6 +2551,7 @@ """Test loading from comma-separated pageids.""" pageids = ', '.join(str(page.pageid) for page in self.links) gen = self.site.load_pages_from_pageids(pageids) + count = 0 for count, page in enumerate(gen, start=1): self.assertIsInstance(page, pywikibot.Page) self.assertIsInstance(page.exists(), bool) @@ -2560,6 +2564,7 @@ """Test loading from comma-separated pageids.""" pageids = '|'.join(str(page.pageid) for page in self.links) gen = self.site.load_pages_from_pageids(pageids) + count = 0 for count, page in enumerate(gen, start=1): self.assertIsInstance(page, pywikibot.Page) self.assertIsInstance(page.exists(), bool) -- To view, visit https://gerrit.wikimedia.org/r/337348 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic126c18ba7a3a42892f7fef91fbd6e19ad030f58 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Lokal Profil <lokal.profil(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

7 years, 1 month

[Gerrit] pywikibot/core[master]: Save pageid from wbgetentities

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/338765 ) Change subject: Save pageid from wbgetentities ...................................................................... Save pageid from wbgetentities wbgetentities provides it, why not to reuse it? Change-Id: I9f7d1fe4a8dbc497ea8edd9edb5dd0d0d7fa81d5 --- M pywikibot/page.py M tests/pages/Q60.wd M tests/wikibase_tests.py 3 files changed, 4 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/page.py b/pywikibot/page.py index a268b1e..8a6090c 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -3581,6 +3581,8 @@ raise pywikibot.NoPage(p) raise pywikibot.NoPage(self) + self._pageid = self._content['pageid'] + # aliases self.aliases = {} if 'aliases' in self._content: diff --git a/tests/pages/Q60.wd b/tests/pages/Q60.wd index 0792366..b242c7d 100644 --- a/tests/pages/Q60.wd +++ b/tests/pages/Q60.wd @@ -2,6 +2,7 @@ "id": "Q60", "type": "item", "lastrevid": 122836617, + "pageid": 186, "aliases": { "en": [ { diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index b00817b..87a00c8 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -1256,6 +1256,7 @@ del self.wdp._content['id'] del self.wdp._content['type'] del self.wdp._content['lastrevid'] + del self.wdp._content['pageid'] def test_itempage_json(self): """Test itempage json.""" -- To view, visit https://gerrit.wikimedia.org/r/338765 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f7d1fe4a8dbc497ea8edd9edb5dd0d0d7fa81d5 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

7 years, 1 month

Errored: wikimedia/pywikibot-core#3879 (master - 9b1ff42)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3879 Status: Errored Duration: 1 hour, 44 minutes, and 54 seconds Commit: 9b1ff42 (master) Author: marc Message: Add surnames_redirects script Creates redirects based on name order. For example Einstein, Albert to Albert Einstein or vice versa. Bug: T57010 Change-Id: If23b11e5e1a93bc5c1d1fc60dd5038d27eb27e84 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/51bc9671d1d2...9b1ff427… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/207660812 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 1 month

[Gerrit] pywikibot/core[master]: Add surnames_redirects script

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/340063 ) Change subject: Add surnames_redirects script ...................................................................... Add surnames_redirects script Creates redirects based on name order. For example Einstein, Albert to Albert Einstein or vice versa. Bug: T57010 Change-Id: If23b11e5e1a93bc5c1d1fc60dd5038d27eb27e84 --- A scripts/surnames_redirects.py 1 file changed, 131 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/surnames_redirects.py b/scripts/surnames_redirects.py new file mode 100755 index 0000000..2c17940 --- /dev/null +++ b/scripts/surnames_redirects.py @@ -0,0 +1,131 @@ +#!/usr/bin/python +# -*- coding: utf-8 -*- +""" +Bot to create redirects based on name order. + +By default it creates a "Surnames, Given Names" redirect +version of a given page where title consists of 2 or 3 titlecased words. + +Command-line arguments: + +&params; + +-surnames_last Creates a "Given Names Surnames" redirect version of a + given page where title is "Surnames, Given Names". + +Example: "python pwb.py surnames_redirects -start:B" +""" +# +# (C) Pywikibot team, 2017 +# +# Distributed under the terms of the MIT license. +# +from __future__ import absolute_import, unicode_literals + +from difflib import SequenceMatcher + +import pywikibot +from pywikibot import i18n, pagegenerators +from pywikibot.bot import FollowRedirectPageBot, ExistingPageBot + + +class SurnamesBot(ExistingPageBot, FollowRedirectPageBot): + + """Surnames Bot.""" + + def __init__(self, generator, **kwargs): + """Constructor. + + Parameters: + @param generator: The page generator that determines on + which pages to work. + @kwarg surnames-last: Redirect "Surnames, Given Names" to + "Given Names Surnames". + """ + self.availableOptions.update({ + 'surnames_last': False, + }) + + super(SurnamesBot, self).__init__(generator=generator, **kwargs) + + def treat_page(self): + """Suggest redirects by reordering names in titles.""" + if self.current_page.isRedirectPage(): + return + + page_t = self.current_page.title() + split_title = page_t.split(' (') + name = split_title[0] + site = self.current_page.site + + possible_names = [] + if self.getOption('surnames_last'): + name_parts = name.split(', ') + if len(name_parts) == 2 and len(name.split(' ')) <= 3: + possible_names.append(name_parts[1] + ' ' + name_parts[0]) + else: + words = name.split() + if len(words) == 2 and name == name.title(): + possible_names.append(words[1] + ', ' + words[0]) + elif len(words) == 3: + # title may have at most one non-titlecased word + if len(SequenceMatcher(None, name, + name.title()).get_matching_blocks()) <= 3: + possible_names.append(words[1] + ' ' + + words[2] + ', ' + + words[0]) + possible_names.append(words[2] + ', ' + + words[0] + ' ' + + words[1]) + + for possible_name in possible_names: + # append disambiguation inside parenthesis if there is one + if len(split_title) == 2: + possible_name += ' (' + split_title[1] + + new_page = pywikibot.Page(site, possible_name) + if new_page.exists(): + pywikibot.output('%s already exists, skipping...' + % new_page.title(asLink=True)) + else: + pywikibot.output('%s doesn\'t exist' + % new_page.title(asLink=True)) + choice = pywikibot.input_yn('Do you want to create a redirect?') + if choice: + comment = i18n.twtranslate( + site, + 'capitalize_redirects-create-redirect', + {'to': page_t}) + new_page.set_redirect_target(self.current_page, create=True, + summary=comment) + + +def main(*args): + """ + Process command line arguments and invoke bot. + + If args is an empty list, sys.argv is used. + + @param args: command line arguments + @type args: list of unicode + """ + options = {} + + local_args = pywikibot.handle_args(args) + genFactory = pagegenerators.GeneratorFactory() + + for arg in local_args: + if arg == '-surnames_last': + options['surnames_last'] = True + else: + genFactory.handleArg(arg) + + gen = genFactory.getCombinedGenerator() + if gen: + bot = SurnamesBot(gen, **options) + bot.run() + else: + pywikibot.bot.suggest_help(missing_generator=True) + +if __name__ == "__main__": + main() -- To view, visit https://gerrit.wikimedia.org/r/340063 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If23b11e5e1a93bc5c1d1fc60dd5038d27eb27e84 Gerrit-PatchSet: 6 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: MarcAbonce <a01200356(a)itesm.mx> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm(a)member.fsf.org> Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com> Gerrit-Reviewer: MarcAbonce <a01200356(a)itesm.mx> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

7 years, 1 month

Errored: wikimedia/pywikibot-core#3878 (master - 51bc967)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3878 Status: Errored Duration: 1 hour, 52 minutes, and 28 seconds Commit: 51bc967 (master) Author: jenkins-bot Message: Merge "__init__.py:Added extra checking for more descriptive error raising" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/1ef1513ccea5...51bc9671… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/207029846 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 1 month

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits March 2017