Pywikibot-commits April 2016

pywikibot-commits@lists.wikimedia.org

2 participants
87 discussions

Errored: wikimedia/pywikibot-core#3422 (nexqt - c5a9241)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3422 Status: Errored Duration: 41 minutes and 5 seconds Commit: c5a9241 (nexqt) Author: xqt Message: [WIP] test connectionError Change-Id: I343de43a35d6b1562072ba837f5a970b3c3e2a76 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/b40f1eb2bf40...c5a92411… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/125535755 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 12 months

Errored: wikimedia/pywikibot-core#3421 (nexqt - b40f1eb)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3421 Status: Errored Duration: 1 hour, 36 minutes, and 34 seconds Commit: b40f1eb (nexqt) Author: xqt Message: [WIP] raise ServerError for request.status 104 Change-Id: Ie327b6598e332a2d4daf13a7e43b0d02c14d611f View the changeset: https://github.com/wikimedia/pywikibot-core/commit/b40f1eb2bf40 View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/125509826 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 12 months

[Gerrit] [WIP] test connectionError - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [WIP] test connectionError ...................................................................... [WIP] test connectionError Change-Id: I343de43a35d6b1562072ba837f5a970b3c3e2a76 --- M pywikibot/site_detect.py M tests/site_detect_tests.py M tox.ini 3 files changed, 6 insertions(+), 99 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site_detect.py b/pywikibot/site_detect.py index 444b80b..a6a3003 100644 --- a/pywikibot/site_detect.py +++ b/pywikibot/site_detect.py @@ -54,8 +54,6 @@ r = fetch(fromurl) if r.status == 503: raise ServerError('Service Unavailable') - if r.status == 104: - raise ServerError('Connection reset by peer') if fromurl != r.data.url: pywikibot.log('{0} redirected to {1}'.format(fromurl, r.data.url)) diff --git a/tests/site_detect_tests.py b/tests/site_detect_tests.py index 51e7904..5829bfe 100644 --- a/tests/site_detect_tests.py +++ b/tests/site_detect_tests.py @@ -11,6 +11,7 @@ from requests.exceptions import Timeout +import pywikibot from pywikibot.exceptions import ServerError from pywikibot.site_detect import MWSite from pywikibot.tools import MediaWikiVersion @@ -86,9 +87,11 @@ try: site = MWSite(url) except (ServerError, Timeout) as e: + pywikibot.exception() self.skips[url] = e return except Exception as e: + pywikibot.exception() print('failure {0} on {1}: {2}'.format( url, type(e), e)) self.errors[url] = e @@ -100,6 +103,7 @@ self.assertIsInstance(site, result) self.passes[url] = site except AssertionError as error: + pywikibot.exception() self.failures[url] = error def assertSite(self, url): @@ -169,102 +173,7 @@ def test_detect_site(self): """Test detection of MediaWiki sites.""" - self.assertSite('http://www.hrwiki.org/index.php/$1') # v 1.15 self.assertSite('http://www.proofwiki.org/wiki/$1') - self.assertSite( - 'http://www.ck-wissen.de/ckwiki/index.php?title=$1') - self.assertSite('http://en.citizendium.org/wiki/$1') - self.assertSite( - 'http://www.lojban.org/tiki/tiki-index.php?page=$1') - self.assertSite('http://www.wikichristian.org/index.php?title=$1') - self.assertSite('https://en.wikifur.com/wiki/$1') - self.assertSite('http://bluwiki.com/go/$1') - self.assertSite('http://kino.skripov.com/index.php/$1') - self.assertAllPass() - - def test_wikisophia(self): - """Test wikisophia.org which has redirect problems.""" - # /index.php?title=$1 reports 404, however a wiki exists there, - # but the API is also hidden. - self.assertNoSite('http://wikisophia.org/index.php?title=$1') - self.assertAllError() - - def test_pre_114_sites(self): - """Test pre 1.14 sites which should be detected as unsupported.""" - # v1.12 - self.assertNoSite('http://www.livepedia.gr/index.php?title=$1') - # v1.11 - self.assertNoSite('http://www.wikifon.org/$1') - self.assertNoSite('http://glossary.reuters.com/index.php?title=$1') - # v1.11, with no query module - self.assertNoSite('http://wikitree.org/index.php?title=$1') - # v1.9 - self.assertNoSite('http://www.wikinvest.com/$1') - self.assertAllError() - - def test_non_standard_version_sites(self): - """Test non-standard version string sites.""" - self.assertSite('https://wiki.gentoo.org/wiki/$1') - self.assertSite('http://wiki.arabeyes.org/$1') - self.assertSite('http://tfwiki.net/wiki/$1') - self.assertAllPass() - - @unittest.expectedFailure # Test no longer valid - def test_detect_failure(self): - """Test detection failure for MediaWiki sites with an API.""" - # SSL certificate verification fails - self.assertNoSite('http://hackerspaces.org/wiki/$1') - self.assertAllError() - - @unittest.expectedFailure - def test_api_hidden(self): - """Test MediaWiki sites with a hidden enabled API.""" - # api.php is not available - self.assertNoSite('http://wiki.animutationportal.com/index.php/$1') - # HTML looks like it has an API, but redirect rules prevent access - self.assertNoSite('http://www.EcoReality.org/wiki/$1') - self.assertAllError() - - def test_api_disabled(self): - """Test MediaWiki sites without an enabled API.""" - self.assertNoSite('http://wiki.linuxquestions.org/wiki/$1') - self.assertAllError() - - def test_offline_sites(self): - """Test offline sites.""" - self.assertNoSite('http://seattlewiki.org/wiki/$1') - self.assertAllError() - - def test_pre_api_sites(self): - """Test detection of MediaWiki sites prior to the API.""" - self.assertNoSite('http://www.wikif1.org/$1') - self.assertNoSite('http://www.thelemapedia.org/index.php/$1') - self.assertNoSite('http://esperanto.blahus.cz/cxej/vikio/index.php/$1') - self.assertNoSite('http://www.werelate.org/wiki/$1') - self.assertNoSite('http://www.otterstedt.de/wiki/index.php/$1') - self.assertNoSite('http://kb.mozillazine.org/$1') - self.assertAllError() - - def test_detect_nosite(self): - """Test detection of non-wiki sites.""" - self.assertNoSite('http://www.imdb.com/name/nm$1/') - self.assertNoSite('http://www.ecyrd.com/JSPWiki/Wiki.jsp?page=$1') - self.assertNoSite('http://operawiki.info/$1') - self.assertNoSite( - 'http://www.tvtropes.org/pmwiki/pmwiki.php/Main/$1') - self.assertNoSite('http://c2.com/cgi/wiki?$1') - self.assertNoSite('https://phabricator.wikimedia.org/$1') - self.assertNoSite( - 'http://www.merriam-webster.com/cgi-bin/dictionary?book=Dictionary&va=$1') - self.assertNoSite('http://arxiv.org/abs/$1') - self.assertAllError() - - def test_musicbrainz_doc(self): - """Test http://musicbrainz.org/doc/ which has a page 'api.php'.""" - # Possible false positive caused by the existance of a page - # called http://musicbrainz.org/doc/api.php - self.assertNoSite('http://musicbrainz.org/doc/$1') - self.assertAllError() if __name__ == '__main__': diff --git a/tox.ini b/tox.ini index 1fad75b..5c42ad3 100644 --- a/tox.ini +++ b/tox.ini @@ -1,12 +1,12 @@ [tox] minversion = 1.6 skipsdist = True -envlist = flake8,flake8-py3,doctest-{py27,py34},py26,py27,py34 +envlist = flake8,doctest-{py27,py34},py27 [tox:jenkins] # Override default for WM Jenkins # Others are run in their own individual jobs on WM Jenkins -envlist = flake8,flake8-py3 +envlist = flake8 [params] doctest_skip = --ignore-files=(gui\.py|botirc\.py|rcstream\.py) -- To view, visit https://gerrit.wikimedia.org/r/285162 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I343de43a35d6b1562072ba837f5a970b3c3e2a76 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: nexqt Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

7 years, 12 months

Errored: wikimedia/pywikibot-core#3420 (master - 0d56409)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3420 Status: Errored Duration: 1 hour, 35 minutes, and 42 seconds Commit: 0d56409 (master) Author: jenkins-bot Message: Merge "Provide more info in case of invalid page" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/09ad9c98f83d...0d564096… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/125509305 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 12 months

Errored: wikimedia/pywikibot-core#3418 (master - 09ad9c9)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3418 Status: Errored Duration: 1 hour, 31 minutes, and 31 seconds Commit: 09ad9c9 (master) Author: jenkins-bot Message: Merge "Print additional information when the script terminates" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/20faf0cf65cd...09ad9c98… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/125501629 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 12 months

Errored: wikimedia/pywikibot-core#3419 (nexqt - ce46a21)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3419 Status: Errored Duration: 7 minutes and 54 seconds Commit: ce46a21 (nexqt) Author: xqt Message: Merge "[WIP] raise ServerError for request.status 104" into nexqt View the changeset: https://github.com/wikimedia/pywikibot-core/compare/19d02885d5a4...ce46a217… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/125508839 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 12 months

[Gerrit] Provide more info in case of invalid page - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Provide more info in case of invalid page ...................................................................... Provide more info in case of invalid page Display the api error message, if possible, which is more informative than current AssertionError. Bug: T132158 Change-Id: If95a6930eac8c021a8799a7988e3d079a304e838 --- M pywikibot/data/api.py 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index c3f1ddf..40999c6 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -34,7 +34,9 @@ from pywikibot.comms import http from pywikibot.exceptions import ( - Server504Error, Server414Error, FatalServerError, NoUsername, Error + Server504Error, Server414Error, FatalServerError, NoUsername, + Error, + InvalidTitle ) from pywikibot.tools import ( MediaWikiVersion, deprecated, itergroup, ip, PY2, getargspec, @@ -3118,6 +3120,10 @@ elif "missing" in pagedict: page._pageid = 0 # Non-existent page else: + # Something is wrong. + if page.site.sametitle(page.title(), pagedict['title']): + if 'invalid' in pagedict: + raise InvalidTitle('%s: %s' % (page, pagedict['invalidreason'])) raise AssertionError( "Page %s has neither 'pageid' nor 'missing' attribute" % pagedict['title']) page._contentmodel = pagedict.get('contentmodel') # can be None -- To view, visit https://gerrit.wikimedia.org/r/285092 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If95a6930eac8c021a8799a7988e3d079a304e838 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

7 years, 12 months

[Gerrit] [WIP] raise ServerError for request.status 104 - change (pywikibot/core)

by Xqt (Code Review)

Xqt has submitted this change and it was merged. Change subject: [WIP] raise ServerError for request.status 104 ...................................................................... [WIP] raise ServerError for request.status 104 Change-Id: Ie327b6598e332a2d4daf13a7e43b0d02c14d611f --- M pywikibot/site_detect.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/pywikibot/site_detect.py b/pywikibot/site_detect.py index a6a3003..444b80b 100644 --- a/pywikibot/site_detect.py +++ b/pywikibot/site_detect.py @@ -54,6 +54,8 @@ r = fetch(fromurl) if r.status == 503: raise ServerError('Service Unavailable') + if r.status == 104: + raise ServerError('Connection reset by peer') if fromurl != r.data.url: pywikibot.log('{0} redirected to {1}'.format(fromurl, r.data.url)) -- To view, visit https://gerrit.wikimedia.org/r/285149 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie327b6598e332a2d4daf13a7e43b0d02c14d611f Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: nexqt Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de>

7 years, 12 months

[Gerrit] Print additional information when the script terminates - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Print additional information when the script terminates ...................................................................... Print additional information when the script terminates Bug: T132294 Change-Id: Ic3d65d07edb3cd58b73a16b355b2483227355fba --- M scripts/nowcommons.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: MarcoAurelio: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/nowcommons.py b/scripts/nowcommons.py index 166b776..62bcd07 100755 --- a/scripts/nowcommons.py +++ b/scripts/nowcommons.py @@ -51,8 +51,8 @@ # # (C) Wikipedian, 2006-2007 # (C) Siebrand Mazeland, 2007-2008 -# (C) xqt, 2010-2014 -# (C) Pywikibot team, 2006-2015 +# (C) xqt, 2010-2016 +# (C) Pywikibot team, 2006-2016 # # Distributed under the terms of the MIT license. # @@ -451,6 +451,12 @@ except (pywikibot.NoPage, pywikibot.IsRedirectPage) as e: pywikibot.output(u'%s' % e[0]) continue + else: + self._treat_counter += 1 + if not self._treat_counter: + pywikibot.output( + 'No transcluded files found for %s.' % self.ncTemplates[0]) + self.exit() def main(*args): -- To view, visit https://gerrit.wikimedia.org/r/282529 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3d65d07edb3cd58b73a16b355b2483227355fba Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: MarcoAurelio <strigiwm(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

7 years, 12 months

Errored: wikimedia/pywikibot-core#3417 (master - 20faf0c)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #3417 Status: Errored Duration: 1 hour, 1 minute, and 33 seconds Commit: 20faf0c (master) Author: xqt Message: [bugfix] Enable test_detect_site for wikichristian.org - SiteDetectionTestCase.test_detect_site() failed for wikichristian.org. I found several newlines on top of the json file and a Byte Order Mark (BOM). Removing them solves the problem. - Also add a __repr__ for MWSite so show this repr string instead of the generic <pywikibot.site_detect.MWSite object at 0x032D06F0>. Now we get the class Name with the new url where the json is fetched from Bug: T128992 Change-Id: Ib8b4c0d5dbf645d4984d26f5ac35f8f98e1ca418 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/75134ba52d9a...20faf0cf… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/125397549 -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

7 years, 12 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits April 2016