Pywikibot-commits September 2015

pywikibot-commits@lists.wikimedia.org

2 participants
243 discussions

[Gerrit] Check Internet Archive API URL is available - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Check Internet Archive API URL is available ...................................................................... Check Internet Archive API URL is available The Internet Archive API responds with status code 503 when it is unavailable. The tests should not be run when it is unavailable. Re-enable Internet Archive tests. Bug: T104761 Change-Id: I4f550efa380db41a4e489c4821b2400c70ada369 --- M tests/__init__.py M tests/weblib_tests.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/__init__.py b/tests/__init__.py index 4416e05..631b7ce 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -141,10 +141,7 @@ disabled_test_modules = [ 'tests', # tests of the tests package - # weblib is deprecated, the tests fail for weblib, - # but the tests are run in weblinkchecker_tests. 'l10n', - 'weblib', ] if not i18n.messages_available(): disabled_test_modules.append('l10n') @@ -156,6 +153,9 @@ 'site_detect': [ 'test_IWM', # very slow and tests include unnecessary sites ], + 'weblib': [ + 'testWebCiteOlder', # fails. T110640 + ], } diff --git a/tests/weblib_tests.py b/tests/weblib_tests.py index 769080c..13c5a13 100644 --- a/tests/weblib_tests.py +++ b/tests/weblib_tests.py @@ -28,7 +28,7 @@ sites = { 'archive.org': { - 'hostname': 'web.archive.org', + 'hostname': 'https://archive.org/wayback/available?url=invalid', }, } -- To view, visit https://gerrit.wikimedia.org/r/229620 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f550efa380db41a4e489c4821b2400c70ada369 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 6 months

[Gerrit] Work around traceback in atexit - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Work around traceback in atexit ...................................................................... Work around traceback in atexit Bug: T74699 Change-Id: I527ba5ba32fd3d517ca654e4beb34156953d5e21 --- M setup.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/setup.py b/setup.py index bbff59b..66495ae 100644 --- a/setup.py +++ b/setup.py @@ -10,6 +10,13 @@ import os import sys +try: + # Work around a traceback on Python < 2.7.4 and < 3.3.1 + # http://bugs.python.org/issue15881#msg170215 + import multiprocessing # noqa: unused +except ImportError: + pass + PYTHON_VERSION = sys.version_info[:3] PY2 = (PYTHON_VERSION[0] == 2) PY26 = (PYTHON_VERSION < (2, 7)) -- To view, visit https://gerrit.wikimedia.org/r/234195 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I527ba5ba32fd3d517ca654e4beb34156953d5e21 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 6 months

[Gerrit] Add extract_templates_and_params strip - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Add extract_templates_and_params strip ...................................................................... Add extract_templates_and_params strip - Allow strip to be disabled - Do not strip implicit parameters Change-Id: Ic77f2115c5727ea8f573ec269886769e1c6b4333 --- M pywikibot/textlib.py M tests/textlib_tests.py 2 files changed, 141 insertions(+), 21 deletions(-) Approvals: XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py index 36c6e81..2b6c529 100644 --- a/pywikibot/textlib.py +++ b/pywikibot/textlib.py @@ -41,6 +41,7 @@ from pywikibot.tools import ( DeprecatedRegex, OrderedDict, + UnicodeType, issue_deprecation_warning ) @@ -1255,7 +1256,7 @@ # Functions dealing with templates # -------------------------------- -def extract_templates_and_params(text, remove_disabled_parts=None): +def extract_templates_and_params(text, remove_disabled_parts=None, strip=None): """Return a list of templates found in text. Return value is a list of tuples. There is one tuple for each use of a @@ -1278,6 +1279,11 @@ mwpfh preserves whitespace in parameter names and values. regex excludes anything between  before parsing the text. + If there are multiple numbered parameters in the wikitext for the same + position, MediaWiki will only use the last parameter value. + e.g. {{a| foo | 2  = bar | baz }} is {{a|1=foo|2=baz}} + To replicate that behaviour, enable both remove_disabled_parts and strip. + @param text: The wikitext from which templates are extracted @type text: unicode or string @param remove_disabled_parts: Remove disabled wikitext such as comments @@ -1285,6 +1291,11 @@ is not available or is disabled in the config, and disabled if mwparserfromhell is present and enabled in the config. @type remove_disabled_parts: bool or None + @param strip: if enabled, strip arguments and values of templates. + If None (default), this is enabled when mwparserfromhell + is not available or is disabled in the config, and disabled if + mwparserfromhell is present and enabled in the config. + @type strip: bool @return: list of template name and params @rtype: list of tuple """ @@ -1294,16 +1305,19 @@ if remove_disabled_parts is None: remove_disabled_parts = not use_mwparserfromhell + if strip is None: + strip = not use_mwparserfromhell + if remove_disabled_parts: text = removeDisabledParts(text) if use_mwparserfromhell: - return extract_templates_and_params_mwpfh(text) + return extract_templates_and_params_mwpfh(text, strip) else: - return extract_templates_and_params_regex(text, False) + return extract_templates_and_params_regex(text, False, strip) -def extract_templates_and_params_mwpfh(text): +def extract_templates_and_params_mwpfh(text, strip=False): """ Extract templates with params using mwparserfromhell. @@ -1321,15 +1335,29 @@ """ code = mwparserfromhell.parse(text) result = [] + for template in code.filter_templates(recursive=True): params = OrderedDict() for param in template.params: - params[unicode(param.name)] = unicode(param.value) + if strip: + implicit_parameter = not param.showkey + key = param.name.strip() + if not implicit_parameter: + value = param.value.strip() + else: + value = UnicodeType(param.value) + else: + key = UnicodeType(param.name) + value = UnicodeType(param.value) + + params[key] = value + result.append((unicode(template.name.strip()), params)) return result -def extract_templates_and_params_regex(text, remove_disabled_parts=True): +def extract_templates_and_params_regex(text, remove_disabled_parts=True, + strip=True): """ Extract templates with params using a regex with additional processing. @@ -1473,10 +1501,12 @@ for param in markedParams: if "=" in param: param_name, param_val = param.split("=", 1) + implicit_parameter = False else: param_name = unicode(numbered_param) param_val = param numbered_param += 1 + implicit_parameter = True count = len(inside) for m2 in Rmarker1.finditer(param_val): param_val = param_val.replace(m2.group(), @@ -1490,7 +1520,11 @@ for m2 in Rmarker4.finditer(param_val): param_val = param_val.replace(m2.group(), values[int(m2.group(1))]) - params[param_name.strip()] = param_val.strip() + if strip: + param_name = param_name.strip() + if not implicit_parameter: + param_val = param_val.strip() + params[param_name] = param_val # Special case for {{a|}} which has an undetected parameter if not params and '|' in m.group(0): diff --git a/tests/textlib_tests.py b/tests/textlib_tests.py index 0b0205e..5e84526 100644 --- a/tests/textlib_tests.py +++ b/tests/textlib_tests.py @@ -324,9 +324,6 @@ [('a', OrderedDict((('b', 'c'), ))), ('d', OrderedDict((('e', 'f'), )))]) - self.assertEqual(func('{{a|b=}}'), - [('a', OrderedDict((('b', ''), )))]) - # initial '{' and '}' should be ignored as outer wikitext self.assertEqual(func('{{{a|b}}X}'), [('a', OrderedDict((('1', 'b'), )))]) @@ -335,13 +332,52 @@ self.assertEqual(func('{{a'), []) self.assertEqual(func('{{a}}{{foo|'), [('a', OrderedDict())]) - def _etp_regex_differs(self, func): - """Common cases not handled the same by ETP_REGEX.""" + def _unstripped(self, func): + """Common cases of unstripped results.""" + self.assertEqual(func('{{a|b=}}'), + [('a', OrderedDict((('b', ''), )))]) + + self.assertEqual(func('{{a| }}'), [('a', OrderedDict((('1', ' '), )))]) + self.assertEqual(func('{{a| | }}'), [('a', OrderedDict((('1', ' '), ('2', ' '))))]) + self.assertEqual(func('{{a| =|}}'), [('a', OrderedDict(((' ', ''), ('1', ''))))]) + self.assertEqual(func('{{a| b=c}}'), [('a', OrderedDict(((' b', 'c'), )))]) self.assertEqual(func('{{a|b =c}}'), [('a', OrderedDict((('b ', 'c'), )))]) self.assertEqual(func('{{a|b= c}}'), [('a', OrderedDict((('b', ' c'), )))]) self.assertEqual(func('{{a|b=c }}'), [('a', OrderedDict((('b', 'c '), )))]) + self.assertEqual(func('{{a| foo |2= bar }}'), + [('a', OrderedDict((('1', ' foo '), ('2', ' bar '))))]) + + # The correct entry 'bar' is removed + self.assertEqual(func('{{a| foo |2= bar | baz }}'), + [('a', OrderedDict((('1', ' foo '), ('2', ' baz '))))]) + # However whitespace prevents the correct item from being removed + self.assertEqual(func('{{a| foo | 2 = bar | baz }}'), + [('a', OrderedDict((('1', ' foo '), (' 2 ', ' bar '), ('2', ' baz '))))]) + + def _stripped(self, func): + """Common cases of stripped results.""" + self.assertEqual(func('{{a| }}'), [('a', OrderedDict((('1', ' '), )))]) + self.assertEqual(func('{{a| | }}'), [('a', OrderedDict((('1', ' '), ('2', ' '))))]) + self.assertEqual(func('{{a| =|}}'), [('a', OrderedDict((('', ''), ('1', ''))))]) + + self.assertEqual(func('{{a| b=c}}'), [('a', OrderedDict((('b', 'c'), )))]) + self.assertEqual(func('{{a|b =c}}'), [('a', OrderedDict((('b', 'c'), )))]) + self.assertEqual(func('{{a|b= c}}'), [('a', OrderedDict((('b', 'c'), )))]) + self.assertEqual(func('{{a|b=c }}'), [('a', OrderedDict((('b', 'c'), )))]) + + self.assertEqual(func('{{a| foo |2= bar }}'), + [('a', OrderedDict((('1', ' foo '), ('2', 'bar'))))]) + + # 'bar' is always removed + self.assertEqual(func('{{a| foo |2= bar | baz }}'), + [('a', OrderedDict((('1', ' foo '), ('2', ' baz '))))]) + self.assertEqual(func('{{a| foo | 2 = bar | baz }}'), + [('a', OrderedDict((('1', ' foo '), ('2', ' baz '))))]) + + def _etp_regex_differs(self, func): + """Common cases not handled the same by ETP_REGEX.""" # inner {} should be treated as part of the value self.assertEqual(func('{{a|b={} }}'), [('a', OrderedDict((('b', '{} '), )))]) @@ -367,6 +403,7 @@ func = textlib.extract_templates_and_params_mwpfh self._common_results(func) self._order_differs(func) + self._unstripped(func) self._etp_regex_differs(func) self.assertCountEqual(func('{{a|{{c|{{d}}}}}}'), @@ -381,21 +418,34 @@ ('d', OrderedDict([('1', '')])) ]) + @require_modules('mwparserfromhell') + def test_extract_templates_params_mwpfh_stripped(self): + """Test using mwparserfromhell with stripping.""" + func = functools.partial(textlib.extract_templates_and_params_mwpfh, + strip=True) + + self._common_results(func) + self._order_differs(func) + self._stripped(func) + def test_extract_templates_params_regex(self): """Test using many complex regexes.""" func = functools.partial(textlib.extract_templates_and_params_regex, - remove_disabled_parts=False) + remove_disabled_parts=False, strip=False) self._common_results(func) self._order_differs(func) + self._unstripped(func) self.assertEqual(func('{{a|b={} }}'), []) # FIXME: {} is normal text - self.assertEqual(func('{{a| b=c}}'), [('a', OrderedDict((('b', 'c'), )))]) - self.assertEqual(func('{{a|b =c}}'), [('a', OrderedDict((('b', 'c'), )))]) - self.assertEqual(func('{{a|b= c}}'), [('a', OrderedDict((('b', 'c'), )))]) - self.assertEqual(func('{{a|b=c }}'), [('a', OrderedDict((('b', 'c'), )))]) - + def test_extract_templates_params_regex_stripped(self): + """Test using many complex regexes with stripping.""" func = textlib.extract_templates_and_params_regex + + self._common_results(func) + self._order_differs(func) + self._stripped(func) + self.assertEqual(func('{{a|b=}}'), [('a', OrderedDict((('b', ''), )))]) @@ -415,9 +465,16 @@ def test_extract_templates_params(self): """Test that the normal entry point works.""" - self._common_results( - functools.partial(textlib.extract_templates_and_params, - remove_disabled_parts=False)) + func = functools.partial(textlib.extract_templates_and_params, + remove_disabled_parts=False, strip=False) + + self._common_results(func) + self._unstripped(func) + + func = functools.partial(textlib.extract_templates_and_params, + remove_disabled_parts=False, strip=True) + self._common_results(func) + self._stripped(func) def test_template_simple_regex(self): """Test using simple regex.""" @@ -569,12 +626,14 @@ def extract_mwpfh(self, text, *args, **kwargs): """Patched call to extract_templates_and_params_mwpfh.""" self._text = text + self._args = args self._mwpfh = True @PatchingTestCase.patched(textlib, 'extract_templates_and_params_regex') def extract_regex(self, text, *args, **kwargs): """Patched call to extract_templates_and_params_regex.""" self._text = text + self._args = args self._mwpfh = False def test_removing_disabled_parts_regex(self): @@ -604,6 +663,33 @@ self.assertEqual(self._text, '{{a}}') self.assertTrue(self._mwpfh) + def test_strip_regex(self): + """Test stripping values when using the regex variant.""" + self.patch(config, 'use_mwparserfromhell', False) + textlib.extract_templates_and_params('{{a| foo }}', False, True) + self.assertEqual(self._args, (False, True)) + self.assertFalse(self._mwpfh) + textlib.extract_templates_and_params('{{a| foo }}', False, False) + self.assertEqual(self._args, (False, False)) + self.assertFalse(self._mwpfh) + textlib.extract_templates_and_params('{{a| foo }}', False) + self.assertEqual(self._args, (False, True)) + self.assertFalse(self._mwpfh) + + @require_modules('mwparserfromhell') + def test_strip_mwpfh(self): + """Test stripping values when using the mwpfh variant.""" + self.patch(config, 'use_mwparserfromhell', True) + textlib.extract_templates_and_params('{{a| foo }}', None, True) + self.assertEqual(self._args, (True, )) + self.assertTrue(self._mwpfh) + textlib.extract_templates_and_params('{{a| foo }}', None, False) + self.assertEqual(self._args, (False, )) + self.assertTrue(self._mwpfh) + textlib.extract_templates_and_params('{{a| foo }}') + self.assertEqual(self._args, (False, )) + self.assertTrue(self._mwpfh) + class TestReplaceLinks(TestCase): -- To view, visit https://gerrit.wikimedia.org/r/234832 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic77f2115c5727ea8f573ec269886769e1c6b4333 Gerrit-PatchSet: 11 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 6 months

[Gerrit] [FIX] Removing disabled parts without mwpfh - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FIX] Removing disabled parts without mwpfh ...................................................................... [FIX] Removing disabled parts without mwpfh When `mwparserfromhell` is not installed it won't remove disabled parts unless that parameter is explicitly set to `True`. Before 13cd73de it was always set to `True` when using the regex variant but after that patch it only changed the default value of `None` when `mwparserfromhell` is used. Bug: T113892 Change-Id: I255823fc574c9d03f8d9961350a3545f3bcea3fb --- M pywikibot/textlib.py M tests/textlib_tests.py 2 files changed, 51 insertions(+), 4 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py index 5998ac0..36c6e81 100644 --- a/pywikibot/textlib.py +++ b/pywikibot/textlib.py @@ -1291,9 +1291,8 @@ use_mwparserfromhell = (config.use_mwparserfromhell and not isinstance(mwparserfromhell, Exception)) - if use_mwparserfromhell: - if remove_disabled_parts is None: - remove_disabled_parts = False + if remove_disabled_parts is None: + remove_disabled_parts = not use_mwparserfromhell if remove_disabled_parts: text = removeDisabledParts(text) diff --git a/tests/textlib_tests.py b/tests/textlib_tests.py index e50d5ef..0b0205e 100644 --- a/tests/textlib_tests.py +++ b/tests/textlib_tests.py @@ -23,6 +23,7 @@ from tests.aspects import ( unittest, require_modules, TestCase, DefaultDrySiteTestCase, + PatchingTestCase, ) files = {} @@ -415,7 +416,8 @@ def test_extract_templates_params(self): """Test that the normal entry point works.""" self._common_results( - textlib.extract_templates_and_params) + functools.partial(textlib.extract_templates_and_params, + remove_disabled_parts=False)) def test_template_simple_regex(self): """Test using simple regex.""" @@ -557,6 +559,52 @@ self.assertTrue(m.group(0).endswith('foo {{bar}}')) +class TestGenericTemplateParams(PatchingTestCase): + + """Test whether the generic function forwards the call correctly.""" + + net = False + + @PatchingTestCase.patched(textlib, 'extract_templates_and_params_mwpfh') + def extract_mwpfh(self, text, *args, **kwargs): + """Patched call to extract_templates_and_params_mwpfh.""" + self._text = text + self._mwpfh = True + + @PatchingTestCase.patched(textlib, 'extract_templates_and_params_regex') + def extract_regex(self, text, *args, **kwargs): + """Patched call to extract_templates_and_params_regex.""" + self._text = text + self._mwpfh = False + + def test_removing_disabled_parts_regex(self): + """Test removing disabled parts when using the regex variant.""" + self.patch(config, 'use_mwparserfromhell', False) + textlib.extract_templates_and_params('{{a}}', True) + self.assertEqual(self._text, '{{a}}') + self.assertFalse(self._mwpfh) + textlib.extract_templates_and_params('{{a}}', False) + self.assertEqual(self._text, '{{a}}') + self.assertFalse(self._mwpfh) + textlib.extract_templates_and_params('{{a}}') + self.assertEqual(self._text, '{{a}}') + self.assertFalse(self._mwpfh) + + @require_modules('mwparserfromhell') + def test_removing_disabled_parts_mwpfh(self): + """Test removing disabled parts when using the mwpfh variant.""" + self.patch(config, 'use_mwparserfromhell', True) + textlib.extract_templates_and_params('{{a}}', True) + self.assertEqual(self._text, '{{a}}') + self.assertTrue(self._mwpfh) + textlib.extract_templates_and_params('{{a}}', False) + self.assertEqual(self._text, '{{a}}') + self.assertTrue(self._mwpfh) + textlib.extract_templates_and_params('{{a}}') + self.assertEqual(self._text, '{{a}}') + self.assertTrue(self._mwpfh) + + class TestReplaceLinks(TestCase): """Test the replace_links function in textlib.""" -- To view, visit https://gerrit.wikimedia.org/r/241565 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I255823fc574c9d03f8d9961350a3545f3bcea3fb Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

8 years, 6 months

[Gerrit] [FIX] patrol_tests: Define dry author namespace - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FIX] patrol_tests: Define dry author namespace ...................................................................... [FIX] patrol_tests: Define dry author namespace The patrol tests were testing a feature which also uses a wikisource specific feature and require a namespace for the given author namespace number. This adds a namespace for that author namespace number. Change-Id: I6b57acc4f8d1639ca0963b39171212ab28c9136c --- M tests/utils.py 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/utils.py b/tests/utils.py index b4335be..b2488f9 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -382,7 +382,15 @@ self._msgcache = {'*': 'dummy entry', 'hello': 'world'} def _build_namespaces(self): - return Namespace.builtin_namespaces(case=self.siteinfo['case']) + ns_dict = Namespace.builtin_namespaces(case=self.siteinfo['case']) + if hasattr(self.family, 'authornamespaces'): + assert len(self.family.authornamespaces[self.code]) <= 1 + if self.family.authornamespaces[self.code]: + author_ns = self.family.authornamespaces[self.code][0] + assert author_ns not in ns_dict + ns_dict[author_ns] = Namespace( + author_ns, 'Author', case=self.siteinfo['case']) + return ns_dict @property def userinfo(self): -- To view, visit https://gerrit.wikimedia.org/r/241479 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b57acc4f8d1639ca0963b39171212ab28c9136c Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

8 years, 6 months

[Gerrit] [FIX] Implement getargspec in tools - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FIX] Implement getargspec in tools ...................................................................... [FIX] Implement getargspec in tools With version 3 inspect.getargspec has been deprecated and with version 3.6 it is supposed to be removed. This implements getargspec in tools which just calls the implementation before Python 3.3. In Python 3.3 it calls the replacement, inspect.signature, and constructs a result simulating getargspec from it. It removes the special case for handling deprecation warnings in Python 3.5 introduced in 773e72ee. Bug: T106209 Change-Id: Ib68f09b3e47169279d9725ae0ddfab71009b2e1c --- M pywikibot/data/api.py M pywikibot/tools/__init__.py M tests/tools_tests.py M tests/utils.py 4 files changed, 117 insertions(+), 10 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index e5f6873..53e6132 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -29,7 +29,9 @@ import pywikibot from pywikibot import config, login -from pywikibot.tools import MediaWikiVersion, deprecated, itergroup, ip, PY2 +from pywikibot.tools import ( + MediaWikiVersion, deprecated, itergroup, ip, PY2, getargspec, +) from pywikibot.tools.formatter import color_format from pywikibot.exceptions import ( Server504Error, Server414Error, FatalServerError, NoUsername, Error @@ -1515,7 +1517,7 @@ for super_cls in inspect.getmro(cls): if not super_cls.__name__.endswith('Request'): break - args |= set(inspect.getargspec(super_cls.__init__)[0]) + args |= set(getargspec(super_cls.__init__)[0]) else: raise ValueError('Request was not a super class of ' '{0!r}'.format(cls)) diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py index 61b353d..4655d91 100644 --- a/pywikibot/tools/__init__.py +++ b/pywikibot/tools/__init__.py @@ -38,6 +38,38 @@ from pywikibot.logging import debug + +if PYTHON_VERSION < (3, 5): + # although deprecated in 3 completely no message was emitted until 3.5 + ArgSpec = inspect.ArgSpec + getargspec = inspect.getargspec +else: + ArgSpec = collections.namedtuple('ArgSpec', ['args', 'varargs', 'keywords', + 'defaults']) + + def getargspec(func): + """Python 3 implementation using inspect.signature.""" + sig = inspect.signature(func) + args = [] + defaults = [] + varargs = None + kwargs = None + for p in sig.parameters.values(): + if p.kind == inspect.Parameter.VAR_POSITIONAL: + varargs = p.name + elif p.kind == inspect.Parameter.VAR_KEYWORD: + kwargs = p.name + else: + args += [p.name] + if p.default != inspect.Parameter.empty: + defaults += [p.default] + if defaults: + defaults = tuple(defaults) + else: + defaults = None + return ArgSpec(args, varargs, kwargs, defaults) + + _logger = 'tools' @@ -1349,7 +1381,7 @@ """ name = obj.__full_name__ depth = get_wrapper_depth(wrapper) + 1 - args, varargs, kwargs, _ = inspect.getargspec(wrapper.__wrapped__) + args, varargs, kwargs, _ = getargspec(wrapper.__wrapped__) if varargs is not None and kwargs is not None: raise ValueError('{0} may not have * or ** args.'.format( name)) diff --git a/tests/tools_tests.py b/tests/tools_tests.py index 9b2445a..919f28c 100644 --- a/tests/tools_tests.py +++ b/tests/tools_tests.py @@ -11,15 +11,17 @@ import collections import decimal +import inspect import os.path import subprocess import tempfile +import warnings from pywikibot import tools from tests import join_xml_data_path -from tests.aspects import unittest, DeprecationTestCase, TestCase -from tests.utils import expected_failure_if +from tests.aspects import unittest, DeprecationTestCase, TestCase, MetaTestCaseClass +from tests.utils import expected_failure_if, add_metaclass class ContextManagerWrapperTestCase(TestCase): @@ -487,6 +489,82 @@ self.assertRaises(StopIteration, next, deduper) +class MetaTestArgSpec(MetaTestCaseClass): + + """Metaclass to create dynamically the tests. Set the net flag to false.""" + + def __new__(cls, name, bases, dct): + """Create a new test case class.""" + def create_test(method): + def test_method(self): + # all expect at least self and param + expected = method(1, 2) + returned = self.getargspec(method) + self.assertEqual(returned, expected) + self.assertIsInstance(returned, self.expected_class) + self.assertNoDeprecation() + return test_method + + for name, tested_method in list(dct.items()): + if name.startswith('_method_test_'): + suffix = name[len('_method_test_'):] + test_name = 'test_method_' + suffix + dct[test_name] = create_test(tested_method) + dct[test_name].__doc__ = 'Test getargspec on {0}'.format(suffix) + + dct['net'] = False + return super(MetaTestArgSpec, cls).__new__(cls, name, bases, dct) + + +@add_metaclass +class TestArgSpec(DeprecationTestCase): + + """Test getargspec and ArgSpec from tools.""" + + __metaclass__ = MetaTestArgSpec + + expected_class = tools.ArgSpec + + def _method_test_args(self, param): + """Test method with two positional arguments.""" + return (['self', 'param'], None, None, None) + + def _method_test_kwargs(self, param=42): + """Test method with one positional and one keyword argument.""" + return (['self', 'param'], None, None, (42,)) + + def _method_test_varargs(self, param, *var): + """Test method with two positional arguments and var args.""" + return (['self', 'param'], 'var', None, None) + + def _method_test_varkwargs(self, param, **var): + """Test method with two positional arguments and var kwargs.""" + return (['self', 'param'], None, 'var', None) + + def _method_test_vars(self, param, *args, **kwargs): + """Test method with two positional arguments and both var args.""" + return (['self', 'param'], 'args', 'kwargs', None) + + def getargspec(self, method): + """Call tested getargspec function.""" + return tools.getargspec(method) + + +(a)unittest.skipIf(tools.PYTHON_VERSION >= (3, 6), 'removed in Python 3.6') +class TestPythonArgSpec(TestArgSpec): + + """Test the same tests using Python's implementation.""" + + expected_class = inspect.ArgSpec + + def getargspec(self, method): + """Call inspect's getargspec function.""" + with warnings.catch_warnings(): + if tools.PYTHON_VERSION >= (3, 5): + warnings.simplefilter('ignore', DeprecationWarning) + return inspect.getargspec(method) + + if __name__ == '__main__': try: unittest.main() diff --git a/tests/utils.py b/tests/utils.py index 69f2fae..533f17c 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -230,11 +230,6 @@ else: skip_lines -= 1 - # Avoid failures because getargspec hasn't been removed yet: T106209 - if PYTHON_VERSION >= (3, 5, 0): - if str(entry.message) == ('inspect.getargspec() is deprecated, ' - 'use inspect.signature() instead'): - return # Avoid failures because cryptography is mentioning Python 2.6 # is outdated if PYTHON_VERSION < (2, 7): -- To view, visit https://gerrit.wikimedia.org/r/225537 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib68f09b3e47169279d9725ae0ddfab71009b2e1c Gerrit-PatchSet: 5 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 6 months

Failed: wikimedia/pywikibot-core#2918 (master - b66f9b5)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2918 Status: Failed Duration: 33 minutes and 7 seconds Commit: b66f9b5 (master) Author: Fabian Neundorf Message: [IMPROV] patrol: Replace add_to_tuples with defaultdict Instead of using the static method it now just uses a `defaultdict`. This is also renaming the method-local variable from `tuples` to `whitelist`, especially as it's a `dict` of `lists` and `tuples` isn't applicable. Change-Id: I7cb543a4f1077e4a76c2abe8888ff95ae4dade0f View the changeset: https://github.com/wikimedia/pywikibot-core/compare/0c8150f39c7e...b66f9b57… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/82352827 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 6 months

[Gerrit] [IMPROV] patrol: Replace add_to_tuples with defaultdict - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] patrol: Replace add_to_tuples with defaultdict ...................................................................... [IMPROV] patrol: Replace add_to_tuples with defaultdict Instead of using the static method it now just uses a `defaultdict`. This is also renaming the method-local variable from `tuples` to `whitelist`, especially as it's a `dict` of `lists` and `tuples` isn't applicable. Change-Id: I7cb543a4f1077e4a76c2abe8888ff95ae4dade0f --- M scripts/patrol.py 1 file changed, 8 insertions(+), 16 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/patrol.py b/scripts/patrol.py index 0adacee..1f4b5b8 100755 --- a/scripts/patrol.py +++ b/scripts/patrol.py @@ -48,6 +48,8 @@ __version__ = '$Id$' import time +from collections import defaultdict + import mwparserfromhell import pywikibot @@ -165,17 +167,6 @@ raise pywikibot.error(u'%s' % e) - @staticmethod - def add_to_tuples(tuples, user, page): - """Update tuples 'user' key by adding page.""" - if pywikibot.config.verbose_output: - pywikibot.output(u"Adding %s:%s" % (user, page.title())) - - if user in tuples: - tuples[user].append(page) - else: - tuples[user] = [page] - def in_list(self, pagelist, title): """Check if title present in pagelist.""" if pywikibot.config.verbose_output: @@ -209,7 +200,7 @@ def parse_page_tuples(self, wikitext, user=None): """Parse page details apart from 'user:' for use.""" - tuples = {} + whitelist = defaultdict(list) current_user = False parsed = mwparserfromhell.parse(wikitext) @@ -263,19 +254,20 @@ if self.is_wikisource_author_page(page): if pywikibot.config.verbose_output: pywikibot.output(u'Whitelist author: %s' % page) - author = LinkedPagesRule(page) - self.add_to_tuples(tuples, current_user, author) + page = LinkedPagesRule(page) else: if pywikibot.config.verbose_output: pywikibot.output(u'Whitelist page: %s' % page) - self.add_to_tuples(tuples, current_user, page) + if pywikibot.config.verbose_output: + pywikibot.output('Adding {0}:{1}'.format(current_user, page)) + whitelist[current_user].append(page) elif pywikibot.config.verbose_output: pywikibot.output(u'Discarding whitelist page for ' u'another user: %s' % page) else: raise Exception(u'No user set for page %s' % page) - return tuples + return dict(whitelist) def is_wikisource_author_page(self, title): """Initialise author_ns if site family is 'wikisource' else pass.""" -- To view, visit https://gerrit.wikimedia.org/r/241328 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cb543a4f1077e4a76c2abe8888ff95ae4dade0f Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

8 years, 6 months

Errored: wikimedia/pywikibot-core#2917 (master - 0c8150f)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #2917 Status: Errored Duration: 31 minutes and 20 seconds Commit: 0c8150f (master) Author: Fabian Neundorf Message: [FIX] patrol: Replace mwlib with mwparserfromhell This removes the dependency of `mwlib` (which doesn't work on Python 3) and uses `mwparserfromhell` instead. Unfortunately does the `mwparserfromhell` implementation not support lists directly so the parsed result has to be filtered manually. It now allows links outside of lists and normalizes the titles and checks against the aliases for `Special:PrefixIndex`. Bug: T95142 Change-Id: I4f7b5c7a67e0c90530319fce1f3ab0ca0c1a1138 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/62b6743eb672...0c8150f3… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/82302454 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

8 years, 6 months

[Gerrit] [FIX] patrol: Replace mwlib with mwparserfromhell - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FIX] patrol: Replace mwlib with mwparserfromhell ...................................................................... [FIX] patrol: Replace mwlib with mwparserfromhell This removes the dependency of `mwlib` (which doesn't work on Python 3) and uses `mwparserfromhell` instead. Unfortunately does the `mwparserfromhell` implementation not support lists directly so the parsed result has to be filtered manually. It now allows links outside of lists and normalizes the titles and checks against the aliases for `Special:PrefixIndex`. Bug: T95142 Change-Id: I4f7b5c7a67e0c90530319fce1f3ab0ca0c1a1138 --- M pywikibot/version.py M requirements.txt M scripts/patrol.py M setup.py M tests/patrolbot_tests.py M tests/script_tests.py M tests/utils.py 7 files changed, 67 insertions(+), 54 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/version.py b/pywikibot/version.py index 7f5c64d..5ac6e1d 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -533,14 +533,6 @@ info['ver'] = package.__version__ elif name.startswith('unicodedata'): info['ver'] = package.unidata_version - elif name == 'mwlib': # mwlib 0.14.3 does not include a __init__.py - module = __import__(name + '._version', - fromlist=['_version'], level=0) - if '__version__' in module.__dict__: - info['ver'] = module.__version__ - path = module.__file__ - path = path[0:path.index('_version.')] - info['path'] = path # If builtins or standard_lib is None, # only include package if a version was found. diff --git a/requirements.txt b/requirements.txt index cad79bf..66f32bf 100644 --- a/requirements.txt +++ b/requirements.txt @@ -73,7 +73,7 @@ # incomplete core component botirc irc ; python_version > '2.6' -# textlib.py +# textlib.py and patrol.py mwparserfromhell>=0.3.3 ; python_version <= '3.4' # The mysql generator in pagegenerators depends on either oursql or MySQLdb diff --git a/scripts/patrol.py b/scripts/patrol.py index e37907d..0adacee 100755 --- a/scripts/patrol.py +++ b/scripts/patrol.py @@ -5,9 +5,30 @@ This bot obtains a list of recent changes and newpages and marks the edits as patrolled based on a whitelist. -See http://en.wikisource.org/wiki/User:JVbot/patrol_whitelist -Commandline parameters that are supported: +Whitelist format +================ + +The whitelist is formatted as a number of list entries. Any links outside of +lists are ignored and can be used for documentation. In a list the first link +must be to the username which should be white listed and any other link +following is adding that page to the white list of that username. If the user +edited a page on their white list it gets patrolled. It will also patrol pages +which start with the mentioned link (e.g. [[foo]] will also patrol [[foobar]]). + +To avoid redlinks it's possible to use Special:PrefixIndex as a prefix so that +it will list all pages which will be patrolled. The page after the slash will be +used then. + +On Wikisource, it'll also check if the page is on the author namespace in which +case it'll also patrol pages which are linked from that page. + +An example can be found at: + +https://en.wikisource.org/wiki/User:Wikisource-bot/patrol_whitelist + +Commandline parameters +====================== -namespace Filter the page generator to only yield pages in specified namespaces @@ -25,9 +46,9 @@ from __future__ import absolute_import, unicode_literals __version__ = '$Id$' -import mwlib.uparser # used to parse the whitelist -import mwlib.parser # used to parse the whitelist import time + +import mwparserfromhell import pywikibot @@ -92,6 +113,13 @@ self.rc_item_counter = 0 # counts how many items have been reviewed self.patrol_counter = 0 # and how many times an action was taken + for entry in self.site.siteinfo['specialpagealiases']: + if entry['realname'] == 'Prefixindex': + self._prefixindex_aliases = set(alias.lower() + for alias in entry['aliases']) + break + else: + raise RuntimeError('No alias for "prefixindex"') def load_whitelist(self): """Load most recent watchlist_page for further processing.""" @@ -183,34 +211,35 @@ """Parse page details apart from 'user:' for use.""" tuples = {} - # for any structure, the only first 'user:' page - # is registered as the user the rest of the structure - # refers to. - def process_children(obj, current_user): - pywikibot.debug(u'Parsing node: %s' % obj, _logger) - for c in obj.children: - temp = process_node(c, current_user) - if temp and not current_user: - current_user = temp + current_user = False + parsed = mwparserfromhell.parse(wikitext) + for node in parsed.nodes: + if isinstance(node, mwparserfromhell.nodes.tag.Tag): + if node.tag == 'li': + current_user = None + elif isinstance(node, mwparserfromhell.nodes.text.Text): + if node.endswith('\n'): + current_user = False + elif isinstance(node, mwparserfromhell.nodes.wikilink.Wikilink): + if current_user is False: + pywikibot.debug('Link to "{0}" ignored as outside ' + 'list'.format(node.title), _logger) + continue - def process_node(obj, current_user): - # links are analysed; interwiki links are included because mwlib - # incorrectly calls 'Wikisource:' namespace links an interwiki - if isinstance(obj, mwlib.parser.NamespaceLink) or \ - isinstance(obj, mwlib.parser.InterwikiLink) or \ - isinstance(obj, mwlib.parser.ArticleLink): + obj = pywikibot.Link(node.title, self.site) if obj.namespace == -1: # the parser accepts 'special:prefixindex/' as a wildcard # this allows a prefix that doesnt match an existing page # to be a blue link, and can be clicked to see what pages # will be included in the whitelist - if obj.target[:20].lower() == 'special:prefixindex/': - if len(obj.target) == 20: + name, sep, prefix = obj.title.partition('/') + if name.lower() in self._prefixindex_aliases: + if not prefix: if pywikibot.config.verbose_output: pywikibot.output(u'Whitelist everything') page = '' else: - page = obj.target[20:] + page = prefix if pywikibot.config.verbose_output: pywikibot.output(u'Whitelist prefixindex hack ' u'for: %s' % page) @@ -222,13 +251,12 @@ # if a target user hasn't been found yet, and the link is # 'user:' # the user will be the target of subsequent rules - page_prefix_len = len(self.site.namespace(2)) - current_user = obj.target[(page_prefix_len + 1):] + current_user = obj.title if pywikibot.config.verbose_output: pywikibot.output(u'Whitelist user: %s' % current_user) - return current_user + continue else: - page = obj.target + page = obj.canonical_title() if current_user: if not user or current_user == user: @@ -246,11 +274,6 @@ u'another user: %s' % page) else: raise Exception(u'No user set for page %s' % page) - else: - process_children(obj, current_user) - - root = mwlib.uparser.parseString(title='Not used', raw=wikitext) - process_children(root, None) return tuples diff --git a/setup.py b/setup.py index 6a120b1..ad37305 100644 --- a/setup.py +++ b/setup.py @@ -69,6 +69,7 @@ 'flickrripper.py': ['Pillow'], 'states_redirect.py': ['pycountry'], 'weblinkchecker.py': ['memento_client>=0.5.1'], + 'patrol.py': ['mwparserfromhell>=0.3.3'], } # flickrapi 1.4.4 installs a root logger in verbose mode; 1.4.5 fixes this. # The problem doesnt exist in flickrapi 2.x. @@ -133,9 +134,6 @@ script_deps['data_ingestion.py'] = extra_deps['csv'] - # mwlib is not available for py3 - script_deps['patrol'] = ['mwlib'] - # Some of the ui_tests depend on accessing the console window's menu # to set the console font and copy and paste, achieved using pywinauto # which depends on pywin32. @@ -157,11 +155,6 @@ # so all scripts can be compiled for script_tests, etc. if 'PYSETUP_TEST_EXTRAS' in os.environ: test_deps += list(itertools.chain(*(extra_deps.values()))) - # mwlib requires 'pyparsing>=1.4.11,<1.6', which conflicts with - # pydot's requirement for pyparsing>=2.0.1. - if 'mwlib' in test_deps: - test_deps.remove('mwlib') - if 'oursql' in test_deps and os.name == 'nt': test_deps.remove('oursql') # depends on Cython diff --git a/tests/patrolbot_tests.py b/tests/patrolbot_tests.py index 961d637..efaa29d 100644 --- a/tests/patrolbot_tests.py +++ b/tests/patrolbot_tests.py @@ -12,7 +12,7 @@ try: from scripts import patrol except ImportError: - patrol = None # if mwlib is not installed + patrol = None # if mwparserfromhell is not installed from tests.aspects import require_modules, unittest, DefaultDrySiteTestCase @@ -21,17 +21,17 @@ == Header == * [[User:Test 1]]: [[Page 1]], [[Page 2]] -* [[User:Test 2]]: [[Page 2]], [[Page 4]], [[Page 6]] +* [[User:Test_2]]: [[Page 2]], [[Page 4]], [[Page 6]] == Others == * [[User:Prefixed]]: [[Special:PrefixIndex/Page 1]], [[Special:PREFIXINDEX/Page 2]] == More test 1 == -* [[User:Test 1]]: [[Page 3]] +* [[User:Test_1]]: [[Page 3]] """ -@require_modules('mwlib') +@require_modules('mwparserfromhell') class TestPatrolBot(DefaultDrySiteTestCase): """Test the PatrolBot class.""" @@ -51,7 +51,7 @@ for i in range(1, 4)]) self.assertIn('Prefixed', tuples) self.assertEqual(tuples['Prefixed'], ['Page 1', 'Page 2']) - self.assertRaises(Exception, self.bot.parse_page_tuples, '[[link]]') + self.assertEqual(self.bot.parse_page_tuples('[[link]]'), {}) def test_in_list(self): """Test the method which returns whether a page is in the list.""" diff --git a/tests/script_tests.py b/tests/script_tests.py index 10cd8d1..66bd657 100644 --- a/tests/script_tests.py +++ b/tests/script_tests.py @@ -44,7 +44,7 @@ 'match_images': ['PIL.ImageTk'], 'panoramiopicker': ['BeautifulSoup'], 'states_redirect': ['pycountry'], - 'patrol': ['mwlib'], + 'patrol': ['mwparserfromhell'], } if PYTHON_VERSION < (2, 7): diff --git a/tests/utils.py b/tests/utils.py index 69f2fae..b4335be 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -374,6 +374,11 @@ if self.family.name == 'wikisource': extensions.append({'name': 'ProofreadPage'}) self._siteinfo._cache['extensions'] = (extensions, True) + aliases = [] + for alias in ('PrefixIndex', ): + # TODO: Not all follow that scheme (e.g. "BrokenRedirects") + aliases.append({'realname': alias.capitalize(), 'aliases': [alias]}) + self._siteinfo._cache['specialpagealiases'] = (aliases, True) self._msgcache = {'*': 'dummy entry', 'hello': 'world'} def _build_namespaces(self): -- To view, visit https://gerrit.wikimedia.org/r/202011 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f7b5c7a67e0c90530319fce1f3ab0ca0c1a1138 Gerrit-PatchSet: 5 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

8 years, 6 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits September 2015