On Thu, Feb 13, 2014 at 2:36 PM, jenkins-no-reply@cloudbees.com wrote:
- FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox
Build #349 https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/349/ (Thu, 13 Feb 2014 20:59:07 +0000)* *Test Result*https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/349/testReport/ 2 failed, 7 skipped Failed Tests *Test Name**Duration**Age* Encourage new users to Keep Going.I see a KeepGoing message after completing my edithttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/349/testReport/junit/(root)/Encourage%20new%20users%20to%20Keep%20Going/I_see_a_KeepGoing_message_after_completing_my_edit1 min 36 sec1https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/348/ VisualEditor.Toolbar VisualEditorhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/349/testReport/junit/(root)/VisualEditor/Toolbar_VisualEditor54 sec1https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/348/
I tested this manually to verify the failure and VE does not seem to fully load in mobile on betalabs. When I hit http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Edit_Test#/VisualEditor..., i see the text of the article with the loading spinner spinning. There's a Javascript error: Uncaught TypeError: Cannot call method 'setElementGroup' of undefined
See attached screenshot. Is this is a known issue?
On Feb 13, 2014 3:37 PM, "Arthur Richards" arichards@wikimedia.org wrote:
I tested this manually to verify the failure and VE does not seem to
fully load in mobile on betalabs. When I hit http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Edit_Test#/VisualEditor..., i see the text of the article with the loading spinner spinning. There's a Javascript error: Uncaught TypeError: Cannot call method 'setElementGroup' of undefined
Sounds like an issue with Trevor's widget grouping code. Trevor, could you look into this?
Roan
I could, but I'm having DNS issues. Basically, you need to update MediaWiki core, so you get the latest oojs-ui, which adds such support.
In short - they are out of sync.
- Trevor
On Thu, Feb 13, 2014 at 4:13 PM, Roan Kattouw rkattouw@wikimedia.orgwrote:
On Feb 13, 2014 3:37 PM, "Arthur Richards" arichards@wikimedia.org wrote:
I tested this manually to verify the failure and VE does not seem to
fully load in mobile on betalabs. When I hit http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Edit_Test#/VisualEditor..., i see the text of the article with the loading spinner spinning. There's a Javascript error: Uncaught TypeError: Cannot call method 'setElementGroup' of undefined
Sounds like an issue with Trevor's widget grouping code. Trevor, could you look into this?
Roan
On Feb 13, 2014 4:28 PM, "Trevor Parscal" tparscal@wikimedia.org wrote:
I could, but I'm having DNS issues. Basically, you need to update
MediaWiki core, so you get the latest oojs-ui, which adds such support.
In short - they are out of sync.
This is on beta labs, so while I suppose it's possible that things are out of sync there, it seems unlikely.
I'll take a look later today.
Roan
Indeed, I have a fix: https://gerrit.wikimedia.org/r/113309
I made a mistake in https://gerrit.wikimedia.org/r/#/c/113068/ which Roan gave the ol' +2. So, two points of embarrassing failure. Nice.
- Trevor
On Thu, Feb 13, 2014 at 4:30 PM, Roan Kattouw rkattouw@wikimedia.orgwrote:
On Feb 13, 2014 4:28 PM, "Trevor Parscal" tparscal@wikimedia.org wrote:
I could, but I'm having DNS issues. Basically, you need to update
MediaWiki core, so you get the latest oojs-ui, which adds such support.
In short - they are out of sync.
This is on beta labs, so while I suppose it's possible that things are out of sync there, it seems unlikely.
I'll take a look later today.
Roan
Heh, thanks for spotting the issue so quickly and submitting a fix. Once merged, hopefully the test failures will disappear. Thanks again!
On Thu, Feb 13, 2014 at 5:43 PM, Trevor Parscal tparscal@wikimedia.orgwrote:
Indeed, I have a fix: https://gerrit.wikimedia.org/r/113309
I made a mistake in https://gerrit.wikimedia.org/r/#/c/113068/ which Roan gave the ol' +2. So, two points of embarrassing failure. Nice.
- Trevor
On Thu, Feb 13, 2014 at 4:30 PM, Roan Kattouw rkattouw@wikimedia.orgwrote:
On Feb 13, 2014 4:28 PM, "Trevor Parscal" tparscal@wikimedia.org wrote:
I could, but I'm having DNS issues. Basically, you need to update
MediaWiki core, so you get the latest oojs-ui, which adds such support.
In short - they are out of sync.
This is on beta labs, so while I suppose it's possible that things are out of sync there, it seems unlikely.
I'll take a look later today.
Roan
Arthur,
This should now be fixed (I tested and was able to manually verify it working on that URL, as you can seehttp://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/80262 ).
Sorry for breaking VE in master; this Shouldn't Ever Happen™ and underlies our (already-acknowledged) need for a test suite for OOjs UI.
J.
On 13 February 2014 17:36, Arthur Richards arichards@wikimedia.org wrote:
Heh, thanks for spotting the issue so quickly and submitting a fix. Once merged, hopefully the test failures will disappear. Thanks again!
On Thu, Feb 13, 2014 at 5:43 PM, Trevor Parscal tparscal@wikimedia.orgwrote:
Indeed, I have a fix: https://gerrit.wikimedia.org/r/113309
I made a mistake in https://gerrit.wikimedia.org/r/#/c/113068/ which Roan gave the ol' +2. So, two points of embarrassing failure. Nice.
- Trevor
On Thu, Feb 13, 2014 at 4:30 PM, Roan Kattouw rkattouw@wikimedia.orgwrote:
On Feb 13, 2014 4:28 PM, "Trevor Parscal" tparscal@wikimedia.org wrote:
I could, but I'm having DNS issues. Basically, you need to update
MediaWiki core, so you get the latest oojs-ui, which adds such support.
In short - they are out of sync.
This is on beta labs, so while I suppose it's possible that things are out of sync there, it seems unlikely.
I'll take a look later today.
Roan
-- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687
Groovy thanks everyone!
On Thu, Feb 13, 2014 at 8:19 PM, James Forrester jforrester@wikimedia.orgwrote:
Arthur,
This should now be fixed (I tested and was able to manually verify it working on that URL, as you can seehttp://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/80262 ).
Sorry for breaking VE in master; this Shouldn't Ever Happen(tm) and underlies our (already-acknowledged) need for a test suite for OOjs UI.
J.
On 13 February 2014 17:36, Arthur Richards arichards@wikimedia.orgwrote:
Heh, thanks for spotting the issue so quickly and submitting a fix. Once merged, hopefully the test failures will disappear. Thanks again!
On Thu, Feb 13, 2014 at 5:43 PM, Trevor Parscal tparscal@wikimedia.orgwrote:
Indeed, I have a fix: https://gerrit.wikimedia.org/r/113309
I made a mistake in https://gerrit.wikimedia.org/r/#/c/113068/ which Roan gave the ol' +2. So, two points of embarrassing failure. Nice.
- Trevor
On Thu, Feb 13, 2014 at 4:30 PM, Roan Kattouw rkattouw@wikimedia.orgwrote:
On Feb 13, 2014 4:28 PM, "Trevor Parscal" tparscal@wikimedia.org wrote:
I could, but I'm having DNS issues. Basically, you need to update
MediaWiki core, so you get the latest oojs-ui, which adds such support.
In short - they are out of sync.
This is on beta labs, so while I suppose it's possible that things are out of sync there, it seems unlikely.
I'll take a look later today.
Roan
-- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687
-- James D. Forrester Product Manager, VisualEditor Wikimedia Foundation, Inc.
jforrester@wikimedia.org | @jdforrester
