Recently, I decided to clean-up some of the code in MobileFrontend related to localStorage. The other mobile devs suggested that I implement a generalized solution that could be upstreamed to core. I looked at some 3rd party jQuery plug-ins and decided to implement a solution based on jQuery Store. I stripped out all the extraneous crap and added support for cookies (since localStorage quotas are often rather small for mobile devices) and caching. The end result can be seen at: https://gerrit.wikimedia.org/r/#/c/131239/
After I checked this in, I was informed that there is already a client-side storage plug-in in core: jStorage, as well as another one being used by Flow, Storer. Both of these seem a bit like overkill to me and I would prefer to implement something simple and light-weight for mobile. Also jStorage doesn't support fall-back to cookies.
What are people's opinions on moving forward on this? Should mobile have it's own lightweight plug-in, should we modify jStorage in core so that it meets our requirements, or should we adopt Storer and push for it to replace jStorage in core?
Ryan Kaldari
Shahyar just wrote a slimmed down version of Storer, so I think I'll work on collaborating with him rather than persuing our own solution. No sense having 3 different plug-ins for doing the same thing.
Ryan
On Mon, May 5, 2014 at 5:26 PM, Ryan Kaldari rkaldari@wikimedia.org wrote:
Recently, I decided to clean-up some of the code in MobileFrontend related to localStorage. The other mobile devs suggested that I implement a generalized solution that could be upstreamed to core. I looked at some 3rd party jQuery plug-ins and decided to implement a solution based on jQuery Store. I stripped out all the extraneous crap and added support for cookies (since localStorage quotas are often rather small for mobile devices) and caching. The end result can be seen at: https://gerrit.wikimedia.org/r/#/c/131239/
After I checked this in, I was informed that there is already a client-side storage plug-in in core: jStorage, as well as another one being used by Flow, Storer. Both of these seem a bit like overkill to me and I would prefer to implement something simple and light-weight for mobile. Also jStorage doesn't support fall-back to cookies.
What are people's opinions on moving forward on this? Should mobile have it's own lightweight plug-in, should we modify jStorage in core so that it meets our requirements, or should we adopt Storer and push for it to replace jStorage in core?
Ryan Kaldari
Where can we find it?
On 05/06/2014 11:10 AM, Ryan Kaldari wrote:
Shahyar just wrote a slimmed down version of Storer, so I think I'll work on collaborating with him rather than persuing our own solution. No sense having 3 different plug-ins for doing the same thing.
Ryan
On Mon, May 5, 2014 at 5:26 PM, Ryan Kaldari <rkaldari@wikimedia.org mailto:rkaldari@wikimedia.org> wrote:
Recently, I decided to clean-up some of the code in MobileFrontend related to localStorage. The other mobile devs suggested that I implement a generalized solution that could be upstreamed to core. I looked at some 3rd party jQuery plug-ins and decided to implement a solution based on jQuery Store. I stripped out all the extraneous crap and added support for cookies (since localStorage quotas are often rather small for mobile devices) and caching. The end result can be seen at: https://gerrit.wikimedia.org/r/#/c/131239/ After I checked this in, I was informed that there is already a client-side storage plug-in in core: jStorage, as well as another one being used by Flow, Storer. Both of these seem a bit like overkill to me and I would prefer to implement something simple and light-weight for mobile. Also jStorage doesn't support fall-back to cookies. What are people's opinions on moving forward on this? Should mobile have it's own lightweight plug-in, should we modify jStorage in core so that it meets our requirements, or should we adopt Storer and push for it to replace jStorage in core? Ryan Kaldari
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
https://github.com/shahyar/Storer.js
On Tue, May 6, 2014 at 1:39 PM, Juliusz Gonera jgonera@wikimedia.org wrote:
Where can we find it?
On 05/06/2014 11:10 AM, Ryan Kaldari wrote:
Shahyar just wrote a slimmed down version of Storer, so I think I'll work on collaborating with him rather than persuing our own solution. No sense having 3 different plug-ins for doing the same thing.
Ryan
On Mon, May 5, 2014 at 5:26 PM, Ryan Kaldari rkaldari@wikimedia.org wrote:
Recently, I decided to clean-up some of the code in MobileFrontend related to localStorage. The other mobile devs suggested that I implement a generalized solution that could be upstreamed to core. I looked at some 3rd party jQuery plug-ins and decided to implement a solution based on jQuery Store. I stripped out all the extraneous crap and added support for cookies (since localStorage quotas are often rather small for mobile devices) and caching. The end result can be seen at: https://gerrit.wikimedia.org/r/#/c/131239/
After I checked this in, I was informed that there is already a client-side storage plug-in in core: jStorage, as well as another one being used by Flow, Storer. Both of these seem a bit like overkill to me and I would prefer to implement something simple and light-weight for mobile. Also jStorage doesn't support fall-back to cookies.
What are people's opinions on moving forward on this? Should mobile have it's own lightweight plug-in, should we modify jStorage in core so that it meets our requirements, or should we adopt Storer and push for it to replace jStorage in core?
Ryan Kaldari
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l