Dan Duvall and I worked on his patch refactoring MobileFrontend browser tests yesterday [1]. We got over half of the tests working on mediawiki-vagrant, but we might have caused some breakage on betalabs/jenkins. The last two builds have lots of failures (over 30), but that doesn't mean that the features themselves are broken. We'll figure it out soon.
In general the changes we made were necessary and hopefully will help get everyone running browser tests on their dev instances in the near future. Another nice thing added by Dan is the possiblity of specifying browser tests dependency on other extensions as seen in [2]. Those browser tests will not run (will be skipped) if an extension is not enabled. Instead developers will see a warning saying which extension needs to be enabled to run them.
Dan, thanks for all this work.
[1] https://gerrit.wikimedia.org/r/#/c/147115/ [2] https://gerrit.wikimedia.org/r/#/c/152993/
No problem. There are many more QA dragons to slay, but I'm happy with how this one went down.
I've also updated the Selenium/Cucumber coding conventions with some documentation on extension tags [1].
[1] https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium#Extension_...
On Thu, Aug 14, 2014 at 12:51 PM, Juliusz Gonera jgonera@wikimedia.org wrote:
Dan Duvall and I worked on his patch refactoring MobileFrontend browser tests yesterday [1]. We got over half of the tests working on mediawiki-vagrant, but we might have caused some breakage on betalabs/jenkins. The last two builds have lots of failures (over 30), but that doesn't mean that the features themselves are broken. We'll figure it out soon.
In general the changes we made were necessary and hopefully will help get everyone running browser tests on their dev instances in the near future. Another nice thing added by Dan is the possiblity of specifying browser tests dependency on other extensions as seen in [2]. Those browser tests will not run (will be skipped) if an extension is not enabled. Instead developers will see a warning saying which extension needs to be enabled to run them.
Dan, thanks for all this work.
[1] https://gerrit.wikimedia.org/r/#/c/147115/ [2] https://gerrit.wikimedia.org/r/#/c/152993/
-- Juliusz
This is awesome and long overdue guys. Thanks guys. Dan be sure to grab me when you want to take a look at Echo and Flow and do some huge refactorings there.
On Thu, Aug 14, 2014 at 1:04 PM, Dan Duvall dduvall@wikimedia.org wrote:
No problem. There are many more QA dragons to slay, but I'm happy with how this one went down.
I've also updated the Selenium/Cucumber coding conventions with some documentation on extension tags [1].
[1] https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium#Extension_...
On Thu, Aug 14, 2014 at 12:51 PM, Juliusz Gonera jgonera@wikimedia.org wrote:
Dan Duvall and I worked on his patch refactoring MobileFrontend browser tests yesterday [1]. We got over half of the tests working on mediawiki-vagrant, but we might have caused some breakage on betalabs/jenkins. The last two builds have lots of failures (over 30), but that doesn't mean that the features themselves are broken. We'll figure it out soon.
In general the changes we made were necessary and hopefully will help get everyone running browser tests on their dev instances in the near future. Another nice thing added by Dan is the possiblity of specifying browser tests dependency on other extensions as seen in [2]. Those browser tests will not run (will be skipped) if an extension is not enabled. Instead developers will see a warning saying which extension needs to be enabled to run them.
Dan, thanks for all this work.
[1] https://gerrit.wikimedia.org/r/#/c/147115/ [2] https://gerrit.wikimedia.org/r/#/c/152993/
-- Juliusz
-- Dan Duvall Automation Engineer Wikimedia Foundation
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
On Thu, Aug 14, 2014 at 1:32 PM, Jon Robson jdlrobson@gmail.com wrote:
This is awesome and long overdue guys. Thanks guys. Dan be sure to grab me when you want to take a look at Echo and Flow and do some huge refactorings there.
Absolutely. We've also been discussing doing some brown-bag sessions around browser-testing practices as we improve upon them. I think it would be a great way to kickstart inter-team discussion around difficult test patterns (e.g. inter-wiki or multiple-user interactions, etc.), how they're currently being solved, and how we might adapt those solutions to be more portable/isolated/deterministic.
Also, I have to say that delving into these repos has been a great on-boarding experience for me. What better way to learn about the core features of MediaWiki than to be tasked with verifying the specs? So, thank you!