On Wed, Mar 19, 2014 at 2:44 PM, Jon Robson <jrobson(a)wikimedia.org> wrote:
The problem is it /can't/ be a random page for
removing or adding from
watchlist.
For each run of each .feature file we generate a value called
@random_string. That value remains consistent for the run of all the
Scenarios in the Feature, and you can use that value in any way you choose:
as a page title when creating a page, text in a page, anywhere you need a
more-or-less unique string.
Thus you can create a new page using the value for @random_string, then
navigate to that page and manipulate it any way you like -- for instance,
by clicking the Watchlist icon on and off.
page.feature in the browsertests repo is a good example:
https://git.wikimedia.org/blob/qa%2Fbrowsertests/5b59eb8fd0ab0c841826f9a5bc…
-C
We have to find a page that is already on the
watchlist for the test for
removing from watchlist and for the test adding to watchlist we have to
ensure we land on a page which is not previously being watched.
We could possibly change these so that one of the Given statements is
"Given I am already watching the "Foo" article" - this could then
ensure
the article is being watched and vice versa.
A random page cannot be relied on under any circumstances.
On Wed, Mar 19, 2014 at 2:37 PM, Chris McMahon <cmcmahon(a)wikimedia.org>wrote;wrote:
I fixed it.
Since yesterday Cloudbees has unexpectedly given us unlimited Jenkins
build executors where before we could only run two builds at once. This
has made for a few race conditions, of which this was one.
This test should probably create a random page to use for clicking the
watchlist on and off.
-C
On Wed, Mar 19, 2014 at 2:30 PM, Jon Robson <jrobson(a)wikimedia.org>wrote;wrote:
They are indeed false positives. I think I know
what's happening here.
Basically the tests are not atomic - they are trying to watch an article
that is already watched and have the consequence of making that article
watched. I have an idea of how to fix this.
Does Watir have a concept of a tear down step?
On Wed, Mar 19, 2014 at 1:45 PM, Arthur Richards <
arichards(a)wikimedia.org> wrote:
I tested these manually and think they may be
false positives, but can
someone else take a look to make sure these tests and what's in betalabs is
OK? We should get this resolved asap so we can be sure the state of things
is healthy on betalabs for tomorrow's deployment.
On Wed, Mar 19, 2014 at 12:19 PM, <jenkins-no-reply(a)cloudbees.com>wrote;wrote:
> * FAILURE:
> MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox Build #434
>
<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/434/>
> (Wed, 19 Mar 2014 18:40:00 +0000)*
> *Test
Result*<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.b…
> 2 failed, 1 skipped
> Failed Tests *Test Name**Duration**Age* Manage Watchlist.Add an
> article to the
watchlist<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia…
37
>
sec1<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta…
Manage
> Watchlist.Remove an article from the
watchlist<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia…
38
>
sec1<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta…
All
> Tests *Package**Duration**Fail**Skip**Total*
(
root)<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.bet…
> min2161 Wikitext Editor (TEST RUN ON
WIKIPEDIA<https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia…
1
> min 14 sec003
>
--
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687