Looks like  jquery.accessKeyLabel now seems to be a required ResourceLoader module.

The patch that introduced it is https://gerrit.wikimedia.org/r/#/c/125426/ and this has exploded the mobile site with 49 or 50 tests failing since the merge.

I'm not quite sure whether this module is useful on mobile. I'm not judging that here - I just want to report this is a consideration.

Seems we have 2 options
1) Enable the module on mobile if it is applicable. If it's a small library maybe decide on whether it is important later.
2) Revert this core change and rethink this

We need to do _one_ of the above before the next deployment train.

The damage can be viewed at http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin - basically JavaScript exception.

Bug at https://bugzilla.wikimedia.org/show_bug.cgi?id=64512


On Sat, Apr 26, 2014 at 10:18 PM, <jenkins-no-reply@cloudbees.com> wrote:
FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome Build #409 (Sun, 27 Apr 2014 04:52:29 +0000)

Test Result

50 failed, 20 skipped

Failed Tests

Test NameDurationAge
Check UI components.Check existence of important UI components on other pages. 22 sec2
Encourage new users to Keep Going.I see a KeepGoing message after completing my VisualEditor edit 48 sec2
Encourage new users to Keep Going.I see a KeepGoing message after completing my edit 52 sec2
Generic special page features.Search from Login 39 sec2
Generic special page features.Search from Nearby 10 sec2
Generic special page features.Search from Uploads 2.2 sec2
Generic special page features.Search from Watchlist 38 sec2
Issues.Clicking page issues opens overlay 12 sec2
Issues.Closing page issues 12 sec2
Issues.Closing page issues (browser back) 13 sec2
Issues.I see the this page has issues stamp 5 sec2
Language Validation - Logged In.Validate Language selection availability 6.9 sec2
Language selection.Closing language overlay (browser button) 13 sec2
Language selection.Closing language overlay (overlay button) 14 sec2
Language selection.Opening language overlay 5.1 sec2
Lead image tutorial.See tutorial as new user 25 sec2
Lead image tutorial.There is an upload button 5.5 sec2
Lead image uploads.Opening upload preview 4 ms2
Loading pages.Edit button updates when lazy load a page from search 29 sec2
Loading pages.Page loads without ajax in stable 1 min 15 sec2
Manage Watchlist.Add an article to the watchlist 6.9 sec2
Manage Watchlist.Remove an article from the watchlist 35 sec2
Menus open correct page for anonymous users.Check links in menu 12 sec2
Menus open correct page for anonymous users.Check links in menu 0.7 sec2
Menus open correct page for anonymous users.Uploads URL is set correctly 9.2 sec2
Nearby pages.Nearby button visible 2 ms2
Notification.Opening notifications 4 ms2
Page actions menu when anonymous.Receive notification message - Edit Icon 5.2 sec2
Page actions menu when anonymous.Receive notification message - Upload Icon 13 sec2
Page actions menu when anonymous.Receive notification message - Watchlist Icon 14 sec2
Page actions menu when logged in.I can add the Main Page to my watchlist 30 sec2
Page actions menu when logged in.I can see the edit button on the Main Page 5.3 sec2
Page actions menu when logged in.I cannot upload a lead photo to the Main Page 27 sec2
Page diff.Added and removed content 31 sec2
Reference popup drawer.Closing the reference drawer 14 sec2
Reference popup drawer.Opening the reference drawer 13 sec2
Search.Opening search4 ms 2
Special:History.Check components in diff summary 4 ms2
Special:Uploads tutorial.Link to tutorial for new user 23 sec2
Special:Uploads uploads.Upload image file 20 sec2
Special:Uploads uploads.Upload image file of invalid format 19 sec2
Talk.Talk doesn't show on talk pages 3 ms2
Toggling sections.Closing a section 11 sec2
Toggling sections.Opening a section 5.1 sec2
VisualEditor.Switch from VisualEditor to source editor and back (with editor stickiness) 12 ms2
Wikitext Editor (Makes actual saves).Broken redirects 26 sec2
Wikitext Editor (Makes actual saves).Redirects 26 sec2
Wikitext Editor (Makes actual saves).Successful edit on page without languages shows no language button [bug 63675] 8.5 sec2
Wikitext Editor (Makes actual saves).Successful edit reloads language button 27 sec2
Wikitext Editor (TEST RUN ON WIKIPEDIA SO SHOULD NOT CAUSE SAVES).Opening editor 2 ms2

All Tests

PackageDurationFailSkipTotal
(root)17 min502083




--
Jon Robson
* http://jonrobson.me.uk
* https://www.facebook.com/jonrobson
* @rakugojon