Matt, I'm out of ideas off the top of my head, and nothing obvious is popping out to me looking at the patchset. Maybe you can pair with one of the mobile web engineers to get to the bottom of this - Max you interested (or have other ideas)? Alternatively, I can pair with you but don't have sufficient time til Thursday after 2pm PST.


On Tue, Nov 5, 2013 at 1:16 PM, Matthew Walker <mwalker@wikimedia.org> wrote:
Yep; still happens when I'm logged in.

Also of interest; requests to meta.wm.o are not always being redirected to meta.m.wm.o -- but that's probably not related.

~Matt Walker
Wikimedia Foundation
Fundraising Technology Team


On Tue, Nov 5, 2013 at 12:03 PM, Arthur Richards <arichards@wikimedia.org> wrote:
hrmph the only other thing I can think of off the top of my head is caching. do you notice the same bad behavior when you are logged in (to bust squid/varnish caching)?


On Mon, Nov 4, 2013 at 6:10 PM, Matthew Walker <mwalker@wikimedia.org> wrote:
"Are you seeing this behavior universally on the cluster, or only on specific wikis?"
*shrugs* I don't really have data on that. I can say that neither en.m.wp.o and de.m.wp.o are using mobile CN urls.

"Also, are you sure that you're getting into that if block (class_exists( 'MobileContext' ) is returning true) on the cluster?"
Yep; if you run mediaWiki.getConfig('wgNoticeHideUrls') you'll see that those URLs have mobile variants (on both the mobile and desktop sites.)

"when you test locally, do you have a value set in your config for $wgMobileUrlTemplate (eg %h0.m.%h1.%h2)?"
No; I'm just breakpointing through it and can see that shouldDisplayMobileView() is returning true.

~Matt Walker
Wikimedia Foundation
Fundraising Technology Team


On Mon, Nov 4, 2013 at 4:56 PM, Arthur Richards <arichards@wikimedia.org> wrote:
Are you seeing this behavior universally on the cluster, or only on specific wikis? Also, are you sure that you're getting into that if block (class_exists( 'MobileContext' ) is returning true) on the cluster?

And out of curiosity, when you test locally, do you have a value set in your config for $wgMobileUrlTemplate (eg %h0.m.%h1.%h2)?


On Mon, Nov 4, 2013 at 5:41 PM, Matthew Walker <mwalker@wikimedia.org> wrote:
Hey all,

Something you might have more instantaneous insight on than I.

I deployed a fix to CentralNotice today [1] that should have started serving mobile URLs for CN to mobile clients. It does this by querying MobileContext::singleton()->shouldDisplayMobileView() inside of the ResourceLoaderGetConfigVars hook. However, it appears that either... that function is returning false, or... getMobileUrl is not properly mangling URLs.

I suspect it's that the function is returning false because:
* I deployed a 'fix' earlier that just used getMobileUrl() which redirected everyone to the mobile URLs. And...
* There's a blob of code that I added in this patch that will always mangle URLs and it seems like that's working just fine.

I've tested on my local machine with MF loaded first, and MF loaded last and can not reproduce the cluster behaviour. So... thoughts?


~Matt Walker
Wikimedia Foundation
Fundraising Technology Team

_______________________________________________
Mobile-l mailing list
Mobile-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mobile-l




--
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr




--
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr




--
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687