Groovy thanks everyone!


On Thu, Feb 13, 2014 at 8:19 PM, James Forrester <jforrester@wikimedia.org> wrote:
Arthur,

This should now be fixed (I tested and was able to manually verify it working on that URL, as you can see).

Sorry for breaking VE in master; this Shouldn't Ever Happen™ and underlies our (already-acknowledged) need for a test suite for OOjs UI.

J.


On 13 February 2014 17:36, Arthur Richards <arichards@wikimedia.org> wrote:
Heh, thanks for spotting the issue so quickly and submitting a fix. Once merged, hopefully the test failures will disappear. Thanks again!


On Thu, Feb 13, 2014 at 5:43 PM, Trevor Parscal <tparscal@wikimedia.org> wrote:

I made a mistake in https://gerrit.wikimedia.org/r/#/c/113068/ which Roan gave the ol' +2. So, two points of embarrassing failure. Nice.

- Trevor


On Thu, Feb 13, 2014 at 4:30 PM, Roan Kattouw <rkattouw@wikimedia.org> wrote:

On Feb 13, 2014 4:28 PM, "Trevor Parscal" <tparscal@wikimedia.org> wrote:
>
> I could, but I'm having DNS issues. Basically, you need to update MediaWiki core, so you get the latest oojs-ui, which adds such support.
>
> In short - they are out of sync.
>
This is on beta labs, so while I suppose it's possible that things are out of sync there, it seems unlikely.

I'll take a look later today.

Roan





--
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr



--
James D. Forrester
Product Manager, VisualEditor
Wikimedia Foundation, Inc.

jforrester@wikimedia.org | @jdforrester



--
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687