Indeed. For clarity, here's how I prioritise the improvements I suggested:
- Improving the transition between night and day is "future release".
- Getting the panel design closer to the design spec is "second release" at worst, but ideally "first release".
- Removing the seizure-inducing transitions is "first release".
DanOn 10 July 2014 13:47, Dmitry Brant <dbrant@wikimedia.org> wrote:
The transition of closing and reopening the activity is, unfortunately, the only way to change themes in Android (the only relatively easy way, that is). The other way would be to manually iterate through every component in the activity, and set its color based on the selected theme. That would require significantly more code, and would create a lot more things to maintain and keep track of. If you're OK releasing it as-is for now, that would be preferable.
Getting the appearance closer to the design mockup is easily done. And I'll try to reproduce the seizure-inducing behavior (hopefully without any medical consequences).
-DmitryOn Thu, Jul 10, 2014 at 3:50 PM, Dan Garry <dgarry@wikimedia.org> wrote:
Oh, also, I think we need to work on the transition. There's an animation played when you change between night and day modes due to the app reloading the activity. This gives the impression of it loading a new page, which isn't the way the interaction should work here. This is done mostly for technical reasons, so I'm okay with it for now, but in the long run we need to iron out that too.Thanks guys!DanOn 10 July 2014 12:49, Dan Garry <dgarry@wikimedia.org> wrote:
I took a look at the APK. It looks pretty good! Some notes:
- I'd like to see the design for the selector get closer to the design that Vibha provided.
- There's a slight seizure-inducing moment when loading a new page in night mode; a white screen flashes at you during the transition. This needs ironing out.
DanOn 9 July 2014 14:45, Dmitry Brant <dbrant@wikimedia.org> wrote:
Sure, here's the APK:
https://releases.wikimedia.org/mobile/android/wikipedia/alphas/wikipedia_20140709.apk
The above uses the slightly-grey colors (instead of all black).On Wed, Jul 9, 2014 at 5:42 PM, Dan Garry <dgarry@wikimedia.org> wrote:
Thanks for the update Dmitry.From a high-level product standpoint I'm very happy with what I'm seeing in both of those screenshots. I probably slightly prefer the grey (the solid black looks a bit glossy on my tablet in experience, which defeats the point a bit), but it's primarily a design issue and I'll support their choice.Would you like some input from me before it hits the signoff column? I'm fine either way, but if you want some quick input from me on your work-in-progress build just send me an APK and I'll take a look. :-)Dan--On 9 July 2014 14:33, Dmitry Brant <dbrant@wikimedia.org> wrote:
Personally, the more I think about it, the more strongly I prefer the latter scheme (a slightly grey color that stands out from the black article background). I think black-on-black makes it look a little *too* minimalist.As opposed to:- Designers were entertaining the idea of having a single unified (black) color for the article background, as well as the ToC and Nav menu:Vibha and I met briefly today regarding the night-mode color scheme. The major points that were touched upon:- The color of links in night mode is a little too bright or "neon-y". Designers will come up with an updated (less saturated) blue color for links.
https://www.dropbox.com/s/5cci14w4qqx2isx/Untitled1.png
https://www.dropbox.com/s/oa7osa98x2rhbcn/Untitled2.png
-DmitryDan GarryAssociate Product Manager for Platform and Mobile AppsWikimedia Foundation--Dan GarryAssociate Product Manager for Platform and Mobile AppsWikimedia Foundation--Dan GarryAssociate Product Manager for Platform and Mobile AppsWikimedia Foundation--Dan GarryAssociate Product Manager for Platform and Mobile AppsWikimedia Foundation