I fixed it.Since yesterday Cloudbees has unexpectedly given us unlimited Jenkins build executors where before we could only run two builds at once. This has made for a few race conditions, of which this was one.This test should probably create a random page to use for clicking the watchlist on and off.-COn Wed, Mar 19, 2014 at 2:30 PM, Jon Robson <jrobson@wikimedia.org> wrote:
They are indeed false positives. I think I know what's happening here. Basically the tests are not atomic - they are trying to watch an article that is already watched and have the consequence of making that article watched. I have an idea of how to fix this.Does Watir have a concept of a tear down step?On Wed, Mar 19, 2014 at 1:45 PM, Arthur Richards <arichards@wikimedia.org> wrote:
I tested these manually and think they may be false positives, but can someone else take a look to make sure these tests and what's in betalabs is OK? We should get this resolved asap so we can be sure the state of things is healthy on betalabs for tomorrow's deployment.--On Wed, Mar 19, 2014 at 12:19 PM, <jenkins-no-reply@cloudbees.com> wrote:
FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox Build #434 (Wed, 19 Mar 2014 18:40:00 +0000)
Test Result
2 failed, 1 skippedFailed Tests
Test Name Duration Age Manage Watchlist.Add an article to the watchlist 37 sec 1 Manage Watchlist.Remove an article from the watchlist 38 sec 1 All Tests
Package Duration Fail Skip Total (root) 30 min 2 1 61 Wikitext Editor (TEST RUN ON WIKIPEDIA 1 min 14 sec 0 0 3
Arthur RichardsSoftware Engineer, Mobile[[User:Awjrichards]]IRC: awjr