Thanks to Siebrand, MobileFrontend code passes in PHP codesniffer. Jenkins
will now refuse to accept code which doesn't meet PHP codesniffer coding
standards.
To test locally in the MobileFrontend repository you can run `make phplint`
which will help you setup CodeSniffer with the correct configuration
options and report errors.
If you are using our pre-commit and pre-review hooks then any commit you
make will also check for errors thus no excuses for bad PHP code from now
on!
Thanks again to Siebrand for cleaning up our code so it passes and make
this possible. What a guy! :-)
In other news we have some other cool Makefile magic.
`make message` will provide a choose your own adventure type interface that
means you never need to edit i18n files again!
$ review/jdlrobson/bug/62553 x ~/Sites/w/extensions/MobileFrontend $ make
message
$ Choose a message key e.g. `mobile-frontend-xxx`:
$ mobile-frontend-hello
$ Creating new message with key `mobile-frontend-hello`
$ What is the message in English?:
$ Hello is it MobileFrontend you are looking for?
$ What is the description for this message (qqq)?
$ Message that appears when MobileFrontend feels like saying hello.
$ Saving English message...
$ Saving qqq message...
$ Done!
$ review/jdlrobson/bug/62553 x ~/Sites/w/extensions/MobileFrontend $ git
diff
diff --git a/i18n/en.json b/i18n/en.json
index 28ff2d7..337a8c3 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -99,6 +99,7 @@
"mobile-frontend-generic-login-action": "Log in to contribute.",
"mobile-frontend-generic-signup-action": "Sign up to contribute.",
"mobile-frontend-geonotahack": "Near this page",
+ "mobile-frontend-hello": "Hello is it MobileFrontend you are looking
for?",
"mobile-frontend-history": "View edit history of this page.",
"mobile-frontend-history-404-desc": "Cannot look at history for a page
that doesn't exist. It may have been deleted or you may have followed a bad
link.",
"mobile-frontend-history-404-title": "No such page",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 0ff47c0..8d3dd9c 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -123,6 +123,7 @@
"mobile-frontend-generic-login-action": "Call to action that follows
{{msg-mw|mobile-frontend-generic-login}} asking them to login.",
"mobile-frontend-generic-signup-action": "Call to action that follows
{{msg-mw|mobile-frontend-generic-login}} asking them to signup.",
"mobile-frontend-geonotahack": "Label for button that shows pages near
a given page.\n{{Identical|Near this page}}",
+ "mobile-frontend-hello": "Message that appears when MobileFrontend
feels like saying hello.",
"mobile-frontend-history": "Used as label for the link which points to
the \"Edit history\" page.\n\nThis is shown on the Main Page in place of a
last modified labe
"mobile-frontend-history-404-desc": "Explain the reasons why the user
may have arrived on {{msg-mw|mobile-frontend-history-404-title}}",
"mobile-frontend-history-404-title": "Title of the 404 error page
shown when navigate to [[Special:History/Title of page that does not
exist]]",
(END)