I am working to upgrade our site to 1.16.2. We have a number of minor mods (none of which have anything to do with Special:Preferences or Preferences.php) that I have now successfully working. However, the Preferences page is behaving weirdly. At the top, the tabbed preferences toc is doubled (i.e., it appears twice, one instance directly on top of the other). If I comment out the following line in prefs.js:
prefform.parentNode.insertBefore( toc, prefform.parentNode.childNodes [0] );
the duplicate tabbled toc goes away. Everything seems to work fine, but I don't like doing things I don't understand. (Plus, it seems that this would mean the function tabbedprefs() is unnecessary, which is a bit unsettling). Has anyone seen this behavior before? (I looked at Bugzilla, but found nothing that looked pertinent).
On Wed, 16 Feb 2011 01:17:41 +0000, Dan Nessett wrote:
I am working to upgrade our site to 1.16.2. We have a number of minor mods (none of which have anything to do with Special:Preferences or Preferences.php) that I have now successfully working. However, the Preferences page is behaving weirdly. At the top, the tabbed preferences toc is doubled (i.e., it appears twice, one instance directly on top of the other). If I comment out the following line in prefs.js:
prefform.parentNode.insertBefore( toc, prefform.parentNode.childNodes [0] );
the duplicate tabbled toc goes away. Everything seems to work fine, but I don't like doing things I don't understand. (Plus, it seems that this would mean the function tabbedprefs() is unnecessary, which is a bit unsettling). Has anyone seen this behavior before? (I looked at Bugzilla, but found nothing that looked pertinent).
I worked on this for hours with no success. As soon as I posted this message, I found the problem. RunOnLoadHook() in MediaWiki:Common.js had a direct call to tabbedprefs and prefs.js called addOnloadHook ( tabbedprefs ). So, tabbedprefs was called twice.
mediawiki-l@lists.wikimedia.org