Hey, I had a quick look at this extension and have some suggestions: * Escape ALL variables in HTML you are building. You can use htmlspecialchars, the methods of MediaWikis HTML class, and in this case probably want to just construct the whole thing with XmlSelect. * You are not fully following the style guidelines. The spacing is off and you are using underscores in var names instead of lowerCamelCase. See http://www.mediawiki.org/wiki/Manual:Coding_conventions * Don't use the 'description' in wgExtensionCredits, use 'descriptionmsg' instead, and properly internationalize it. Next to that it looks great, although I'm not completely sure the i18n is all in order when using the native PHP time functions :)

There already is such unit conversion code. In parserFunctions extension IIRC :)

We actually already have some plans on how to handle this case: The intent is to support the html5 <time> element. - <time> will be allowed in WikiText. - When a certain attribute is specified time will automatically be localized by JS using the user's preferences, a cookie, or their browser settings. - We will have a parser function that formats time into contentlang and outputs a <time> with said attribute. Relevant bugs: - https://bugzilla.wikimedia.**org/show_bug.cgi?id=32545<https://bugzilla.… MediaWiki should support <time> in WikiText - https://bugzilla.wikimedia.**org/show_bug.cgi?id=19992<https://bugzilla.… Support client-side date/time formatting for user's local timezone (JavaScript) - https://bugzilla.wikimedia.**org/show_bug.cgi?id=30857<https://bugzilla.… Requesting more user-friendly timestamps I've introduced a changeset that adds support for <time> in WikiText: - https://gerrit.wikimedia.org/**r/#change,4251<https://gerrit.wikimedia.o… I also wrote some code for parsing the datetime="" of a <time> element. The next step would probably be porting our Language::sprintfDate and other date related methods to our JS mw.language system. After that we'd incorporate it into the jQuery.fn.formatTime code I also have partially written. And start handling the preferences and cookies. Then we'd probably add in the parser function and relative time code. When we're done with that stuff we can probably come up with a good user interface to make out of that. Here's my thought on that right now: - The timezone portion of the output becomes a stylized button (probably not directly <button> but a css style that's button-ish) - Clicking on the button brings up a timezone map (a nice intuitive one with a real map) - When you change the timezone it will either use the api to change your user preference or set either a localStorage key or cookie (cookies have the domain advantage, while localStorage has the "not sending pointless cookies" and StorageEvent advantages). We'll also want to come up with a good switching ui for https://bugzilla.wikimedia.**org/show_bug.cgi?id=30857<https://bugzilla.… -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ______________________________**_________________ MediaWiki-l mailing list MediaWiki-l(a)lists.wikimedia.**org &lt;MediaWiki-l(a)lists.wikimedia.org&gt; https://lists.wikimedia.org/**mailman/listinfo/mediawiki-l<https://lists…