I can't seem to get rid of the following errors for my users.
Strict Standards: Non-static method AntiBot_GenericFormEncoding::onEditFilterMerged() cannot be called statically in /var/www/elinux.org/includes/Hooks.php on line 129
Strict Standards: Non-static method AntiBot_GenericFormEncoding::onEditFilterMerged() cannot be called statically in /var/www/elinux.org/includes/Hooks.php on line 131
Strict Standards: Non-static method AntiBot_GenericFormEncoding::onEditFilterMerged() cannot be called statically in /var/www/elinux.org/includes/Hooks.php on line 133
Hooks.php: 129: // Run autoloader (workaround for call_user_func_array bug) 130 is_callable( $callback ); 131 132 /* Call the hook. */ 133 wfProfileIn( $func ); 134 $retval = call_user_func_array( $callback, $hook_args ); 135 wfProfileOut( $func );
What bug is this workaround referring to? I searched Bugzilla for "call_user_func_array" but didn't find anything. Do I simply need to Upgrade?
Thanks.
On Sat, Jun 25, 2011 at 8:11 AM, Bill Traynor btraynor@gmail.com wrote:
I can't seem to get rid of the following errors for my users.
Strict Standards: Non-static method AntiBot_GenericFormEncoding::onEditFilterMerged() cannot be called statically in /var/www/elinux.org/includes/Hooks.php on line 129
The problem is with AntiBot, not with Hooks.php. If you apply the fix in r90770 [0] to your filter, you should be fine.
-Chad
[0] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90770
On Sat, Jun 25, 2011 at 11:14, Chad innocentkiller@gmail.com wrote:
On Sat, Jun 25, 2011 at 8:11 AM, Bill Traynor btraynor@gmail.com wrote:
I can't seem to get rid of the following errors for my users.
Strict Standards: Non-static method AntiBot_GenericFormEncoding::onEditFilterMerged() cannot be called statically in /var/www/elinux.org/includes/Hooks.php on line 129
The problem is with AntiBot, not with Hooks.php. If you apply the fix in r90770 [0] to your filter, you should be fine.
Thanks, Chad!
-Chad
[0] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90770
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-l
On 25/06/11 22:11, Bill Traynor wrote:
Hooks.php: 129: // Run autoloader (workaround for call_user_func_array bug) 130 is_callable( $callback ); 131 132 /* Call the hook. */ 133 wfProfileIn( $func ); 134 $retval = call_user_func_array( $callback, $hook_args ); 135 wfProfileOut( $func );
What bug is this workaround referring to? I searched Bugzilla for "call_user_func_array" but didn't find anything. Do I simply need to Upgrade?
The bug was in PHP, not MediaWiki.
Running the autoloader to resolve a class in call_user_func_array() had at least one bug in it, possibly two. The known bug is that there was a failure to expand an internal stack to allow enough space for the autoloader call to take place, which occasionally led to a crash, depending on stack depth and execution history.
We also saw a crash in very similar circumstances in a PHP version where that bug was supposedly fixed. Both issues were observed in PHP 5.1.x, they're probably fixed in PHP 5.2.x. I don't think we've seen any call_user_func_array() crashes since we switched to PHP 5.2.4.
-- Tim Starling
On Sun, Jun 26, 2011 at 20:35, Tim Starling tstarling@wikimedia.org wrote:
On 25/06/11 22:11, Bill Traynor wrote:
Hooks.php: 129: // Run autoloader (workaround for call_user_func_array bug) 130 is_callable( $callback ); 131 132 /* Call the hook. */ 133 wfProfileIn( $func ); 134 $retval = call_user_func_array( $callback, $hook_args
);
135 wfProfileOut( $func );
What bug is this workaround referring to? I searched Bugzilla for "call_user_func_array" but didn't find anything. Do I simply need to Upgrade?
The bug was in PHP, not MediaWiki.
Running the autoloader to resolve a class in call_user_func_array() had at least one bug in it, possibly two. The known bug is that there was a failure to expand an internal stack to allow enough space for the autoloader call to take place, which occasionally led to a crash, depending on stack depth and execution history.
We also saw a crash in very similar circumstances in a PHP version where that bug was supposedly fixed. Both issues were observed in PHP 5.1.x, they're probably fixed in PHP 5.2.x. I don't think we've seen any call_user_func_array() crashes since we switched to PHP 5.2.4.
FWIW, elinux.org is running PHP version 5.2.14-pl0-gentoo (apache2handler)
I'll nag the OSUOSL folks to upgrade soon.
-- Tim Starling
MediaWiki-l mailing list MediaWiki-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-l
mediawiki-l@lists.wikimedia.org