On 25/9/20 10:56 am, Jeffrey Walton wrote:
Thanks.
Out of curiosity, why is "unknown" used instead of "localhost"? localhost is a standard hostname. Are there negative side effects from using localhost?
It's just used for debugging, so it doesn't matter if it's a standard hostname. "Unknown" at least tells us that the host is unknown, whereas "localhost" might be misleading.
You can set $wgOverrideHostname to whatever you like, it doesn't need to be resolvable.
I don't know why it needs to be called on every request. I see that it is passed from MWLBFactory::applyDefaultConfig() to LBFactory and then LoadBalancer, but LoadBalancer just stores it in a private property and never touches it again. Maybe there was previously a log entry that used it, but it's gone now.
-- Tim Starling