---------- Forwarded message ----------
From:
Erik Bernhardson <ebernhardson@wikimedia.org>
Date: Wed, Oct 2, 2013 at 10:36 AM
Subject: [E2] i18n messages
To: E2 development team <
e2@lists.wikimedia.org>
I've noticed a recurrence of git reviews about missing i18n documentation, to help solve these up front we could add a hook to git review (or git commit if you prefer) that checks this at a basic level for us.
In .git/hooks/pre-review put the following:
// This file must have the executable flag set to work as a hook
// A hooks path is always /path/to/repo/.git/hooks/hook-name
$repo = dirname( dirname( dirname( realpath( $argv[0] ) ) ) );
include "$repo/Flow.i18n.php";
$missing = array_diff( array_keys( $messages['en'] ), array_keys( $messages['qqq'] ) );
if ( $missing ) {
echo "Missing i18n messages:\n\t" . implode( "\n\t", $missing ) . "\n";
exit( 1 );
}
chmod +x the new file, and anytime you do a git review with missing qqq it should say:
git review
Custom script execution failed.
The following command failed with exit code 255
"/home/guy/Jobs/mediawiki/vagrant/mediawiki/extensions/Flow/.git/hooks/pre-review"
-----------------------
Missing i18n messages:
flow-post-action-censor-post
-----------------------
Relatedly, there is a new patch in gerrit to fix that missing message that made it through review.
Erik B.
_______________________________________________
E2 mailing list
E2@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/e2