On Fri, Mar 22, 2013 at 6:52 AM, Brad Jorsch <bjorsch@wikimedia.org> wrote:
On Thu, Mar 21, 2013 at 10:15 PM, Jiang BIAN <bianjiang@google.com> wrote:
Our code hardcoded "rcstart" in both string value and C++ class member name. This change is really a breaking one to us.

Could you tell me when this is released to *wiki?

The change is coming with 1.21wmf12. Due to a major bug in that release, I don't know when it will be deployed anywhere besides test2wiki.
Can I understand that once the bug is fixed on test2wiki, it will be deployed to *wiki and other media wiki sites immediately? or is it released on a regular base (e.g. 2 weeks later? - in this case, it means we have at least 2 weeks to fix our code)

And when deploying the new release, is it done to all sites at once or one-by-one in a release window? (if the release proces last for a while, e.g. 1-2 days, our change need to handle both new style and old style, right?)

Note that the "rcstart" parameter is not going away. It's just that the query-continue will start using "rccontinue" as a key rather than "rcstart". For the moment, you can compare [1] and [2] to see the difference.

 [1]: https://en.wikipedia.org/w/api.php?action=query&list=recentchanges&rclimit=1
 [2]: https://test2.wikipedia.org/w/api.php?action=query&list=recentchanges&rclimit=1

Here is more background of our broken:
(sadly) our code DO look into both the value of "rcstart" (e.g. "2013-03-23T02:53:28Z") and the attribute name itself ("rcstart"). Now I understand we should not do that.

But it is not easy for us to have a quick fix this time, the parsing of XML is done by another library which is much older, and hard to change. 

To have a complete fix (I mean respect the spec, not looking into the attribute names or values), we need 1-2 weeks at least. So I'd prefer a quick fix if something still works.

It looks to me I can still sends out rcstart by strip the "|?????" from rccontinue value:
e.g. https://test2.wikipedia.org/w/api.php?action=query&list=recentchanges&rclimit=1&rcstart=2013-03-22T23:30:23Z

Could you confirm this is what I can expect with the release of 1.21wmf12?



Brad Jorsch
Software Engineer
Wikimedia Foundation

Mediawiki-api mailing list

Jiang BIAN

This email may be confidential or privileged.  If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it went to the wrong person.  Thanks.