*Erik*:
Found a couple bugs with LQT --- topics were being shown with time title
was edited, not created.
Today -- more LQT action. Figuring out the timestamp issues, and testing
the script.
Nick/Andrew have been talking on IRC about a concern about deleted LQT
posts not showing up in the history. There's a question about whether
leaving LQT pages still existing on the wiki, we're going to see every post
show up twice in people's contributions list.
*Shahyar*:
Got a few fixes in for ToC bugs.
Concerned about the approach to what happens when you jump to a later spot
on the page.
There are still some problems with the basic functionality of loading the
topic list, and scrolling to the right place on the page. Shahyar will
reach out to Matt today to discuss current roadblocks.
*Matt*:
Yesterday: Reviewed ToC code, made small fix to collapse patch.
Started reviewing Matthias' event-logging patch (L1). Suggested an
alternative approach that would deal with some performance issues.
Today: work on FlowMenu event-logging (L3), shouldn't be miuch rebasing to
make it consistent with L1.
After that, back to code review on ToC.
*Bug review*:
73477 -- Amir flagged this, it's an internationalization problem we should
fix.
73455 -- Antoine flagged. Matt isn't sure what Antoine means by MediaWiki
skin.
73451 -- QA browser tests for collapse are failing. S will review, and get
back to Chris.
73447 -- Nick -- should be fixed with K2, which just got bounced back from
product review to Blocked with questions.
73443 -- fatal exceptions for subpages in the Topic namespace.
Matthias is recovering from jet lag. :)
*Matt*:
Followed up on css Janus from story estimation
Reviewing J2a - fixed board navigation
Review text area expland/collapse patch
Today: start on L3 - event-logging for FlowMenu
*Sjhahyar*:
Updated Flow-tests with the latest ToC patch, not sure why it's going so
awry.
The way we're inserting the topics, and loading -- concerned that he's in
too deep with this problem.
Discussion about how we can help -- Matt and Danny will meet with Shahyar
after standup.
*Erik*:
More bug with Echo on PT wiki. They use parentheses in namespaces, which is
unusual. We fixed that one, and another came up about long signatures
(73366). Erik fixed that Friday, probably swat deploy today.
Code review -- getting frustrated with qunit. Krinkle agreed to allow us
increase timeout to 30 seconds. S asks: are other teams running into the
same problem?
LQT -- there's a test on ee-flow, it's test #42.
Today -- reviewing Andrew's LQT patch.
Matthias is on a plane going home today.
*Matt*:
Clean-up for LQT header conversion (L9), in code review
S will follow up with questions
A couple hygiene patches
Next -- not sure? Can he help with the LQT script? We're not sure what
Andrew's doing.
*Matthias*:
Worked on Event-logging (L1) -- it's WIP, but it would be good for Matt to
review the approach. One question -- When you start to reply, it'll fetch
the handlebar template & compile it -- there's a slight delay. Not certain
of the approach there; it may break on really slow JS or slow machines.
Will still be working on that today. By the end of the day, card should be
pretty much ready.
One question -- right now, it'll only log things with JS, the no-JS case
isn't covered. Is that something we want to do? (No for now -- it can be
done as a v2 if we need it.)
This should be ready to start running next week.
*Erik*:
Yesterday -- fixed up LQT conversion script. Andrew had added features, but
hadn't made
Added transactionality.
More bugs -- we're being too lenient with users. We're testing by going
from one wiki to another, shouldn't be a problem in real use cases.
Script is back into a working condition. Successfully importing everything
again. Looks to be mostly there.
J16 is close, and it is now preserving history (L6).
What's left is mostly the redirects (L8). Could we possibly defer until we
go bigger than OfficeWiki? (yes, let's put it off until it gets to
TranslateWiki or another heavy-use wiki.)
There's also a bug for Echo - mention notifications on PTwiki.
S asks about L2 -- Collect usage data on current Flow deployments. We could
start getting data pretty quickly. Erik will pick it up and get started on
it.
*Shahyar*:
ToC: Working on 5 things we talked about yesterday -- 4 out of 5 are done,
still working on scrolling to the right place in the ToC dropdown. This
should be finished today. Danny wants to see the ones that are done on
flow-tests.
All ToC patches that don't say WIP will be good for review.
*Shahyar*:
5 changes that we asked for on ToC are not posted on flow-tests yet.
Still working on splitting up the giant ToC WIP patch, to split it up for
code review.
*Erik*:
Yesterday, fixed the Echo bug on PT wiki (73366), got deployed last night.
Working on LQT -- it's only importing the latest version of the topic
title, because LQT only keeps the latest title. This is acceptable.
Merged the header import, to retain the wikitext and not duplicate the
contributions.
Everything stops indenting at 3 levels.
All J16 tasks (LQT conversion basics) are checked off; we're ready to test
it out.
Today -- has to make some changes to a patch in core on autoload
auto-generation.
Testing LQT: We'll import a big set of pages from Mediawiki to ee-flow.
*Matthias*:
Yesterday -- L1 Event-logging -- had a problem with the click in the bottom
text field, which uses focus instead of a click. A patch changing the way
that field works is up for people to review.
Today - continuing work on L1. JS actions need to be logged: confirm/abort
cancel.
*Matt*:
Yesterday -- investigated possible problem with Parsoid change.
Talked to Erik about qunit failures, will take a look at it today.
Today -- code review on the ToC stack, and the event-logging.
We had most cards estimated, so it was mostly planning and review. The
highest priority remains completing TOC.
LQT conversion:
* Want to have some user-visible record of the conversion.
** S wants the raw JSON log on the wiki, Matt wonders why, ErikB thinks
we can post-process the raw JSON log into something nicer
* Do we want the Flow board to link to the archived LQT page? No,the old
LQT page exists primarily so you can get the pre-Flow history of its
wikitext edits.
We'll write up how the conversion works on mediawiki.org, first cut is
https://www.mediawiki.org/wiki/Flow/Converting_LiquidThreads
Flow on officewiki:
4 steps:
* Flow working (wmf8 deploys to officewiki Tuesday morning)
* run LQT conversion, maybe Wednesday
* convert one namespace to Flow
** Would be nice to have PHP scripting for the archiving of regular Talk
pages ready for this.
* convert the rest to Flow
Search:
* A lot of back-end work needed, especially in "monolithic CirrusSearch
maintenance script". Matthias will file a bug(s) for CirrusSearch changes
and propose patches for it.
* Matthias has enough Flow search API code to work on showing search
results on a Flow board, but we won't estimate until we have basic search
wireframing from Pau.
Cheers,
--
=S Page Features engineer
We have 4 3/4 engineers, even with SF office closed for Veterans Day on Nov
11 we should achieve great things.
Obviously the board TOC is highest priority. Shahyar will have a version of
J2b "Opening the ToC dropdown" by Friday. flow-tests
<http://flow-tests.wmflabs.org/wiki/Talk:Sandbox> is running the gerrit
patches for a fixed header that shows the current topic title.
Pau Giner is in SF starting Monday and we will use his every waking hour :)
for TOC review and search UX design.
Other themes for the sprint are
* analytics (usage queries and event logging)
* Flow on all officewiki talk pages
* convert LQT pages to Flow
On analytics, we met with Dan Andreescu who's already set up a lot of
infrastructure \o/ We have a web site http://flow-reportcard.wmflabs.org/#
and patches in process that will let us commit queries to a limn-flow-data
repository
<https://gerrit.wikimedia.org/r/#/q/project%3Aanalytics/limn-flow-data,n,z>
that will generate dashboard graphs. More in
https://www.mediawiki.org/wiki/Flow/Analytics
Rather than do a hacky conversion of officewiki's 10 LQT pages, we'd like
all the features of LQT->Flow conversion implemented so the script is ready
to (eventually) run on the other 12 LQT wikis, some with thousands of LQT
pages . One feature we have to defer is programmatically enabling Flow on a
converted LQT page; doing that properly by changing content format to
'flow-board' is a separate task that requires on $wgContentHandlerUseDB =
true, which is blocked by security bug 70901.
We will have a meeting to triage Flow & Echo bugs soon.
Team <3
--
=S Page Features engineer
Danny out, Matthias is in S.F. (calendar updated), Andrew joined from
somewhere in Europe!
Andrew: available! working on LQT conversion, adding edit history.
ErikB:
* DB changes required for content length bug are in.
* Parsoid team is changing links to absolute, not relative, also missing
image representation, he has patches for this.
* Needs to upload patch for K4 (new topic Special:Notifications links). The
patch adds a direct link, but having the primary link working in general on
Special:Notifications page needs design.
** We think users are viewing Special:Notifications more than expected
because the JS for the flyout takes time or doesn't load.
* K2 timestamps: will e-mail i18n mailing list.
MattF:
* J2f finally passing, wrote Flow's first API PHPUnit tests. This patch is
OK to merge once the code freeze is over since it has no user-visible
effect.
Shahyar:
* Now working on J2b (show TOC). It uses flow-menu code to show TOC, for
now..
* Will upload new stack of patches for J2a, J2d, ...
* Had to re-jigger the functionality in J2d to jump to a topic. Has UX
concerns about jumping to topic with gaps above, will send e-mail to list
once patches are up.
Matthias:
* travelling yesterday, here in SF! He took on Release Readiness Review
Ranger role, already noticed new replies on beta don't show up in another
anonymous user's session.
--
=S Page Features engineer
*Erik*:
worked mostly on LQT conversion script -- tests are passing
still not seeing every topic -- trying to figure out why. that's the last
major bug
will figure it out today.
*Matthias*:
Monday - worked on contributions issue. Most of that day was event-logging
L1
fix small issues with K2
start doing event-logging for the rest of the day
has questions, we'll talk
*Matt*:
has had some sick time
today -- workign on LQT conversion for page header -- L9
code review
*Shahyar*:
updated ToC stuff, have more updates to put up after this call
currently ToC on ee-test, needs to be updated with latest patch
there are a couple obvious bugs
Matt says -- it's 9 patches deep -- how should we do code review?
Shahyar needs to split up the biggest one -- J2d. That's marked WIP, but
others should be fine to review.
Matt on vacation today and tomorrow.
Danny will be out Friday and Monday.
*Shahyar*:
ToC is on track for tomorrow, he'll have something to show later tonight
Will put the patch up, and on Flow-test
*Matthias*:
Merged a bunch of code. A lot of +1, merged and rebased.
Worked on bug 70497 -- "this topic has been deleted" message if you don't
have permission to see it, in code review. It was two patches conflicting.
There was also another bug that if you moderated something and then logged
out, it would show an error.
Today -- Erik wants review on fix for intermittent test failures.
*Erik*:
fixed bug 59138 (extra characters in byte count) -- in code review.
Did review on LQT import script -- there's still one tweak that needs to be
made, setting transaction
Plan is to merge J16 (LQT conversion basics), then other sprint L patches
will be added on top of that.
After that -- work on more LQT cards.
*S*:
For Analytics -- Dan has all the pieces we need. We need to set up the
interface.
Does event logging work on beta? Erik says we'll have to look.
Alternative: Have event logging just write to a file.
We're close to being able to try it out interactively.
*Bug review*:
73074 -- PHP fatal error on watchlist. Erik has figured this out. It's
happening for people watchlisting boards when there's a header edit. This
is very critical. HHVM has an option to turn these into non-fatals,
throwing an exception rather than fatal. We should talk to Ops about adding
this. Swat deploy.
73065 -- Erik checked database, out of 50k posts, there are maybe 750 that
have bad data. Making a script to fix it. Fairly high priority. Swat deploy
for database fix and cache invalidation.
My update is:
Continued working on ViewTopicList.
I finished writing the tests, and they are all passing locally when just
that class is run.
However, they don't on Jenkins, so I'm working on that. I've built PHP
5.3.29 from source (as close as I could find to 5.3.10, which Jenkins
runs), and I'm trying to also use Jenkins' version, 3.7.37, or close enough.
I also realized that I didn't try running the full test suite locally,
so that might be the problem. I'll do that today.
Matt