On Mon, Sep 1, 2014 at 1:05 PM, Jon Robson <jrobson@wikimedia.org> wrote:

This patch [1] corrects the colours. Code review welcomed.
This patch [2] swaps the alignment.

I've -2ed the 2nd patch. Let me know how you want to proceed with that.

Jon

[1] https://gerrit.wikimedia.org/r/157709
[2] https://gerrit.wikimedia.org/r/157709

small correction
[2] should be https://gerrit.wikimedia.org/r/#/c/156838/

-

Regarding the Special:Preferences page, could we consider putting the Save button at the top-right of the box, instead?

There are many users who are used to the modern systems like Gmail - where no manual "save" is needed, but instead happens automatically when anything is changed - and are liable to miss the Save button anywhere at the bottom, especially on longer preference pages.

In the RfC for userpreferences, I'd suggested that "The [Save button] is always visible/nearby" should be a high-priority goal. (Or, upgrading to an auto-save system). [1]
Having it at the top of the window would be ideal, and possibly even top and bottom, like so:
https://i.imgur.com/4Mu9UdQ.png

[1] https://www.mediawiki.org/wiki/Requests_for_comment/Redesign_user_preferences#High-level_requirements