On bug 65317 [1] it is suggested that the preferences page should have
buttons aligned to the right and should be ordered so constructive is
the last. I've written a fix for this and I would appreciate some code
review.
This had me wondering, should this apply to all forms? e.g. the editing form
If so I think we probably need to get this into the style guide in
some form, detailing how buttons should be ordered. We may want to
introduce mw-ui-button-group or mw-ui-form-button-group.
I think before we make a decision we need to think this through, by asking two questions:
1. What do most users expect here, in terms of ordering? If we don't know, how can we learn what they do expect?
2. If users expect the primary action to be on the right, how would this change core forms other than Preferences, such as signup, login, editing (in wikitext and VE)?
In the mean time, the simplest thing to do is not to rewrite Preferences to make a new divergent standard, but just update the button classes without mucking with the ordering. That's the minimum viable release for updating Preferences to match mw.ui styles. This will provide the most benefit with the least effort.