A delay is certainly possible. I don’t want to hold things up too long on the other end of production, of course.If I roll the change back, temporarily, in puppet, then we could still provide fixes and things without the table changes during the interim. I’d rather not leave it staged and unapplied for too terribly long.As I said, the _compat tables are there to provide a quick fix where possible, and it should be noted that those fields are currently blank (or filled in by the compat tables). This will break things that explicitly reference the fields, though.I can give it another week, I think, if that helps._______________________________________________
On Mar 7, 2019, at 10:10 AM, John <phoenixoverride@gmail.com> wrote:Any chance we can delay the rollout of this? I suspect that this will break a number of tools, mine included. Giving just a week is kinda short notice._______________________________________________On Thu, Mar 7, 2019 at 11:59 AM Jaime Crespo <jcrespo@wikimedia.org> wrote:On Thu, Mar 7, 2019 at 5:14 PM Brooke Storm <bstorm@wikimedia.org> wrote:
> but it is recommended that comment references use a join to the new comment table on a “comment_id” field instead where possible.
I would like to insist in this part- the change wasn't made to annoy
users- we tried to provide compatibility where possible, but some
tools users observed reduced performance if something more complex
than a point select was being used, so we encourage to use the
non-compat ones for performance reasons when possible. Sorry for the
inconveniences- unlike an API, while we are happy to provide access to
the internal database format, we cannot always guarantee to be stable
over the years.
--
Jaime Crespo
<http://wikimedia.org>
_______________________________________________
Wikimedia Cloud Services mailing list
Cloud@lists.wikimedia.org (formerly labs-l@lists.wikimedia.org)
https://lists.wikimedia.org/mailman/listinfo/cloud
Wikimedia Cloud Services mailing list
Cloud@lists.wikimedia.org (formerly labs-l@lists.wikimedia.org)
https://lists.wikimedia.org/mailman/listinfo/cloud
Wikimedia Cloud Services mailing list
Cloud@lists.wikimedia.org (formerly labs-l@lists.wikimedia.org)
https://lists.wikimedia.org/mailman/listinfo/cloud