Hey,
As part of ongoing cleanup and debugging of varnishncsa, part of the Varnish toolset for udp logging of access requests, I'm removing our custom code for escaping spaces in headers. Since we've now switched to using tabs as field separators, this shouldn't be necessary anymore.
Please let me know if there are any objections - if not I'll deploy this change in the next couple of days.
I am in total favor of this! In fact we have it on our todo list: https://mingle.corp.wikimedia.org/projects/analytics/cards/288
Best, Diederik
On Wed, Mar 20, 2013 at 1:12 PM, Mark Bergsma mark@wikimedia.org wrote:
Hey,
As part of ongoing cleanup and debugging of varnishncsa, part of the Varnish toolset for udp logging of access requests, I'm removing our custom code for escaping spaces in headers. Since we've now switched to using tabs as field separators, this shouldn't be necessary anymore.
Please let me know if there are any objections - if not I'll deploy this change in the next couple of days.
-- Mark Bergsma mark@wikimedia.org Lead Operations Architect Wikimedia Foundation
Analytics mailing list Analytics@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/analytics
Update to my previous email:
I am in total favor of this! In fact we have it on our todo list: https://mingle.corp.wikimedia.org/projects/analytics/cards/288 Mark can you confirm that we can take it of our list?
Best, Diederik
On Wed, Mar 20, 2013 at 1:12 PM, Mark Bergsma mark@wikimedia.org wrote:
Hey,
As part of ongoing cleanup and debugging of varnishncsa, part of the Varnish toolset for udp logging of access requests, I'm removing our custom code for escaping spaces in headers. Since we've now switched to using tabs as field separators, this shouldn't be necessary anymore.
Please let me know if there are any objections - if not I'll deploy this change in the next couple of days.
-- Mark Bergsma mark@wikimedia.org Lead Operations Architect Wikimedia Foundation
Analytics mailing list Analytics@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/analytics
On Wed, Mar 20, 2013 at 1:12 PM, Mark Bergsma mark@wikimedia.org wrote:
Hey,
As part of ongoing cleanup and debugging of varnishncsa, part of the Varnish toolset for udp logging of access requests, I'm removing our custom code for escaping spaces in headers. Since we've now switched to using tabs as field separators, this shouldn't be necessary anymore.
Please let me know if there are any objections - if not I'll deploy this change in the next couple of days.
Hey Mark,
Has this already happened or shall I open an RT ticket for it?
Best, Diederik
On Monday, April 15, 2013 at 11:43 AM, Diederik van Liere wrote:
Has this already happened or shall I open an RT ticket for it?
Already happened, AFAIK:
https://gerrit.wikimedia.org/r/#/c/55558/
https://gerrit.wikimedia.org/r/#/c/55568/
-- Ori Livneh
Awesome! ty Ori D
On Mon, Apr 15, 2013 at 3:02 PM, Ori Livneh ori@wikimedia.org wrote:
On Monday, April 15, 2013 at 11:43 AM, Diederik van Liere wrote:
Has this already happened or shall I open an RT ticket for it?
Already happened, AFAIK:
https://gerrit.wikimedia.org/r/#/c/55558/
https://gerrit.wikimedia.org/r/#/c/55568/
-- Ori Livneh
Analytics mailing list Analytics@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/analytics
As a note, we *do* need to start escaping tabs. I've already encountered a small number in the mobile stream.
-- David Schoonover dsc@wikimedia.org
On Mon, Apr 15, 2013 at 12:31 PM, Diederik van Liere < dvanliere@wikimedia.org> wrote:
Awesome! ty Ori D
On Mon, Apr 15, 2013 at 3:02 PM, Ori Livneh ori@wikimedia.org wrote:
On Monday, April 15, 2013 at 11:43 AM, Diederik van Liere wrote:
Has this already happened or shall I open an RT ticket for it?
Already happened, AFAIK:
https://gerrit.wikimedia.org/r/#/c/55558/
https://gerrit.wikimedia.org/r/#/c/55568/
-- Ori Livneh
Analytics mailing list Analytics@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/analytics
Analytics mailing list Analytics@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/analytics
Abridged timeline:
On Saturday, January 26, 2013 at 11:13 PM, Ori Livneh wrote:
I don't think means you have to ditch tabs -- I doubt there's a problem-free delimiter. But you should write code and configure software with the expectation that literal tabs will be encountered so that you can deal with it gracefully.
On Saturday, January 26, 2013 at 12:57 PM, Diederik van Liere wrote:
Now there could be a tab in a header value as well but I have never seen it in our logfiles and i also grepped for it on a couple of random files and found no such occurrences. So we are not going to escape tab characters in fields unless new information changes our mind.
On Sunday, January 27, 2013 at 5:07 AM, Erik Zachte wrote:
If we bet tabs will never be introduced in the input stream, even where they are legal, and we take that approach on several issues, one of those unlikely events will surely happen sooner than you think
On Monday, April 15, 2013 at 3:12 PM, David Schoonover wrote:
As a note, we *do* need to start escaping tabs. I've already encountered a small number in the mobile stream.
On Mon, Apr 15, 2013 at 6:30 PM, Ori Livneh ori@wikimedia.org wrote:
Abridged timeline:
On Saturday, January 26, 2013 at 11:13 PM, Ori Livneh wrote:
I don't think means you have to ditch tabs -- I doubt there's a
problem-free
delimiter. But you should write code and configure software with the expectation that literal tabs will be encountered so that you can deal
with it
gracefully.
On Saturday, January 26, 2013 at 12:57 PM, Diederik van Liere wrote:
Now there could be a tab in a header value as well but I have never seen
it in
our logfiles and i also grepped for it on a couple of random files and
found no
such occurrences. So we are not going to escape tab characters in fields
unless
new information changes our mind.
On Sunday, January 27, 2013 at 5:07 AM, Erik Zachte wrote:
If we bet tabs will never be introduced in the input stream, even where
they
are legal, and we take that approach on several issues, one of those unlikely events will surely happen sooner than you think
On Monday, April 15, 2013 at 3:12 PM, David Schoonover wrote:
As a note, we *do* need to start escaping tabs. I've already encountered a small number in the mobile stream.
:) Erik just leveled up his future-telling powers