No longer escaping spaces in HTTP headers of udplogging

List overview All Threads
Download

newer

older

Reportcard question

Do we need a umapi-alerts list?

Mark Bergsma

20 Mar 2013 20 Mar '13

6:12 p.m.

Hey, As part of ongoing cleanup and debugging of varnishncsa, part of the Varnish toolset for udp logging of access requests, I'm removing our custom code for escaping spaces in headers. Since we've now switched to using tabs as field separators, this shouldn't be necessary anymore. Please let me know if there are any objections - if not I'll deploy this change in the next couple of days. -- Mark Bergsma <mark(a)wikimedia.org> Lead Operations Architect Wikimedia Foundation

Show replies by date

Diederik van Liere

20 Mar 20 Mar

6:20 p.m.

New subject: No longer escaping spaces in HTTP headers of udplogging

I am in total favor of this! In fact we have it on our todo list: https://mingle.corp.wikimedia.org/projects/analytics/cards/288 Best, Diederik On Wed, Mar 20, 2013 at 1:12 PM, Mark Bergsma <mark(a)wikimedia.org> wrote:

...

Diederik van Liere

6:56 p.m.

New subject: Fwd: No longer escaping spaces in HTTP headers of udplogging

Update to my previous email: I am in total favor of this! In fact we have it on our todo list: https://mingle.corp.wikimedia.org/projects/analytics/cards/288 Mark can you confirm that we can take it of our list? Best, Diederik On Wed, Mar 20, 2013 at 1:12 PM, Mark Bergsma <mark(a)wikimedia.org> wrote:

...

Diederik van Liere

15 Apr 15 Apr

8:43 p.m.

New subject: No longer escaping spaces in HTTP headers of udplogging

On Wed, Mar 20, 2013 at 1:12 PM, Mark Bergsma <mark(a)wikimedia.org> wrote:

...

Hey Mark, Has this already happened or shall I open an RT ticket for it? Best, Diederik

Ori Livneh

9:02 p.m.

On Monday, April 15, 2013 at 11:43 AM, Diederik van Liere wrote:

...

Has this already happened or shall I open an RT ticket for it?

Already happened, AFAIK: https://gerrit.wikimedia.org/r/#/c/55558/ https://gerrit.wikimedia.org/r/#/c/55568/ -- Ori Livneh

Diederik van Liere

9:31 p.m.

New subject: No longer escaping spaces in HTTP headers of udplogging

Awesome! ty Ori D On Mon, Apr 15, 2013 at 3:02 PM, Ori Livneh <ori(a)wikimedia.org> wrote:

...

On Monday, April 15, 2013 at 11:43 AM, Diederik van Liere wrote:

Has this already happened or shall I open an RT ticket for it?

Already happened, AFAIK: https://gerrit.wikimedia.org/r/#/c/55558/ https://gerrit.wikimedia.org/r/#/c/55568/ -- Ori Livneh _______________________________________________ Analytics mailing list Analytics(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/analytics

David Schoonover

16 Apr 16 Apr

12:12 a.m.

New subject: No longer escaping spaces in HTTP headers of udplogging

As a note, we *do* need to start escaping tabs. I've already encountered a small number in the mobile stream. -- David Schoonover dsc(a)wikimedia.org On Mon, Apr 15, 2013 at 12:31 PM, Diederik van Liere < dvanliere(a)wikimedia.org> wrote:

...

Awesome! ty Ori D On Mon, Apr 15, 2013 at 3:02 PM, Ori Livneh <ori(a)wikimedia.org> wrote:

On Monday, April 15, 2013 at 11:43 AM, Diederik van Liere wrote:

Has this already happened or shall I open an RT ticket for it?

_______________________________________________ Analytics mailing list Analytics(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/analytics

Ori Livneh

12:30 a.m.

Abridged timeline: On Saturday, January 26, 2013 at 11:13 PM, Ori Livneh wrote:

...

I don't think means you have to ditch tabs -- I doubt there's a problem-free delimiter. But you should write code and configure software with the expectation that literal tabs will be encountered so that you can deal with it gracefully.

On Saturday, January 26, 2013 at 12:57 PM, Diederik van Liere wrote:

...

Now there could be a tab in a header value as well but I have never seen it in our logfiles and i also grepped for it on a couple of random files and found no such occurrences. So we are not going to escape tab characters in fields unless new information changes our mind.

On Sunday, January 27, 2013 at 5:07 AM, Erik Zachte wrote:

...

If we bet tabs will never be introduced in the input stream, even where they are legal, and we take that approach on several issues, one of those unlikely events will surely happen sooner than you think

On Monday, April 15, 2013 at 3:12 PM, David Schoonover wrote:

...

As a note, we *do* need to start escaping tabs. I've already encountered a small number in the mobile stream.

Dan Andreescu

3:49 p.m.

New subject: No longer escaping spaces in HTTP headers of udplogging

On Mon, Apr 15, 2013 at 6:30 PM, Ori Livneh <ori(a)wikimedia.org> wrote:

...

Abridged timeline: On Saturday, January 26, 2013 at 11:13 PM, Ori Livneh wrote:

I don't think means you have to ditch tabs -- I doubt there's a

problem-free

delimiter. But you should write code and configure software with the expectation that literal tabs will be encountered so that you can deal

with it

gracefully.

On Saturday, January 26, 2013 at 12:57 PM, Diederik van Liere wrote:

Now there could be a tab in a header value as well but I have never seen

it in

our logfiles and i also grepped for it on a couple of random files and

found no

such occurrences. So we are not going to escape tab characters in fields

unless

new information changes our mind.

On Sunday, January 27, 2013 at 5:07 AM, Erik Zachte wrote:

If we bet tabs will never be introduced in the input stream, even where

they

are legal, and we take that approach on several issues, one of those unlikely events will surely happen sooner than you think

On Monday, April 15, 2013 at 3:12 PM, David Schoonover wrote:

As a note, we *do* need to start escaping tabs. I've already encountered a small number in the mobile stream.

:) Erik just leveled up his future-telling powers

4021

days inactive

4048

days old

analytics@lists.wikimedia.org

Manage subscription

8 comments

5 participants

tags (0)

participants (5)

Dan Andreescu
David Schoonover
Diederik van Liere
Mark Bergsma
Ori Livneh