Sure; just run by my desk when you have a free moment. I've checked in with Yuvi and we've fixed it for Android (the existing code shooould work, there was just a delta between 'how the code works' and 'how the code was reported to work'; I'm going to work on iOS for a bit now.
On 16 April 2014 09:26, Adam Baso <abaso@wikimedia.org> wrote:
Sounds good. Available today? I have an open calendar 1105-1355 and 1405-COB.-AdamOn Wed, Apr 16, 2014 at 9:15 AM, Oliver Keyes <okeyes@wikimedia.org> wrote:
So, it identifies the first one as Android, but can't pick out version number, and identifies the second as running Mobile Safari, but can't pick out the OS or device. I would recommend tweaking and testing these strings before deploying them if we want accurate device numbers (and we totally want accurate device numbers). Happy to help with the 'testing' part. Will chip in on gerrit directly.
On 15 April 2014 19:17, Oliver Keyes <okeyes@wikimedia.org> wrote:
Cool. I'm going to run the ua-parser over them tomorrow to see if it recognises the devices or not, if that works?
On 15 April 2014 18:31, Adam Baso <abaso@wikimedia.org> wrote:
And here's a patchset just posted for review for the iOS app.Here are examples of what the UAs will look like in the logs:WikipediaApp/2.0-alpha-2014-04-11 (Android/4.4.2)WikipediaApp/iOS-Wikipedia-4.0-4.0 (iPhone OS/7.1)(I suspect "4.0-4.0" will change in the latter, though, as production build is approached.)On Fri, Apr 4, 2014 at 4:04 PM, Oliver Keyes <okeyes@wikimedia.org> wrote:
_______________________________________________Cool. Let me know when some examples go out and I'll take a look at how our standardised UA parser treats them for the mobile metrics.
On 4 April 2014 11:52, Yuvi Panda <yuvipanda@gmail.com> wrote:
https://gerrit.wikimedia.org/r/#/c/123117/ got merged, so when the
next alpha goes out for Android (in a few hours) it should have the
new user agent!
On Wed, Apr 2, 2014 at 3:54 AM, Yuvi Panda <yuvipanda@gmail.com> wrote:
> As followup: QChris did the actual work of reading the relevant RfC
> for me, and for now I've settled on:
>
> WikipediaApp/<version> (<OS>/<version>; <form-factor>)
>
> https://gerrit.wikimedia.org/r/#/c/123117/ is a WIP patch for adding
> this to Android, I suppose an iOS patch will come later. Checkuser
> work will probably take a bit more time to materialize.
>
> Thanks everyone for chiming in!
--Oliver Keyes
Research Analyst
Wikimedia Foundation
Mobile-l mailing list
Mobile-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mobile-l
--Oliver Keyes
Research Analyst
Wikimedia Foundation
--Oliver Keyes
Research Analyst
Wikimedia Foundation
--Oliver Keyes
Research Analyst
Wikimedia Foundation