Hi,
On Thu, Aug 23, 2012 at 2:46 AM, MZMcBride <z(a)mzmcbride.com> wrote:
Perhaps revisions that receive no feedback for thirty
days should be
auto-merged and auto-deployed.
That's a pretty horrible solution. IMO, all code *must* be reviewed[0]
before merge.
[0] or at least submitted by a very trusted person. but really it
should all be reviewed. post commit review is fine sometimes but not
ok if it that means the review just never happens at all.
Maybe there could be an automated test for how we're doing and when we
hit certain levels trigger some action.
"warning" could do some or any of
* tweet
* msg an IRC channel
* send an email
"critical" could lock repos so that
* even people that typically have merge rights can't merge
* make exceptions for any really old changesets by "volunteers" (e.g.
20 or 60 days)
* make exceptions for changes
that have some extraordinary rationale
(why they should be an exception) and maybe 2 approvals instead of
just one
NB: I have no idea how well gerrit supports stuff like 2 approvals
instead of 1. but temporarily changing merge rights should be easy to
automate. (without changing group memberships)
Levels should probably be a range so that we don't flap. (don't
trigger a level until you reach the high and don't clear the level
until you drop below the low)
-Jeremy