On 26/08/10 21:53, Aryeh Gregor wrote:
On Wed, Aug 25, 2010 at 6:35 PM, Rob
Lanphier<robla(a)wikimedia.org> wrote:
Could someone(s) write up a design doc and put
something in Bugzilla
requesting this? It seems like a sensible thing to do, but not likely
to happen without prodding.
I filed a bug:
https://bugzilla.wikimedia.org/show_bug.cgi?id=24948
The one fixing the bug would design the fix, presumably. That's
generally easier than fixing someone else's design anyway.
I have started to do it (or at least try). The main problem is: how to
check if the user has ever belonged to the group? Should I (a) search
the log or (b) create a new database table for former user groups or (c)
add a column to the user_groups table so that if a user is kicked off
some group the row is not deleted but the value is changed?
I'm not sure if the goal is not too trivial for (b) and (c). But (a)
doesn't seem very elegant to me. (Was the log meant to be read by other
parts of the code?)
From all these options (c) seems the neatest. But that would mean
searching for all places where this table is used... And I don't really
feel like altering core tables. (b) would be simpler but produces some
redundancy...
Any advice?
lampak