[Pywikipedia-l] [ pywikipediabot-Patches-1880140 ] Decode Esperanto titles

[SourceForge.net]

Patches item #1880140, was opened at 2008-01-26 03:48
Message generated for change (Comment added) made by wikipedian
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=1880140&group_id=93107

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: AndreasJS (andreasjs)
Assigned to: Nobody/Anonymous (nobody)
Summary: Decode Esperanto titles

Initial Comment:
Titles have to be decoded from x convention for liks to work properly.
Here is the patch:


Index: wikipedia.py
===================================================================
--- wikipedia.py        (revision 4939)
+++ wikipedia.py        (working copy)
@@ -454,6 +454,8 @@
                     pass
         if underscore:
             title = title.replace(' ', '_')
+        if self.site().lang == 'eo':
+            title = decodeEsperantoX(title)
         return title
 
     def titleWithoutNamespace(self, underscore=False):



----------------------------------------------------------------------

>Comment By: Daniel Herding (wikipedian)
Date: 2008-10-10 01:44

Message:
I think it is OK the way it is now. If it is not, please open a bug report
with information on how to reproduce the problem.

----------------------------------------------------------------------

Comment By: AndreasJS (andreasjs)
Date: 2008-06-23 23:41

Message:
Logged In: YES 
user_id=1738850
Originator: YES

No, don't close, but try to fix it properly. This patch fixes bug 1879122
(Double redirect fixes not coding special characters in EO.WP)  but
provokes bug 1988771. See also bug (Bot wants to remove existing eo:
pages). So instead of declaring this patch "evil", one should try to find a
solution to fix both bugs. For this to happen, there should be a clear
rationale for when to  X-code an esperanto text and when not. 



----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-06-23 22:22

Message:
Logged In: NO 

close this **evil** patch?

----------------------------------------------------------------------

Comment By: Francesco Cosoleto (cosoleto)
Date: 2008-06-13 12:19

Message:
Logged In: YES 
user_id=181280
Originator: NO

Applied in r5305, undone in r5563.

See [ 1988771 ] Encoding issues with Esperanto
(https://sourceforge.net/tracker/index.php?func=detail&aid=1988771&group_id=93107&atid=603138)

----------------------------------------------------------------------

Comment By: Andr Malafaya Baptista (malafaya)
Date: 2008-01-26 15:50

Message:
Logged In: YES 
user_id=1037345
Originator: NO

This seems to be working fine using "redirect.py -lang:eo double".

----------------------------------------------------------------------

Comment By: AndreasJS (andreasjs)
Date: 2008-01-26 15:37

Message:
Logged In: YES 
user_id=1738850
Originator: YES

File Added: wikipedia.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=1880140&group_id=93107