[Pywikipedia-l] [ pywikipediabot-Bugs-1782842 ] NoPage error in getEditPage() when page exists

[SourceForge.net]

Bugs item #1782842, was opened at 2007-08-27 21:10
Message generated for change (Comment added) made by cosoleto
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1782842&group_id=93107

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 6
Private: No
Submitted By: Francesco Cosoleto (cosoleto)
Assigned to: Nobody/Anonymous (nobody)
Summary: NoPage error in getEditPage() when page exists

Initial Comment:
In getEditPage() a NoPage error can occur when HTML page isn't 100% downloaded due to bad connection. Maybe we can replace 'RversionTab' related code with a simple "if len(text[i1:i2]) <= 1" or "if text[i1:i2] == '\n')". Good? Better idea?

----------------------------------------------------------------------

Comment By: Francesco Cosoleto (cosoleto)
Date: 2008-10-09 21:55

Message:
I think current revision works, due to content-length check, though a new
download always start from the beginning when "</textarea>" is recevied
correctly. This isn't often a good choice, but the issue is closeable.

----------------------------------------------------------------------

Comment By: Francesco Cosoleto (cosoleto)
Date: 2007-09-30 16:31

Message:
Logged In: YES 
user_id=181280
Originator: YES

Using this fix:

         if not matchVersionTab:
-            raise NoPage(self.site(), self.aslink(forceInterwiki =
True))
+            if not (len(text[i1:i2].rstrip()) > 0 and self._namespace !=
8):
+                raise NoPage(self.site(), self.aslink(forceInterwiki =
True))

An incorrect NoPage error still can occur when those conditions are
satisfied: you get a blanked page, <textarea> field correctly recevied,
then connection closed before version history tab code is transmitted. But
that is extremely rare, I guess.


----------------------------------------------------------------------

Comment By: Francesco Cosoleto (cosoleto)
Date: 2007-09-14 20:14

Message:
Logged In: YES 
user_id=181280
Originator: YES

Example of bug consequence:

http://it.wikipedia.org/w/index.php?title=Utente:RevertBot/Report_agosto_2007&diff=10359730&oldid=10351188

copyright_put.py overwrite original page with new text instead of work in
append mode.

Suggested patch don't work with 'MediaWiki' namespace. Anyway if textarea
field is filled getEditPage() should not raise a NoPage exception.



----------------------------------------------------------------------

Comment By: Francesco Cosoleto (cosoleto)
Date: 2007-09-14 20:11

Message:
Logged In: YES 
user_id=181280
Originator: YES

Example of bug consequence:

http://it.wikipedia.org/w/index.php?title=Utente:RevertBot/Report_agosto_2007&diff=10359730&oldid=10351188

copyright_put.py overwrite original page with new text instead of work in
append mode.

Suggested patch don't work with 'MediaWiki' namespace. Anyway if textarea
field is filled getEditPage() should not raise a NoPage exception.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1782842&group_id=93107