On Fri, Dec 9, 2011 at 4:48 PM, Brion Vibber <span dir="ltr"><<a href="mailto:bvibber@wikimedia.org">bvibber@wikimedia.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Fri, Dec 9, 2011 at 4:15 PM, Brion Vibber <span dir="ltr"><<a href="mailto:bvibber@wikimedia.org" target="_blank">bvibber@wikimedia.org</a>></span> wrote:<br></div><div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><div class="gmail_quote"><div>To ensure that bookmarked or 'saved' pages are consistently available, either a homebrew loader cache with some smarts or something like the existing URLCache should help; but it'd need to be changed to handle images better etc.<br>
<br>I prefer the homebrew loader cache, since it allows standard HTML security separations to stay in effect (assuming PhoneGap doesn't disable them all, which it might considering that the file: pages can do anything to the iframe).<br>
</div></div></blockquote></div><div><br>Bad news: that (WebViewClient.shouldInterceptRequest) seems to only be available on Android 3 and later. Manually loading as with URLCache should work though. Sigh...<span class="HOEnZb"><font color="#888888"><br>
</font></span></div></div></blockquote><div><br>Good news: good results so far using URLCache plugin to save just the bookmarked pages.<br><br>Pushed to same branch: <a href="https://github.com/brion/Wikipedia/commits/cache-setcachemode">https://github.com/brion/Wikipedia/commits/cache-setcachemode</a><br>
<br>Likely next steps on the cache front:<br>* make sure things work consistently ;)<br>* make bookmarked pages update in UrlCache when we load them again<br>
* make bookmarks/saved pages list searchable when offline<br>
* highlight bookmarked/saved pages in search results, history<br>
* consider if renaming 'bookmarks' to 'saved pages' would make more sense<br>* make UrlCache usage behave nicer for bookmark saves -- there are flashes as images and styles load, etc, probably due to the way things get loaded in separate pieces (switch to XHR and preload the styles?)<br>
* (Java side?) make sure we understand the cache size limits on UrlCache<br>* ensure that UrlCache is safe-ish<br>* (Java side) see if we can switch in the 'load from cache first' mode only when offline<br>
<br>And related:<br>* general bookmarks cleanup & testing<br>* general history view cleanup & testing<br><br>-- brion<br></div></div>