Glad to hear you were aware of the earlier work. I agree it is often easier
to reimplement something from scratch than finishing someone else work.
Regarding the static maps on initial load, I found this feature to be
unintuitive when I tried it. IMO, it would be better to just show a spinner
while the map is loading, rather than requiring an extra click to get to
the actual map.
The rest of the functionality seemed quite smooth and intuitive. Nice work!
Ryan Kaldari
On Wed, Mar 12, 2014 at 3:50 PM, Gergo Tisza <gtisza(a)wikimedia.org> wrote:
On Wed, Mar 12, 2014 at 2:42 PM, Ryan Kaldari
<rkaldari(a)wikimedia.org
wrote:
Ack, I wish I had known about this earlier. Most
of these features had
already been implemented for UploadWizard, but the patches were never
polished enough to be merged:
https://gerrit.wikimedia.org/r/#/c/12352/
https://gerrit.wikimedia.org/r/#/c/12353/
I would be good to at least compare against your implementation and see
if
there are any ideas that would be useful to
incorporate.
I looked at those some time ago, but reusing them didn't seem much less
effort than reimplementing (also the OPW project had more ambitious goals
like Nominatim integration and using static maps initially to speed up page
load).
I didn't compare visually (you used CloudMade tiles, Anu uses MapQuest),
that would be worth doing.
There is also a third OSM integration attempt,
https://github.com/lukaszkostrzewa/wiki which has some additional
server-side features which look interesting although probably overlap with
MobileFrontend's Nearby.
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l