[Commons-l] About MediaWiki:Main_page_thumbnail_cycler.js

[Krinkle]

Hi Magnus,

I've checked it out with Web Inspector in Safari (ala Firebug in  
Firefox) and noticed it tries to load in (one or more times each loop)  
an "undefined" thing to url: http://commons.wikimedia.org/wiki/ 
undefined . This sometimes causes a questionmark-image to appear in  
the flow. Not sure what causes this.

Tho I haven't read the script fully and extensively I noticed an  
additional API call is made to aquire the thumbnail paths. It could be  
that you need that API-call for some other information, if that's not  
the case you might be able to save that additional Ajax request by  
using something like this:

http://commons.wikimedia.org/w/thumb.php?f=Example.jpg&w=100

--
Greetings,
Krinkle

Op 16 mei 2010, om 17:04 heeft Magnus Manske het volgende geschreven:

> On Sun, May 16, 2010 at 4:02 PM, Magnus Manske
> <magnusmanske at googlemail.com> wrote:
>> On Sun, May 16, 2010 at 2:40 AM, Gnangarra <gnangarra at gmail.com>  
>> wrote:
>>> Does the page need any of the banners on the main page, loosing  
>>> these would
>>> bring all the information up the page.
>>>
>>> Could there be a Java sript box to cycle through a few images  
>>> rather than
>>> just one.
>>
>> Hacked something:
>> http://commons.wikimedia.org/w/index.php?title=Main_Page&withJS=MediaWiki:Main_page_thumbnail_cycler.js
>>
>> Feel free to alter.
>>
>> Cheers,
>> Magnus
>>
>
> Sorry, should be:
> http://commons.wikimedia.org/wiki/Main_Page?withJS=MediaWiki:Main_page_thumbnail_cycler.js
>
> _______________________________________________
> Commons-l mailing list
> Commons-l at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/commons-l