Took me 4 commits to get the formatting right in release notes. And I'm
still not 100% on formatting comments properly - though I am always
confident that Rob will let me know if it's wrong. ;-)
I would like to note that I really do appreciate everyone who has let me
know when my commits aren't up to snuff. Especially when I get to learn
something from it (thx TimStarling and, of course, robchurch). I think MW
really does have a great group of people interested in it's success and it's
a great place to learn how to collaborate.
I recently got targeted for a "Code Review" on a custom app at work
(
vb.net/ajax stuff mostly) and was really quite confident as having all the
MW developers notice every single line of code you commit to SVN really gets
you comfortable with your code and having others comment/review your code.
Basically, it's nice to be able to say "My code has been reviewed by far
better men (and women) than you, so go ahead, friend." So thanks guys/gals.
-Tim Laqua
-----Original Message-----
From: wikitech-l-bounces(a)lists.wikimedia.org
[mailto:wikitech-l-bounces@lists.wikimedia.org] On Behalf Of Thomas Dalton
Sent: Tuesday, October 02, 2007 5:56 PM
To: wikitech-l(a)lists.wikimedia.org
Subject: Re: [Wikitech-l] [MediaWiki-CVS] SVN:
[26332]trunk/extensions/Cite/Cite.php
On 02/10/2007, robchurch(a)svn.wikimedia.org <robchurch(a)svn.wikimedia.org>
wrote:
Revision: 26332
Author: robchurch
Date: 2007-10-02 22:43:28 +0000 (Tue, 02 Oct 2007)
Log Message:
-----------
Spacing
You just couldn't let my first proper commit go by without finding
something wrong with it, could you? ;)
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
http://lists.wikimedia.org/mailman/listinfo/wikitech-l