Point 1: Upstream are running the master branch of gerrit. So as soon as 2.16 is branched and released then a point release is done we will be able to upgrade to it on gerrit.wikimedia.org. Point 2: Same as above. That feature will roll out to gerrit.wikimedia.org as soon as we upgrade. Point 3: This will roll out when we upgrade. Point 4: their jenkins bot is operated by luca from gerritforge. He uses emojis in the comments which we could do now with our own install. On Thursday, 4 October 2018, 09:16:03 BST, Addshore <addshorewiki(a)gmail.com> wrote: I'm still currently using the old UI, here are some things that I have noticed. #1 While comparing gerrit-review.googlesource.com and our gerrit install I have found that the googlesource version seems easier to look at. I think some of this is down to the greater contrast difference and the couple of extra seperating lines that they use. The main one that I would like to see on our install is line between the meta data on the left and the commit message centre screen. #2 My workflow now requires an extra click. I don't use git-review and instead just use the links provided by gerrit to checkout patches. Again, this seems to be less of an issue on googlesource which has a "download" button on the main patch pages, ours however is hidden within the "more" menu. I would like to see the download button straight away and avoid this extra click. #3 Upstream seems to have "sizeBars" element on each changed file indicating the additions and removals, I like this, and miss this from our current "old ui". #4 When Jenkins reports on a patch the FAILURE or SUCCESS text has a text colour of either red or green in the old UI. googlesource also has some coloured representation of success of failure when reported by their CI, but our new poly gerrit doesn't seem to. Thats it from me right now. On Wed, 3 Oct 2018 at 23:29, Thiemo Kreuz <thiemo.kreuz(a)wikimedia.de> wrote: _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Upstream just posted this https://groups.google.com/forum/#!topic/repo-discuss/yON4C-hIk-o for PolyGerrit plans in 2.16 / 3.0. So it's confirmed that the planned removal of GWTUI will be in 3.0. On Thursday, 4 October 2018, 19:35:46 BST, Paladox via Wikitech-l <wikitech-l(a)lists.wikimedia.org> wrote: Yep avatars are not yet enabled, but we have implemented the backend to support it. Changes that are left to merge https://gerrit.wikimedia.org/r/c/operations/puppet/+/439808 and https://gerrit.wikimedia.org/r/c/operations/puppet/+/456437 What do you mean by "URLs are hard to get right due to arcane escaping rules. I have been completely unable to make search shortcuts that work in both the old and new UI."? Upstream have fixed some urls that were breaking when switching to the old ui. These fixes are on the master branch. "Probably not a UI thing, but it's very annoying that patch uploaders cannot edit the description of their own patch (the gerrit patchset description, not the commit summary)" Filled upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9809 "* For me the most unintuitive part is the relation chain, especially when it is nonlinear. A graph view would be handy there, and also making it more explicit what is the parent and what is the child." Filed upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9810     On Thursday, 4 October 2018, 19:15:32 BST, Gergo Tisza <gtisza(a)wikimedia.org> wrote:  Thanks for your work on Gerrit, Paladox! The Polygerrit upgrade looks great; the thread view is especially amazing. (If you are not familiar with it, check this patch [1] and click "Comment Threads" near the bottom of the screen.) I mostly have behavior issues (on gerrit.wikimedia.org; I haven't tested whether they affect 2.16):* URLs are hard to get right due to arcane escaping rules. I have been completely unable to make search shortcuts that work in both the old and new UI.* Almost impossible to find clone URLs. (T206049, but also in the old UI I could click through from the patch to the to the repo admin screen and that's also impossible to find now. I see it's slightly easier in 2.16 but still annoying.)* For me the most unintuitive part is the relation chain, especially when it is nonlinear. A graph view would be handy there, and also making it more explicit what is the parent and what is the child.* Probably not a UI thing, but it's very annoying that patch uploaders cannot edit the description of their own patch (the gerrit patchset description, not the commit summary). On the plus side,* Avatars are really nice and make the whole experience more human. (They are not enabled on the Wikimedia Gerrit yet, right?)* At some point search autocomplete switched from prefix-autocompletion to substring-autocompletion (e.g. for project names). That sounds like a small thing but it really made life a lot more convenient. [1] https://gerrit-review.googlesource.com/c/gerrit/+/196470 _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

On Thu, Oct 4, 2018 at 11:15 AM, Gergo Tisza <gtisza(a)wikimedia.org> wrote: Yes, that is/was a bit more complicated than it may seem. For security reasons we have a separate domain for user uploads. As you might have noticed on Phabricator we use phab.wmfusercontent.org for uploaded files. In the same way we needed to first create gerrit.wmfusercontent.org to make this possible, followed by Varnish config for it, then Apache and so on. As Paladox pointed out a bunch of things have already been merged but at least 2 are left open. Having reviewed/merged most of the previous ones i will look into pushing this forward again to finalize it. Then we will have avatars on Gerrit. https://phabricator.wikimedia.org/T191183#4278525 https://gerrit.wikimedia.org/r/#/q/project:operations/puppet+branch:product… -- Daniel Zahn <dzahn(a)wikimedia.org> Operations Engineer

I have filed it upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9815 On Friday, 5 October 2018, 06:54:25 BST, Dalba <dalba.wiki(a)gmail.com> wrote: I have issues with copying the text of changed files: `ctrl+a` does not work as it used to anymore: While using the side-by-side diff view, go to a changed file, click on the old/new revision, press `ctrl+a`. In the old UI only the text of the selected file would have been selected, but now the whole page gets selected which is not that useful. Also, copying multiple lines results in extra whitespace being copied in the middle of the lines. For example goto [1], select the text of both lines and copy... It'll be copied as `# -*- coding: utf-8 -*-\n\t\n\t\n"""Package to hold all library tests."""` (note the `\n\t\n\t\n` which should have been just a `\n`). [1]: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/463061/5/tests/library_te… On Thu, Oct 4, 2018 at 12:39 AM Paladox via Wikitech-l <wikitech-l(a)lists.wikimedia.org> wrote:

I must note that with the branching of 2.16, it means that GWTUI is going away. With the removal of GWTUI in https://gerrit-review.googlesource.com/c/gerrit/+/116790 On Tuesday, 16 October 2018, 16:30:53 BST, Paladox via Wikitech-l <wikitech-l(a)lists.wikimedia.org> wrote: Upstream have just branched 2.16 with a rc release a few hours away! So a stable release should be done shortly with all the improvements to polygerrit's ui and a inline editor too!     On Friday, 5 October 2018, 19:26:30 BST, Paladox via Wikitech-l <wikitech-l(a)lists.wikimedia.org> wrote:    I have filed it upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9815     On Friday, 5 October 2018, 06:54:25 BST, Dalba <dalba.wiki(a)gmail.com> wrote:  I have issues with copying the text of changed files: `ctrl+a` does not work as it used to anymore: While using the side-by-side diff view, go to a changed file, click on the old/new revision, press `ctrl+a`. In the old UI only the text of the selected file would have been selected, but now the whole page gets selected which is not that useful. Also, copying multiple lines results in extra whitespace being copied in the middle of the lines. For example goto [1], select the text of both lines and copy... It'll be copied as `# -*- coding: utf-8 -*-\n\t\n\t\n"""Package to hold all library tests."""` (note the `\n\t\n\t\n` which should have been just a `\n`). [1]: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/463061/5/tests/library_te… On Thu, Oct 4, 2018 at 12:39 AM Paladox via Wikitech-l <wikitech-l(a)lists.wikimedia.org> wrote: _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

I've implemented some like that for my personal issue tracker, based on the PGP word list (https://en.wikipedia.org/wiki/PGP_word_list). Each ticket id is converted into hexadecimal, and the first six hex digit are used to look up word. For example, I have tickets such as "REPAY RETRACTION MERIT" and "BEFRIEND CELEBRATE DROPPER". For my issue tracker, ticket ids are random 64-bit digits, which helps. I'm not sure how well this would work for sequential integers. On Tue, Oct 16, 2018 at 6:56 PM C. Scott Ananian <cananian(a)wikimedia.org> wrote: