K. Peachey wrote: Just direct usage of styling, specifically anything approximately matching 'style="[...]"'. The script only looked at the wikitext directly used in pages as that's what's provided by the XML dumps. I think having styling in templates is at least a much better place for it, as template invocations are tracked/indexed by MediaWiki and the use of templates means that the styling code is a lot more centralized. MZMcBride

Daniel Friesen wrote: This reply confused me a little. The script I ran exclusively looked at pages in the main namespace and exclusively looked at an XML dump, which is unexpanded wikitext. That is, assuming people aren't doing a lot of inline styling as arguments/parameters to templates, we should already have a decent amount of segregation as I only looked at direct uses. Looking at the template namespace or looking at pages post-expansion would be annoying. I think templates aren't necessarily a bad place for inline styling, so I'm a lot less focused on templates than I am on articles.

Robert Rohde wrote: Err, based on what? :-) These numbers are instances of style="[...]", not page counts. Looking at a specific example from <https://phabricator.wikimedia.org/P2230>: 1164 font-family: 'microsoft yi baiti', 'noto sans yi', nsimsun-18030, simsun-18030, 'sil yi', code2000; These 1,164 inline styling instances all come from a single article: <https://en.wikipedia.org/w/index.php?oldid=672244691&action=edit>. Maybe that's the confusion? I tried to make my descriptions as clear as possible and I'm not saying a major bug is impossible, of course, but I don't have any reason so far to doubt the data I collected. Another strange case is "background-color: {{/meta/color}};", which had 16,432 instances. This almost looks like it would try to transclude a subpage of the article, but due to subpages being disabled in the main namespace on the English Wikipedia, it's actually transcluding a template named "/meta/color": <https://en.wikipedia.org/wiki/Template:/meta/color>. I did concurrently look at the approximate number of non-redirect pages that contain inline styling. My findings were that about 408,777 non-redirect pages contain some kind of inline styling on the English Wikipedia (cf. <https://phabricator.wikimedia.org/T115228#1752223>). MZMcBride _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

It appears that the summary may have normalized the formatting of the CSS. 143095 display: none; Your query[1] assumes a space after "display:" and gives 218 results. Using no space[2] gives 2,473 results, but still assumes that no other elements occur in the style attribute. A regex query[3] with "display:" + optional spaces + "none" gives 4,296 results, or a more reasonable average of 33 per result. That query may be overly aggressive and match outside of style contexts, but it also matches *list_style = text-align:center;display:none,* and *style="font-size: normal; text-align: left; display: none;"* which I think is a good thing (definitely in the latter case). Parsing a dump of enwiki is more accurate than running insource: queries. —Trey [1] https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=adv… [2] https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=adv… [3] https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=def… Trey Jones Software Engineer, Discovery Wikimedia Foundation On Tue, Oct 27, 2015 at 10:41 AM, Robert Rohde &lt;rarohde(a)gmail.com&gt; wrote: that searchable result per would nearly https://en.wikipedia.org/w/index.php?search=efcfff&title=Special%3ASear… https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=adv… https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=adv… https://en.wikipedia.org/w/index.php?title=Special:Search&search=insour… at nsimsun-18030, template https://en.wikipedia.org/wiki/Template:/meta/color _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Robert Rohde wrote: Almost, but not quite. You actually want this: insource:/style[ ]*=[ ]*\"display:[ ]*none;?[ ]*\"/i With the semicolon being made optional, the search results increase from 487 to 2,487 currently on the English Wikipedia. The normalization script (<https://phabricator.wikimedia.org/P2229>) made the trailing semicolon consistent, in addition to lowercasing and trying to account for strange spacing. For whatever reason, "display: none;" is often written without the trailing semicolon in main namespace pages on the English Wikipedia. I was worried that I may have made a major coding mistake, so I re-ran my script using this pattern: pattern = r'style[ ]*=[ ]*"[ ]*display[ ]*:[ ]*none[ ]*;?[ ]*"' The results are available here: <https://phabricator.wikimedia.org/P2255>. Sixteen articles have over 1,000 instances of "display: none;" each! The total is 142,176 instances of "display: none;" (normalized) in 2,507 main namespace pages on the English Wikipedia, as of about 2015-10-02. After re-reviewing the code and re-running the script to focus on "display: none;" specifically, there's strong evidence to suggest that the numbers are accurate, if not a bit surprising in some cases. :-) MZMcBride _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l