Changed JS API?

List overview All Threads
Download

newer

older

Wikibase: new security fix...

How to respect throttling and...

Max Kristen

16 Nov 2019 16 Nov '19

12:49 a.m.

Hi Tech-Mailinglist, I'm using this gadget here: https://www.wikidata.org/wiki/Wikidata:Tools/Enhance_user_interface#CiteTool in its current incarnation here: https://www.wikidata.org/wiki/User:MichaelSchoenitzer/CiteTool.js It doesn't seem to work since the last few weeks, maybe because it calls on PropertyValueSnak, which seems to have moved since the last JS API version. https://doc.wikimedia.org/Wikibase/master/js/#!/api/PropertyValueSnak Is the API not ready to be stable yet, and how can this be fixed? Greetings Max

Show replies by date

Lucas Werkmeister

16 Nov 16 Nov

2:29 p.m.

The Wikibase JavaScript code has never been a stable interface, as the Stable Interface Policy [1] explicitly points out. As for PropertyValueSnak, it should now be loaded via ResourceLoader – mw.loader.using( 'wikibase.datamodel' ) .then( function ( require ) { var datamodel = require( 'wikibase.datamodel' ), PropertyValueSnak = datamodel.PropertyValueSnak, EntityId = datamodel.EntityId; // ... } ); – but that’s not the error I get anyways (I get “Error loading citoid config”, because it’s trying to load a JSON file as JavaScript, I think). Cheers, Lucas [1]: https://www.wikidata.org/w/index.php?title=Wikidata:Stable_Interface_Policy… On 16.11.19 01:49, Max Kristen wrote:

...

Michael Schönitzer

18 Nov 18 Nov

12:05 a.m.

Hi, Am Sa., 16. Nov. 2019 um 15:30 Uhr schrieb Lucas Werkmeister < mail(a)lucaswerkmeister.de>gt;:

...

– but that’s not the error I get anyways (I get “Error loading citoid config”, because it’s trying to load a JSON file as JavaScript, I think).

You're using the original version of Aude, that stopped working months ago due to a security related changes to the mimetypes returned by the servers. There are at least three forks of the script that fixed this – one of me. But they now broke again, and at least I am tired of patching gadgets all the time, that break due to the lack of stable APIs. I also consider the functionality of this addon something that should be built into wikibase directly, otherwise the situation with lack of (proper) sources in Wikidata will never improve. Cheers, M

...

Cheers, Lucas [1]: https://www.wikidata.org/w/index.php?title=Wikidata:Stable_Interface_Policy… On 16.11.19 01:49, Max Kristen wrote:

Hi Tech-Mailinglist, I'm using this gadget here:

https://www.wikidata.org/wiki/Wikidata:Tools/Enhance_user_interface#CiteTool

in its current incarnation here: https://www.wikidata.org/wiki/User:MichaelSchoenitzer/CiteTool.js It doesn't seem to work since the last few weeks, maybe because it calls on PropertyValueSnak, which seems to have moved since the last JS API version. https://doc.wikimedia.org/Wikibase/master/js/#!/api/PropertyValueSnak Is the API not ready to be stable yet, and how can this be fixed? Greetings Max _______________________________________________ Wikidata-tech mailing list Wikidata-tech(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

_______________________________________________ Wikidata-tech mailing list Wikidata-tech(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

Lucas Werkmeister

10:10 a.m.

On 18.11.19 01:05, Michael Schönitzer wrote:

...

Hi, Am Sa., 16. Nov. 2019 um 15:30 Uhr schrieb Lucas Werkmeister <mail(a)lucaswerkmeister.de <mailto:mail@lucaswerkmeister.de>>: – but that’s not the error I get anyways (I get “Error loading citoid config”, because it’s trying to load a JSON file as JavaScript, I think). You're using the original version of Aude, that stopped working months ago due to a security related changes to the mimetypes returned by the servers.

No, I am not. This was using your fork, the one mentioned in the original email, and I still got this error. (I also reproduced it in a private window, just in case I had something weird in my common.js.) Cheers, Lucas

...

There are at least three forks of the script that fixed this – one of me. But they now broke again, and at least I am tired of patching gadgets all the time, that break due to the lack of stable APIs. I also consider the functionality of this addon something that should be built into wikibase directly, otherwise the situation with lack of (proper) sources in Wikidata will never improve. Cheers, M Cheers, Lucas [1]: https://www.wikidata.org/w/index.php?title=Wikidata:Stable_Interface_Policy… On 16.11.19 01:49, Max Kristen wrote:

Hi Tech-Mailinglist, I'm using this gadget here:

https://www.wikidata.org/wiki/Wikidata:Tools/Enhance_user_interface#CiteTool

in its current incarnation here: https://www.wikidata.org/wiki/User:MichaelSchoenitzer/CiteTool.js It doesn't seem to work since the last few weeks, maybe because

it calls

on PropertyValueSnak, which seems to have moved since the last

JS API

version.

https://doc.wikimedia.org/Wikibase/master/js/#!/api/PropertyValueSnak

Is the API not ready to be stable yet, and how can this be fixed? Greetings Max _______________________________________________ Wikidata-tech mailing list Wikidata-tech(a)lists.wikimedia.org

<mailto:Wikidata-tech@lists.wikimedia.org>

https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

_______________________________________________ Wikidata-tech mailing list Wikidata-tech(a)lists.wikimedia.org <mailto:Wikidata-tech@lists.wikimedia.org> https://lists.wikimedia.org/mailman/listinfo/wikidata-tech _______________________________________________ Wikidata-tech mailing list Wikidata-tech(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

Michael Schönitzer

10:29 a.m.

Am Mo., 18. Nov. 2019 um 11:11 Uhr schrieb Lucas Werkmeister < mail(a)lucaswerkmeister.de>gt;:

...

Am Sa., 16. Nov. 2019 um 15:30 Uhr schrieb Lucas Werkmeister < mail(a)lucaswerkmeister.de>gt;:

– but that’s not the error I get anyways (I get “Error loading citoid config”, because it’s trying to load a JSON file as JavaScript, I think).

You're using the original version of Aude, that stopped working months ago due to a security related changes to the mimetypes returned by the servers. No, I am not. This was using your fork, the one mentioned in the original email, and I still got this error. (I also reproduced it in a private window, just in case I had something weird in my common.js.)

Ah, I'm sorry, I think I found what went wrong here: I didn't update the installation instructions in the comment of the script, but only the one on the project-page. That's why it failed for you but worked for others. Sorry, my mistake. Cheers, M

...

Cheers,

Lucas

...

Cheers, Lucas [1]: https://www.wikidata.org/w/index.php?title=Wikidata:Stable_Interface_Policy… On 16.11.19 01:49, Max Kristen wrote:

Hi Tech-Mailinglist, I'm using this gadget here:

https://www.wikidata.org/wiki/Wikidata:Tools/Enhance_user_interface#CiteTool

_______________________________________________ Wikidata-tech mailing list Wikidata-tech(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

_______________________________________________ Wikidata-tech mailing listWikidata-tech@lists.wikimedia.orghttps://lists.wikimedia.org/mailman/listinfo/wikidata-tech _______________________________________________ Wikidata-tech mailing list Wikidata-tech(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

Léa Lacroix

16 Nov 16 Nov

4:51 p.m.

Thanks for reporting this issue! A ticket has been created: https://phabricator.wikimedia.org/T238479 We're currently investigating on the cause and I'll let you know as soon as possible about the next steps - it is possible that the gadget needs to be updated. Cheers, Léa On Sat, 16 Nov 2019 at 01:50, Max Kristen <max.kristen(a)wikipedia.de> wrote:

...

-- Léa Lacroix Project Manager Community Communication for Wikidata Wikimedia Deutschland e.V. Tempelhofer Ufer 23-24 10963 Berlin www.wikimedia.de Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V. Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das Finanzamt für Körperschaften I Berlin, Steuernummer 27/029/42207.

1639

days inactive

1641

days old

wikidata-tech@lists.wikimedia.org

Manage subscription

5 comments

4 participants

tags (0)

participants (4)

Lucas Werkmeister
Léa Lacroix
Max Kristen
Michael Schönitzer