Hey,<br><div><br>I sat down with Denny today and we had a look over the QueryEngine component code. It however still needs a more formal review.<br><br>Current unreviewed code is sitting on the sqlstore feature branch. Difference with master: <a href="https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/master...sqlstore">https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/master...sqlstore</a><br>

<br>This branch currently contains two commits [0, 1] that I made against master for non QueryEngine improvements that where needed to get the tests for the QueryEngine component to run on their own. So it&#39;d be good to have these reviewed first, then merge master into sqlstore, and no longer have them in the diff there.<br>

<br>[0] <a href="https://gerrit.wikimedia.org/r/#/c/63218/">https://gerrit.wikimedia.org/r/#/c/63218/</a><br>[1] <a href="https://gerrit.wikimedia.org/r/#/c/63219/">https://gerrit.wikimedia.org/r/#/c/63219/</a><br><br>Cheers<br>

<br>--<br>Jeroen De Dauw<br><a href="http://www.bn2vs.com" target="_blank">http://www.bn2vs.com</a><br>Don&#39;t panic. Don&#39;t be evil.<br>--</div>