[Maniphest] [Created] T95803: UnicodeDecodeError when using pywikibot delete.py

List overview All Threads
Download

newer

older

[Maniphest] [Created] T76690:...

[Maniphest] [Created]...

Wesalius

11 Apr 2015 11 Apr '15

8:21 a.m.

Wesalius created this task. Wesalius added a subscriber: Wesalius. Wesalius added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs. TASK DESCRIPTION After running **delete.py** with most recent version (Pywikibot: [https] r-pywikibot-core.git (e9db1f9, g5334, 2015/04/11, 00:17:48, o k) Release version: 2.0b3 httplib2 version: 0.9) with **-summary containing non-ascii characters** (Czech letters) move I get: ``` File "pwb.py", line 161, in <module> import pywikibot # noqa File "\core\pywikibot\__init__.py", line 32, in <modu le> from pywikibot import config2 as config File "\core\pywikibot\config2.py", line 280, in <modu le> _base_dir = get_base_dir() File "\core\pywikibot\config2.py", line 222, in get_b ase_dir if arg.startswith("-dir:"): UnicodeDecodeError: 'ascii' codec can't decode byte 0xe1 in position 22: ordinal not in range(128) ``` This task is probably related to recenetly resolved https://phabricator.wikimedia.org/T95671 TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wesalius Cc: pywikipedia-bugs, Wesalius, Aklapper, jayvdb

Show replies by date

jayvdb

11 Apr 11 Apr

8:28 a.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

jayvdb added a subscriber: jayvdb. jayvdb added a comment. This is on Windows? TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: jayvdb, Wesalius, Aklapper, pywikipedia-bugs

Wesalius

8:32 a.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

Wesalius added a comment. Yes TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wesalius Cc: jayvdb, Wesalius, Aklapper, pywikipedia-bugs

Wesalius

10:14 a.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

Wesalius added a comment. Now I got the same error when using replace.py. TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wesalius Cc: jayvdb, Wesalius, Aklapper, pywikipedia-bugs

XZise

1:34 p.m.

New subject: [Maniphest] [Updated] T95803: UnicodeDecodeError when using pywikibot delete.py

XZise added a subscriber: XZise. XZise added a comment. https://phabricator.wikimedia.org/T95671 does probably not resolve the issue. I guess arg is `bytes` and not `unicode`:

...

>> 'ä'.startswith('ä')

True

...

>> 'ä'.startswith(u'ä')

Traceback (most recent call last): File "<stdin>", line 1, in <module> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0: ordinal not in range(128) As “-dir” is now implicitly a unicode the second case happens and when arg is now bytes it must convert that into unicode to check if it startswith that letter. I guess `handle_args` needs to do some work to return `unicode`s or so. Problem is if the script expects that handle_args returns a list of `bytes`:

...

>> u'ä'.startswith('ä')

Traceback (most recent call last): File "<stdin>", line 1, in <module> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0: ordinal not in range(128) TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

valhallasw

1:36 p.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

valhallasw added a subscriber: valhallasw. valhallasw added a comment. This is in config2.py, way before handle_args is actually called. @jayvdb pointed out on irc that

...

12:50 <jayvdb> nod. its sys.argv . so '-dir:' probably needs to be str('-argv') in order to avoid decoding

handle_args uses argvu (which is the decoded form of argv provided by the user interface), and should work as expected. TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: valhallasw Cc: valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

XZise

1:36 p.m.

New subject: [Maniphest] [Updated] T95803: UnicodeDecodeError when using pywikibot delete.py

XZise added a blocked task: T89589: Usage of unicode_literals from __future__ package. TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

XZise

2:35 p.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

XZise added a comment. Oh that makes sense. Overlooked in the traceback that it happened in `config2`. Then the fix should be as @jayvdb described (although `str('-dir')` but I guess it was just a typo). TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

gerritbot

12 Apr 12 Apr

11:37 a.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 203652 had a related patch set uploaded (by XZise): [FIX] config2: Support unicode args https://gerrit.wikimedia.org/r/203652 TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

gerritbot

11:37 a.m.

New subject: [Maniphest] [Updated] T95803: UnicodeDecodeError when using pywikibot delete.py

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

gerritbot

12:11 p.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

gerritbot added a comment. Change 203652 merged by jenkins-bot: [FIX] config2: Support unicode args https://gerrit.wikimedia.org/r/203652 TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

gerritbot

17 Apr 17 Apr

10:12 p.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

gerritbot added a comment. Change 204872 had a related patch set uploaded (by Mpaa): config2.py: Support unicode args (another case) https://gerrit.wikimedia.org/r/204872 TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

gerritbot

11:51 p.m.

New subject: [Maniphest] [Commented On] T95803: UnicodeDecodeError when using pywikibot delete.py

gerritbot added a comment. Change 204872 merged by jenkins-bot: config2.py: Support unicode args (another case) https://gerrit.wikimedia.org/r/204872 TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

jayvdb

18 Apr 18 Apr

1:28 a.m.

New subject: [Maniphest] [Closed] T95803: UnicodeDecodeError when using pywikibot delete.py

jayvdb closed this task as "Resolved". jayvdb claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T95803 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: gerritbot, valhallasw, XZise, jayvdb, Wesalius, Aklapper, pywikipedia-bugs

3318

days inactive

3324

days old

pywikipedia-bugs@lists.wikimedia.org

Manage subscription

13 comments

5 participants

tags (0)

participants (5)

gerritbot
jayvdb
valhallasw
Wesalius
XZise