https://bugzilla.wikimedia.org/show_bug.cgi?id=68705 Fabian <CommodoreFabianus(a)gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |CommodoreFabianus(a)gmx.de --- Comment #1 from Fabian <CommodoreFabianus(a)gmx.de> --- I'm confused: I don't see a possibility to get the counts without hitting the server. And the server must be hit at least once to get the pages or categories in the “worst case”. So the previous handling without using 'categoryinfo' seems to be the better solution. Of course it could be written a bit more pythonic by simply using articles = cat.articles() if articles: # remove them else: # "complain" Even the change in 'CategoryTreeRobot' should be reverted because the database should be the fasted way to get the number of articles in a category. By the way database: This seems the only way to avoid hitting the server in the “best case” (|articles| == 0). But 'CategoryMoveRobot' doesn't use the database and it's only used for read-only operations. But the changes above line 644 (old)/642 (new) look fine to me. Now of course I'm fairly new to the bot's internals, so my assessment is probably off. -- You are receiving this mail because: You are the assignee for the bug.

https://bugzilla.wikimedia.org/show_bug.cgi?id=68705 --- Comment #3 from xqt <info(a)gno.de> --- cat.articles() is a generator and bool(cat.articles()) is always True. You may try a simple performace test like: 456626 You'll get the result above immediately len(set(g)) You may wait several minutes to get a result. I've given up after 5. -- You are receiving this mail because: You are the assignee for the bug.

https://bugzilla.wikimedia.org/show_bug.cgi?id=68705 --- Comment #5 from Fabian <CommodoreFabianus(a)gmx.de> --- Okay my mistake that 'bool(cat.articles)' return true if it's not None. But you could then do something like: empty = True for page in cat.articles: empty = False if empty: # complain Now I'm sure if this is slower (but it doesn't appear so). And maybe there is a more pythonic way. The for-else does not differ between an empty list and a non empty. -- You are receiving this mail because: You are the assignee for the bug.

https://bugzilla.wikimedia.org/show_bug.cgi?id=68705 Ricordisamoa <ricordisamoa(a)openmailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ricordisamoa(a)openmailbox.or | |g --- Comment #7 from Ricordisamoa <ricordisamoa(a)openmailbox.org> --- https://gerrit.wikimedia.org/r/149645/ merged, is this fixed? -- You are receiving this mail because: You are the assignee for the bug.