jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/359685 ) Change subject: Clarify error message when test_newpages_default finds no new pages ...................................................................... Clarify error message when test_newpages_default finds no new pages Task: T159029 Change-Id: If4b1bd16220a85e963cb2fdf5e8dbe641d56a0b9 --- M tests/pagegenerators_tests.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index 3081298..cb33e67 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -857,9 +857,16 @@ gen = gf.getCombinedGenerator() self.assertIsNotNone(gen) pages = set(gen) - self.assertGreater(len(pages), 0) self.assertLessEqual(len(pages), 60) + newpages_url = self.site.base_url(self.site.path() + '?title=Special:NewPages&uselang=en') + failure_message = 'No new pages returned by -newpages. ' \ + 'If this is the only failure, check whether {url} contains any pages. ' \ + 'If not, create a new page on the site to make the test pass again.' \ + .format(url=newpages_url) + + self.assertGreater(len(pages), 0, failure_message) + def test_newpages_ns_default(self): """Test newpages generator with limit argument.""" gf = pagegenerators.GeneratorFactory(site=self.site) -- To view, visit https://gerrit.wikimedia.org/r/359685 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b1bd16220a85e963cb2fdf5e8dbe641d56a0b9 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Magul &lt;tomasz.magulski(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>