jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/423254 )
Change subject: [bugfix] Fix is_thankable expression
......................................................................
[bugfix] Fix is_thankable expression
- self.isRegistered() implies not self.isAnonymous
Bug: T191146
Change-Id: I9867e19a1283c17fdb34cb0a90d7977c718bdf8a
---
M pywikibot/page.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
JJMC89: Looks good to me, but someone else must approve
Dalba: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index 20b5491..ca95e0c 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -3599,8 +3599,7 @@
@rtype: bool
"""
- return not (self.isAnonymous() or self.isRegistered()
- or 'bot' in self.groups())
+ return self.isRegistered() and 'bot' not in self.groups()
class WikibasePage(BasePage):
--
To view, visit
https://gerrit.wikimedia.org/r/423254
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9867e19a1283c17fdb34cb0a90d7977c718bdf8a
Gerrit-Change-Number: 423254
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>